QPQ-AG/sophia
11
0
Fork 0
Code Issues 43 Pull Requests 7 Actions Packages Projects Releases 16 Wiki Activity

fix wrong regex for sophia constructors #991

Open
pharpend wants to merge 1 commits from prh-docs-fix into master
pull from: prh-docs-fix
merge into: QPQ-AG:master
Conversation 1 Commits 1 Files Changed 1
+1 -1
pharpend commented 2026-05-13 16:47:30 +09:00
Owner
Copy Link
Copy Source

Sophia constructors (Foo, Bar, Baz) cannot have quotes in them

Found this in testing. Source:

https://git.qpq.swiss/QPQ-AG/sophia/src/commit/dbab49936daad7d82bae7cf7336b1ce82e7ab779/src/so_scan.erl#L23
Sophia constructors (Foo, Bar, Baz) cannot have quotes in them Found this in testing. Source: https://git.qpq.swiss/QPQ-AG/sophia/src/commit/dbab49936daad7d82bae7cf7336b1ce82e7ab779/src/so_scan.erl#L23
pharpend added 1 commit 2026-05-13 16:47:31 +09:00
fix wrong regex for sophia constructors
Sophia Tests / tests (push) Successful in 1m20s
Details
6099566cfe 
Sophia constructors (Foo, Bar, Baz) cannot have quotes in them

Found this in testing. Source:

    dbab49936d/src/so_scan.erl (L23)
zxq9 approved these changes 2026-05-14 09:49:45 +09:00
zxq9 left a comment
Owner
Copy Link
Copy Source

Nice catch.

Nice catch.
Some checks are pending
Sophia Tests / tests (push) Successful in 1m20s
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin prh-docs-fix:prh-docs-fix
git checkout prh-docs-fix
Sign in to join this conversation.
Reviewers
No Reviewers
zxq9
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 pig lipstick
Muggle-facing enhancements
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dagadunn Pickmick dimitar.p.ivanov flambard (Markus Flambard) gchewy hans_sv pharpend spivee (Jarvis Carroll) thescientress (Cecille de Jesus) uwiger (Ulf Wiger) zxq9 (Craig Everett)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#991
Delete Branch "prh-docs-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?