QPQ-AG/sophia
12
0
Fork 0
Code Issues 43 Pull Requests 7 Actions Packages Projects Releases 16 Wiki Activity

Name lambdas by their locations #977

Merged
zxq9 merged 2 commits from gh-485 into master 2023-09-05 01:50:38 +09:00
Conversation 5 Commits 2 Files Changed 3
+89 -51
zxq9 commented 2023-09-03 00:33:14 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Created by: radrow

fixes #485

Previously names for lambdas were generated with use of a global counter. Since fcode functions are stored in maps, the order of processing local lambdas was unspecified. This resulted in lambdas getting names assigned non-deterministically during lifting.

This PR fixes that by naming lambdas according to their locations. Counters are still used to handle cases where locations are not available. However, those counters are now function-local. Inner AST has deterministic structure, thus lambdas will be numbered in DFS order.

PR is sponsored by ACF.

*Created by: radrow* fixes #485 Previously names for lambdas were generated with use of a global counter. Since fcode functions are stored in maps, the order of processing local lambdas was unspecified. This resulted in lambdas getting names assigned non-deterministically during lifting. This PR fixes that by naming lambdas according to their locations. Counters are still used to handle cases where locations are not available. However, those counters are now function-local. Inner AST has deterministic structure, thus lambdas will be numbered in DFS order. PR is sponsored by ACF.
ghallak (Migrated from gitlab.com) approved these changes 2023-09-03 00:33:14 +09:00
zxq9 commented 2023-09-03 00:48:44 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Created by: radrow

Just checked in HTTP that it does not reproduce on the provided example

*Created by: radrow* Just checked in HTTP that it does not reproduce on the provided example
zxq9 commented 2023-09-04 15:24:48 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Created by: hanssv

Review: Approved

Great job finding and fixing this one 👍

*Created by: hanssv* **Review:** Approved Great job finding and fixing this one 👍
ghallak commented 2023-09-05 01:47:07 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
zxq9 commented 2023-09-05 01:50:38 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Merged by: radrow at 2023-09-04 16:50:38 UTC

*Merged by: radrow at 2023-09-04 16:50:38 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
ghallak
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 pig lipstick
Muggle-facing enhancements
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Dagadunn Pickmick apex132 dimitar.p.ivanov flambard (Markus Flambard) gchewy hans_sv pharpend spivee (Jarvis Carroll) thescientress (Cecille de Jesus) uwiger (Ulf Wiger) zxq9 (Craig Everett)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#977