QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Add arbitrary size byte arrays #947

Merged
zxq9 merged 7 commits from arbitrary_sized_byte_arrays into ceres 2023-06-30 23:21:50 +09:00
Conversation 6 Commits 7 Files Changed 14 +270 -64
zxq9 commented 2023-05-30 18:21:56 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Introduce arbitrary sized binary arrays (type bytes()); adding Bytes.split_any, Bytes.to_fixed_size, Bytes.to_any_size, Bytes.size, String.to_bytes, and Int.to_bytes; and adjust Bytes.concat to allow both fixed and arbitrary sized byte arrays.

This PR is supported by the Æternity Crypto Foundation

*Created by: hanssv* Introduce arbitrary sized binary arrays (type `bytes()`); adding `Bytes.split_any`, `Bytes.to_fixed_size`, `Bytes.to_any_size`, `Bytes.size`, `String.to_bytes`, and `Int.to_bytes`; and adjust `Bytes.concat` to allow both fixed and arbitrary sized byte arrays. This PR is supported by the Æternity Crypto Foundation
zxq9 commented 2023-06-26 18:28:13 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: seanhinde

Would prefer:
""Concatenates two byte arrays. If m and n are..""

*Created by: seanhinde* Would prefer: ""Concatenates two byte arrays. If `m` and `n` are..""
zxq9 commented 2023-06-26 21:08:08 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: seanhinde

Review: Approved

*Created by: seanhinde* **Review:** Approved
zxq9 commented 2023-06-27 11:05:50 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

You know there is an amazing function lists:enumerate which was added to stdlib by a well known and respected compiler developer?

*Created by: radrow* You know there is an amazing function lists:enumerate which was added to stdlib by a well known and respected compiler developer?
zxq9 commented 2023-06-27 11:09:10 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Review: Approved

*Created by: radrow* **Review:** Approved
zxq9 commented 2023-06-30 21:19:45 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Yes, but only in OTP-25 :-) we still support older versions I think!

*Created by: hanssv* Yes, but only in OTP-25 :-) we still support older versions I think!
zxq9 commented 2023-06-30 23:21:50 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: hanssv at 2023-06-30 14:21:50 UTC

*Merged by: hanssv at 2023-06-30 14:21:50 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#947
No description provided.
Delete Branch "arbitrary_sized_byte_arrays"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?