QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Add hole expression #924

Merged
ghallak merged 9 commits from ghallak/391 into master 2023-01-12 22:23:36 +09:00
Conversation 6 Commits 9 Files Changed 7 +48
ghallak commented 2023-01-08 16:50:13 +09:00 (Migrated from gitlab.com)
Copy Link

Closes: #391

Closes: #391
zxq9 commented 2023-01-09 00:28:48 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

This doesn't seem right. Hole is an expression, not a type. Holes should have normal types as anything else and an error should be reported in infer_expr.

*Created by: radrow* This doesn't seem right. Hole is an expression, not a type. Holes should have normal types as anything else and an error should be reported in infer_expr.
zxq9 commented 2023-01-09 00:30:09 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Doc pls

*Created by: radrow* Doc pls
zxq9 commented 2023-01-10 22:03:38 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

A hole expression found in the example above will generate the error `` Found a hole of type `(int) => int` ``. This says that the compiler expects a function from `int` to `int` in place of the `???` placeholder.
*Created by: radrow* ```suggestion:-0+0 A hole expression found in the example above will generate the error `` Found a hole of type `(int) => int` ``. This says that the compiler expects a function from `int` to `int` in place of the `???` placeholder. ```
zxq9 commented 2023-01-12 18:51:33 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

LGTM

*Created by: hanssv* **Review:** Approved LGTM
zxq9 commented 2023-01-12 19:52:14 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Review: Approved

*Created by: radrow* **Review:** Approved
zxq9 commented 2023-01-12 22:23:36 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: ghallak at 2023-01-12 13:23:36 UTC

*Merged by: ghallak at 2023-01-12 13:23:36 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#924
No description provided.
Delete Branch "ghallak/391"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?