QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Introduce AENSv2 namespace to introduce raw data pointers #917

Merged
zxq9 merged 1 commits from add_aens_data_pointer into new_ceres 2022-11-17 05:31:44 +09:00
Conversation 8 Commits 1 Files Changed 13 +200 -73
zxq9 commented 2022-11-12 00:17:34 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

This PR is supported by the Æternity Crypto Foundation

*Created by: hanssv* This PR is supported by the Æternity Crypto Foundation
ghallak (Migrated from gitlab.com) approved these changes 2022-11-12 00:17:34 +09:00
ghallak commented 2022-11-12 19:51:31 +09:00 (Migrated from gitlab.com)
Copy Link

approved this merge request

approved this merge request
zxq9 commented 2022-11-14 06:11:16 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

I don't like mixing incompatible functionalities in the same namespace. Let's create AENS2 namespace and pack all the new stuff in there.

*Created by: radrow* I don't like mixing incompatible functionalities in the same namespace. Let's create `AENS2` namespace and pack all the new stuff in there.
zxq9 commented 2022-11-14 06:14:37 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Btw, shouldn't there be changes in aeso_fcode_to_fate?

*Created by: radrow* Btw, shouldn't there be changes in `aeso_fcode_to_fate`?
zxq9 commented 2022-11-14 16:15:30 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

I really like the idea of a whole new top-level namespace, I'll test it and see how it turns out.

@radrow there are no changes at the byte code instruction level (yet!) so no changes necessary in aeso_fcode_to_fate

*Created by: hanssv* I really like the idea of a whole new top-level namespace, I'll test it and see how it turns out. @radrow there are no changes at the byte code instruction level (yet!) so no changes necessary in `aeso_fcode_to_fate`
zxq9 commented 2022-11-16 05:21:51 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Moved all the active stuff + the new data pointer to AENSv2 - this turned out nicely I think - good call @radrow !

*Created by: hanssv* Moved all the active stuff + the new data pointer to `AENSv2` - this turned out nicely I think - good call @radrow !
zxq9 commented 2022-11-16 06:35:15 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Review: Approved

Looks way better

*Created by: radrow* **Review:** Approved Looks way better
zxq9 commented 2022-11-17 05:31:44 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: hanssv at 2022-11-16 20:31:44 UTC

*Merged by: hanssv at 2022-11-16 20:31:44 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
ghallak
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#917
No description provided.
Delete Branch "add_aens_data_pointer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?