QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Polymorphism fixes #906

Merged
ghallak merged 5 commits from ghallak/fix-polymorphism into master 2022-10-04 18:40:50 +09:00
Conversation 9 Commits 5 Files Changed 5 +105 -56
ghallak commented 2022-09-08 00:55:07 +09:00 (Migrated from gitlab.com)
Copy Link

Fixes: #413

This introduces a couple of fixes for the referenced issue.

The commits should be merged without squashing.

Fixes: #413 This introduces a couple of fixes for the referenced issue. The commits should be merged without squashing.
zxq9 commented 2022-09-09 00:30:15 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

If that throws, is the newly created ets table cleared?

*Created by: radrow* If that throws, is the newly created ets table cleared?
zxq9 commented 2022-09-09 00:34:00 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

I don't like this name. It is not clear from where you delete (the universe?). At first I thought you delete it from the contract. Why not something like "register implementation"?

*Created by: radrow* I don't like this name. It is not clear from where you delete (the universe?). At first I thought you delete it from the contract. Why not something like "register implementation"?
zxq9 commented 2022-09-09 00:34:49 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Also, why do you match type sig as well?

*Created by: radrow* Also, why do you match type sig as well?
ghallak commented 2022-09-29 19:24:08 +09:00 (Migrated from gitlab.com)
Copy Link

It is cleared inside clean_up_ets. In which case would we need to clean the functions_to_implement table explicitly?

It is cleared inside `clean_up_ets`. In which case would we need to clean the `functions_to_implement` table explicitly?
ghallak commented 2022-10-03 20:15:18 +09:00 (Migrated from gitlab.com)
Copy Link

Changed here 2a55823633

Changed here 2a55823633625f40d7143d48157e0844a976769c
ghallak commented 2022-10-03 20:15:28 +09:00 (Migrated from gitlab.com)
Copy Link

Changed here 06879fdf73

Changed here 06879fdf7384fff7c038196a2f5799aefdfcd98a
zxq9 commented 2022-10-03 21:37:04 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Review: Approved

*Created by: radrow* **Review:** Approved
zxq9 commented 2022-10-04 18:40:11 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2022-10-04 18:40:50 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: ghallak at 2022-10-04 09:40:50 UTC

*Merged by: ghallak at 2022-10-04 09:40:50 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#906
No description provided.
Delete Branch "ghallak/fix-polymorphism"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?