QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Add CONTRIBUTING.md #897

Merged
ghallak merged 13 commits from ghallak/contributing into master 2022-08-05 00:35:48 +09:00
Conversation 14 Commits 13 Files Changed 4 +43 -2
ghallak commented 2022-08-03 20:53:32 +09:00 (Migrated from gitlab.com)
Copy Link
No description provided.
zxq9 commented 2022-08-03 23:54:35 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

If a PR

*Created by: radrow* If **a** PR
zxq9 commented 2022-08-03 23:55:29 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Mention fold and prettyprint that have to be updated too

*Created by: radrow* Mention fold and prettyprint that have to be updated too
ghallak commented 2022-08-04 00:32:37 +09:00 (Migrated from gitlab.com)
Copy Link

@radrow I just noticed that this was missing, do you think it's correct?

@radrow I just noticed that this was missing, do you think it's correct?
zxq9 commented 2022-08-04 00:36:27 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Check if it behaves nice with other ops, such as

2+2 |> somefun

2::[] ++ [] |> somefun

*Created by: radrow* Check if it behaves nice with other ops, such as 2+2 |> somefun 2::[] ++ [] |> somefun
ghallak commented 2022-08-04 00:37:32 +09:00 (Migrated from gitlab.com)
Copy Link

Do you know what the 3 numbers returned by the function mean?

Do you know what the 3 numbers returned by the function mean?
zxq9 commented 2022-08-04 01:27:27 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Check usage, but I would guess operator priority over pre-, in-, and suffix operators

*Created by: radrow* Check usage, but I would guess operator priority over pre-, in-, and suffix operators
ghallak commented 2022-08-04 01:34:23 +09:00 (Migrated from gitlab.com)
Copy Link

It looks like when using infixl, the first and second numbers are the same, and the third number is the next precedence. This looks correct.

It looks like when using `infixl`, the first and second numbers are the same, and the third number is the next precedence. This looks correct.
zxq9 commented 2022-08-04 02:50:10 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

I think it should be aesophia...

*Created by: hanssv* I think it should be aesophia...
zxq9 commented 2022-08-04 02:50:49 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Dismissed

👍

*Created by: hanssv* **Review:** Dismissed 👍
zxq9 commented 2022-08-04 05:25:27 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Just "Sophia" would be the safest

*Created by: radrow* Just "Sophia" would be the safest
ghallak commented 2022-08-04 06:35:38 +09:00 (Migrated from gitlab.com)
Copy Link

Done here 321edb0e7b

Done here 321edb0e7bdb70f8b3611245a519131aea9b70c9
zxq9 commented 2022-08-04 22:04:15 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Review: Approved

*Created by: radrow* **Review:** Approved
zxq9 commented 2022-08-05 00:34:50 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2022-08-05 00:35:48 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: ghallak at 2022-08-04 15:35:48 UTC

*Merged by: ghallak at 2022-08-04 15:35:48 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#897
No description provided.
Delete Branch "ghallak/contributing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?