QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Prepare for new repl #892

Merged
zxq9 merged 3 commits from repl-prep into master 2022-07-26 01:46:54 +09:00
Conversation 7 Commits 3 Files Changed 2 +16 -5
zxq9 commented 2022-07-25 03:11:16 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

I had to expose some more functions and fix some typing issues

*Created by: radrow* I had to expose some more functions and fix some typing issues
ghallak (Migrated from gitlab.com) approved these changes 2022-07-25 03:11:16 +09:00
ghallak commented 2022-07-25 04:13:46 +09:00 (Migrated from gitlab.com)
Copy Link

@radrow What do you need this function for?

@radrow What do you need this function for?
zxq9 commented 2022-07-25 05:37:55 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

This sets the env to work in a given scope (eg a namespace). push_scope wouldn't work, because it always starts with a clean scope.

REPL uses it for resolution of user-defined types. They have to be declared in ?MOCK_CONTRACT, and so while unfolding their definitions the typechecker has to be in the context of that contract (otherwise it complains that the type is unknown)

*Created by: radrow* This sets the env to work in a given scope (eg a namespace). `push_scope` wouldn't work, because it always starts with a clean scope. REPL uses it for resolution of user-defined types. They have to be declared in `?MOCK_CONTRACT`, and so while unfolding their definitions the typechecker has to be in the context of that contract (otherwise it complains that the type is unknown)
zxq9 commented 2022-07-26 00:54:01 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Dismissed

👍

*Created by: hanssv* **Review:** Dismissed 👍
ghallak commented 2022-07-26 01:37:18 +09:00 (Migrated from gitlab.com)
Copy Link

approved this merge request

approved this merge request
zxq9 commented 2022-07-26 01:40:16 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2022-07-26 01:46:54 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: radrow at 2022-07-25 16:46:54 UTC

*Merged by: radrow at 2022-07-25 16:46:54 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
ghallak
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#892
No description provided.
Delete Branch "repl-prep"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?