QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Added support for EXIT op #888

Merged
zxq9 merged 4 commits from exit-op into master 2022-07-08 22:56:30 +09:00
Conversation 9 Commits 4 Files Changed 6 +18 -2
zxq9 commented 2022-06-29 04:01:08 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

*Created by: radrow*
ghallak (Migrated from gitlab.com) approved these changes 2022-06-29 04:01:08 +09:00
ghallak commented 2022-06-29 04:04:07 +09:00 (Migrated from gitlab.com)
Copy Link

I usually append new features to the end of the Added list in the change log.

I usually append new features to the end of the `Added` list in the change log.
ghallak commented 2022-06-29 04:06:34 +09:00 (Migrated from gitlab.com)
Copy Link

Can you add this to the docs in the section about exceptions?

Can you add this to the docs in the section about exceptions?
zxq9 commented 2022-06-29 04:07:50 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

- Added support for `EXIT` opcode via `exit : (string) => 'a` function (behaves same as `ABORT`, but consumes all gas).
*Created by: radrow* ```suggestion:-0+0 - Added support for `EXIT` opcode via `exit : (string) => 'a` function (behaves same as `ABORT`, but consumes all gas). ```
ghallak commented 2022-06-29 04:08:42 +09:00 (Migrated from gitlab.com)
Copy Link

approved this merge request

approved this merge request
zxq9 commented 2022-07-08 18:59:14 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

Not sure this is super productive, but LGTM.

*Created by: hanssv* **Review:** Approved Not sure this is super productive, but LGTM.
zxq9 commented 2022-07-08 19:09:46 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: marc0olo

@radrow any examples where this is useful? just wondering :)

*Created by: marc0olo* @radrow any examples where this is useful? just wondering :)
zxq9 commented 2022-07-08 22:56:30 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: radrow at 2022-07-08 13:56:30 UTC

*Merged by: radrow at 2022-07-08 13:56:30 UTC*
zxq9 commented 2022-07-08 22:57:02 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Not really, but since we have this in fate and there was epsilon cost to add it...

*Created by: radrow* Not really, but since we have this in fate and there was epsilon cost to add it...
Sign in to join this conversation.
Reviewers
No Reviewers
ghallak
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#888
No description provided.
Delete Branch "exit-op"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?