QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Handle all user generated code errors in the type checker #885

Merged
ghallak merged 15 commits from ghallak/270 into master 2022-07-26 00:48:47 +09:00
Conversation 5 Commits 15 Files Changed 39 +329 -278
ghallak commented 2022-06-25 05:25:22 +09:00 (Migrated from gitlab.com)
Copy Link

Fixes: #270

Fixes: #270
zxq9 commented 2022-07-24 00:36:01 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Why alias_t and not just tuple_t?

*Created by: radrow* Why alias_t and not just tuple_t?
ghallak commented 2022-07-25 05:14:30 +09:00 (Migrated from gitlab.com)
Copy Link

It's not possible to get this type with records and datatypes, so I added alias to make it clear that we're only matching type state = (). I have added a comment here df9f258394 to make that even clearer.

It's not possible to get this type with records and datatypes, so I added alias to make it clear that we're only matching `type state = ()`. I have added a comment here df9f258394823d74819df725a5c1ab6e6b5807eb to make that even clearer.
zxq9 commented 2022-07-25 05:46:18 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Review: Approved

*Created by: radrow* **Review:** Approved
zxq9 commented 2022-07-26 00:47:23 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

Great stuff!

*Created by: hanssv* **Review:** Approved Great stuff!
zxq9 commented 2022-07-26 00:48:47 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: ghallak at 2022-07-25 15:48:47 UTC

*Merged by: ghallak at 2022-07-25 15:48:47 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#885
No description provided.
Delete Branch "ghallak/270"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?