QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Solve constraints together and in the order they are added #851

Merged
ghallak merged 6 commits from ghallak/358 into master 2021-12-16 20:54:07 +09:00
Conversation 5 Commits 6 Files Changed 3 +200 -224
ghallak commented 2021-12-05 01:20:08 +09:00 (Migrated from gitlab.com)
Copy Link

Fixes: #358

This solution works by trying to find the named argument constraint (if any) that is causing the dereferencing of the record type in the field constraint to fail, and solve that, then it will try to dereference the record type again. This way the constraints won't be solved out of order.

This implements the solution mentioned in this comment https://github.com/aeternity/aesophia/issues/358#issuecomment-986550847

Fixes: #358 ~~This solution works by trying to find the named argument constraint (if any) that is causing the dereferencing of the record type in the field constraint to fail, and solve that, then it will try to dereference the record type again. This way the constraints won't be solved out of order.~~ This implements the solution mentioned in this comment https://github.com/aeternity/aesophia/issues/358#issuecomment-986550847
zxq9 commented 2021-12-10 22:44:29 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Dismissed

Looks good!

*Created by: hanssv* **Review:** Dismissed Looks good!
zxq9 commented 2021-12-16 00:51:08 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Review: Dismissed

That's a great piece of work

*Created by: radrow* **Review:** Dismissed That's a great piece of work
zxq9 commented 2021-12-16 20:50:55 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2021-12-16 20:52:55 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Review: Approved

*Created by: radrow* **Review:** Approved
zxq9 commented 2021-12-16 20:54:07 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: ghallak at 2021-12-16 11:54:07 UTC

*Merged by: ghallak at 2021-12-16 11:54:07 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#851
No description provided.
Delete Branch "ghallak/358"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?