QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Add Bitwise.aes to stdlib #831

Merged
zxq9 merged 2 commits from add_bitwise_stdlib into master 2021-09-16 17:49:00 +09:00
Conversation 11 Commits 2 Files Changed 3 +223 -1
zxq9 commented 2021-09-11 02:32:48 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

This PR is supported by the Æternity Crypto Foundation

*Created by: hanssv* This PR is supported by the Æternity Crypto Foundation
ghallak (Migrated from gitlab.com) approved these changes 2021-09-11 02:32:48 +09:00
zxq9 commented 2021-09-11 16:43:45 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

I know it is a very erlangish thing to document errors like that, but maybe... nope?

/funfact: the {badfun, F} error is documented as "something is wrong with the fun F"

*Created by: radrow* I know it is a very erlangish thing to document errors like that, but maybe... nope? /funfact: the `{badfun, F} ` error is documented as "something is wrong with the fun F"
zxq9 commented 2021-09-11 16:43:56 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Please

*Created by: radrow* Please
zxq9 commented 2021-09-11 20:30:41 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

In a Solidity contract it would have been just "N" - I guess the string goes into the contract and you want to keep it small.

I've changed it to something more descriptive.

*Created by: hanssv* In a Solidity contract it would have been just `"N"` - I guess the string goes into the contract and you want to keep it small. I've changed it to something more descriptive.
ghallak commented 2021-09-11 21:46:26 +09:00 (Migrated from gitlab.com)
Copy Link

Typo

Bitwise operations on arbitrary precision integers.
Typo ```suggestion:-0+0 Bitwise operations on arbitrary precision integers. ```
ghallak commented 2021-09-11 21:52:27 +09:00 (Migrated from gitlab.com)
Copy Link

Since this is defined for 0.

  // Bitwise 'and' for non-negative integers
Since this is defined for `0`. ```suggestion:-0+0 // Bitwise 'and' for non-negative integers ```
ghallak commented 2021-09-11 21:57:59 +09:00 (Migrated from gitlab.com)
Copy Link
  // Bitwise 'or' for non-negative integers
```suggestion:-0+0 // Bitwise 'or' for non-negative integers ```
zxq9 commented 2021-09-12 23:22:59 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

I got it right in the documentation though 🤦

*Created by: hanssv* I got it right in the documentation though 🤦
zxq9 commented 2021-09-13 03:09:18 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Review: Approved

*Created by: radrow* **Review:** Approved
ghallak commented 2021-09-13 05:45:48 +09:00 (Migrated from gitlab.com)
Copy Link

approved this merge request

approved this merge request
zxq9 commented 2021-09-16 17:49:00 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: hanssv at 2021-09-16 08:49:00 UTC

*Merged by: hanssv at 2021-09-16 08:49:00 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
ghallak
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#831
No description provided.
Delete Branch "add_bitwise_stdlib"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?