QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Allow assigning patterns to variables #827

Merged
ghallak merged 10 commits from ghallak/231 into master 2021-09-11 23:18:30 +09:00
Conversation 8 Commits 10 Files Changed 11 +68 -4
ghallak commented 2021-08-13 18:41:45 +09:00 (Migrated from gitlab.com)
Copy Link

Fixes #231

Examples of the new syntax can be found in the file test/contracts/assign_patterns.aes.

Fixes #231 Examples of the new syntax can be found in the file `test/contracts/assign_patterns.aes`.
zxq9 commented 2021-08-19 23:15:49 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

An example snippet might be nice!?

*Created by: hanssv* An example snippet might be nice!?
zxq9 commented 2021-08-19 23:17:05 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Dismissed

Looks good to me, perhaps this could/should also be mentioned somewhere in the documentation?

*Created by: hanssv* **Review:** Dismissed Looks good to me, perhaps this could/should also be mentioned somewhere in the documentation?
ghallak commented 2021-08-20 21:59:27 +09:00 (Migrated from gitlab.com)
Copy Link

Updated docs and changelog in this commit 6c53144ccb14830846d63ed3bfe6f3df4eda0ad8

Updated docs and changelog in this commit 6c53144ccb14830846d63ed3bfe6f3df4eda0ad8
zxq9 commented 2021-09-03 21:26:11 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Some trivial conflict to sort out, but still looks good. Remember that our target audience to a large extent consists of people who are afraid of functional programming so the less scary or at least well documented we can do things the better 😅

*Created by: hanssv* Some trivial conflict to sort out, but still looks good. Remember that our target audience to a large extent consists of people who are afraid of functional programming so the less scary or at least well documented we can do things the better 😅
zxq9 commented 2021-09-07 17:57:29 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

@ghallak you forgot to add letpat in aeso_syntax_utils:fold

*Created by: radrow* @ghallak you forgot to add letpat in aeso_syntax_utils:fold
zxq9 commented 2021-09-08 18:35:30 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Review: Approved

*Created by: radrow* **Review:** Approved
zxq9 commented 2021-09-11 22:38:21 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2021-09-11 23:18:30 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: radrow at 2021-09-11 14:18:30 UTC

*Merged by: radrow at 2021-09-11 14:18:30 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#827
No description provided.
Delete Branch "ghallak/231"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?