QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Implement Set stdlib #826

Merged
ghallak merged 7 commits from github/fork/ghallak/ghallak/set-stdlib into master 2021-08-07 17:08:46 +09:00
Conversation 19 Commits 7 Files Changed 3 +175
ghallak commented 2021-08-02 20:18:23 +09:00 (Migrated from gitlab.com)
Copy Link

Fixes #330

Fixes #330
zxq9 commented 2021-08-02 20:24:02 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Review: Changes requested

Looks fine, but please add docs in docs/sophia_stdlib.md (in the same manner it is done in all other modules). All public functions should be documented, even the obvious ones.

*Created by: radrow* **Review:** Changes requested Looks fine, but please add docs in `docs/sophia_stdlib.md` (in the same manner it is done in all other modules). All public functions should be documented, even the obvious ones.
ghallak commented 2021-08-02 22:06:12 +09:00 (Migrated from gitlab.com)
Copy Link

@radrow Docs where added to docs/sophia_stdlib.md here 416999e19a.

@radrow Docs where added to `docs/sophia_stdlib.md` here 416999e19a541d421e2bc26c20ee6f44cc55eee6.
zxq9 commented 2021-08-02 22:14:31 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Checks if an element is present in the set

I think it works like that. Tbh, not sure – articles aren't part of my mother-tongue (sadly)

*Created by: radrow* ```suggestion:-0+0 Checks if an element is present in the set ``` I think it works like that. Tbh, not sure – articles aren't part of my mother-tongue (sadly)
ghallak commented 2021-08-02 22:29:07 +09:00 (Migrated from gitlab.com)
Copy Link

Made some changes here 588684ba16

Made some changes here 588684ba16cb8e6bc33b30f7fcd54f184ff02285
zxq9 commented 2021-08-02 22:44:56 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Review: Approved

*Created by: radrow* **Review:** Approved
zxq9 commented 2021-08-02 22:47:11 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

    List.foldr(f, acc, to_list(s))
*Created by: radrow* ```suggestion:-0+0 List.foldr(f, acc, to_list(s)) ```
ghallak commented 2021-08-02 23:01:53 +09:00 (Migrated from gitlab.com)
Copy Link

Fixed here ed1c74cdcf

Fixed here ed1c74cdcffb4dbe0bf532a286648043289a728f
zxq9 commented 2021-08-04 19:20:00 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: dincho

This actually points to Bits set

*Created by: dincho* This actually points to Bits `set`
zxq9 commented 2021-08-04 19:22:56 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: dincho

Don't you guys test the stdlib ?! 🤔

*Created by: dincho* Don't you guys test the stdlib ?! 🤔
zxq9 commented 2021-08-04 19:32:51 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Uh, it was always a mystery for me how do the labels in md work

*Created by: radrow* Uh, it was always a mystery for me how do the labels in md work
zxq9 commented 2021-08-04 19:39:58 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

I hope there are tests, but you need FATE (or another VM :-) ) to run it, so those tests has to go in aeternity repo...

*Created by: hanssv* I hope there are tests, but you need FATE (or another VM :-) ) to run it, so those tests has to go in `aeternity` repo...
zxq9 commented 2021-08-04 19:44:12 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

There are compilation tests, but no documentation tests (hello, machine learning team? are you around?). Afaik the runtime has been tested in REPL or aestudio – aesophia doesn't offer any evaluation experience

*Created by: radrow* There are compilation tests, but no documentation tests (hello, machine learning team? are you around?). Afaik the runtime has been tested in REPL or aestudio – aesophia doesn't offer any evaluation experience
ghallak commented 2021-08-04 19:55:39 +09:00 (Migrated from gitlab.com)
Copy Link

I have written some tests in a dummy contract and made sure that they passed on aestudio. I will add the tests to aeternity repo and open a PR and link to it here.

I have written some tests in a dummy contract and made sure that they passed on aestudio. I will add the tests to aeternity repo and open a PR and link to it here.
ghallak commented 2021-08-04 19:59:02 +09:00 (Migrated from gitlab.com)
Copy Link

This linking issue should be fixed in this commit 028b12ddc6

This linking issue should be fixed in this commit 028b12ddc6c6a478207744057b6817b4abdfe0b2
zxq9 commented 2021-08-04 20:31:55 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Review: Dismissed

Nice trick with the ref

*Created by: radrow* **Review:** Dismissed Nice trick with the ref
zxq9 commented 2021-08-06 18:46:12 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Dismissed

Looks good 👍

*Created by: hanssv* **Review:** Dismissed Looks good 👍
zxq9 commented 2021-08-07 04:01:04 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Review: Approved

@hanssv I had to resolve a conflict, reclick pls

*Created by: radrow* **Review:** Approved @hanssv I had to resolve a conflict, reclick pls
zxq9 commented 2021-08-07 05:54:31 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2021-08-07 17:08:46 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: radrow at 2021-08-07 08:08:46 UTC

*Merged by: radrow at 2021-08-07 08:08:46 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#826
No description provided.
Delete Branch "github/fork/ghallak/ghallak/set-stdlib"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?