QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Added contains functions in List and Option. Fixed one type error #769

Merged
zxq9 merged 3 commits from contains-fun into lima 2020-08-27 18:25:39 +09:00
Conversation 6 Commits 3 Files Changed 4 +28 -5
zxq9 commented 2020-08-26 18:57:07 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

*Created by: radrow*
zxq9 commented 2020-08-26 19:04:36 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Why not contains(e, o) = o == Some(e)?

*Created by: UlfNorell* Why not `contains(e, o) = o == Some(e)`?
zxq9 commented 2020-08-26 19:11:22 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Tests are failing? contains looks good.

*Created by: hanssv* Tests are failing? `contains` looks good.
zxq9 commented 2020-08-26 22:56:58 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Recloned repo and it turned out that that change was unnecessary. No idea

*Created by: radrow* Recloned repo and it turned out that that change was unnecessary. No idea
zxq9 commented 2020-08-26 22:58:17 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2020-08-27 18:24:53 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Review: Approved

*Created by: UlfNorell* **Review:** Approved
zxq9 commented 2020-08-27 18:25:39 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: hanssv at 2020-08-27 09:25:39 UTC

*Merged by: hanssv at 2020-08-27 09:25:39 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#769
No description provided.
Delete Branch "contains-fun"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?