QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Fix error messages for some illegal constructions, fix absolute path includes #742

Merged
zxq9 merged 8 commits from github/fork/radrow/error-msgs into lima 2020-03-30 21:52:17 +09:00
Conversation 13 Commits 8 Files Changed 22 +224 -88
zxq9 commented 2020-03-24 00:52:55 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

fixes #246
fixes #244
fixes #243
fixes #242
fixes #252

*Created by: radrow* fixes #246 fixes #244 fixes #243 fixes #242 fixes #252
zxq9 commented 2020-03-24 02:08:02 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Also fixed attributes pretty printing

*Created by: radrow* Also fixed attributes pretty printing
zxq9 commented 2020-03-24 02:23:08 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

There were quite a few new error messages - a test case for each would be nice :-)

*Created by: hanssv* There were quite a few new error messages - a test case for each would be nice :-)
zxq9 commented 2020-03-24 02:23:36 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Commented

Looks good, if possible add some test cases for the new error messages 🙏

*Created by: hanssv* **Review:** Commented Looks good, if possible add some test cases for the new error messages 🙏
zxq9 commented 2020-03-24 04:17:57 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Test cases are missing not only for the new messages. Imo this is a separate job to do.

*Created by: radrow* Test cases are missing not only for the new messages. Imo this is a separate job to do.
zxq9 commented 2020-03-25 22:22:25 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Two wrongs doesn't equal one right, or whatever the saying is :-)

*Created by: hanssv* Two wrongs doesn't equal one right, or whatever the saying is :-)
zxq9 commented 2020-03-25 23:15:36 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

If you say so. I will extend the scope of the PR and add tests for all the error messages

*Created by: radrow* If you say so. I will extend the scope of the PR and add tests for all the error messages
zxq9 commented 2020-03-27 04:10:21 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Done

*Created by: radrow* Done
zxq9 commented 2020-03-27 04:58:28 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Fixed type printing in to_sophia_value in fate errors

*Created by: radrow* Fixed type printing in `to_sophia_value` in fate errors
zxq9 commented 2020-03-27 10:11:43 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Todo: fix sophia grammar in docs

*Created by: radrow* Todo: fix sophia grammar in docs
zxq9 commented 2020-03-28 00:42:24 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Okay, now it is ready (I hope)

*Created by: radrow* Okay, now it is ready (I hope)
zxq9 commented 2020-03-29 23:40:04 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2020-03-30 15:52:41 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Review: Approved

*Created by: UlfNorell* **Review:** Approved
zxq9 commented 2020-03-30 21:52:17 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: radrow at 2020-03-30 12:52:17 UTC

*Merged by: radrow at 2020-03-30 12:52:17 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#742
No description provided.
Delete Branch "github/fork/radrow/error-msgs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?