QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Restrict relation operators to ints #710

Closed
zxq9 wants to merge 1 commits from github/fork/radrow/rel-ops into lima
pull from: github/fork/radrow/rel-ops
merge into: QPQ-AG:lima
Conversation 2 Commits 1 Files Changed 1 +7 -3
zxq9 commented 2020-02-08 06:57:26 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

I see no reason to compare strings and functions using < operator, especially when it does nothing but return false.

I am working now with a custom datatype that represents some numbers and I accidentally used these operators several times which leaded to irritating bugs.

*Created by: radrow* I see no reason to compare strings and functions using `<` operator, especially when it does nothing but return `false`. I am working now with a custom datatype that represents some numbers and I accidentally used these operators several times which leaded to irritating bugs.
zxq9 commented 2020-02-08 08:38:50 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Tests need to be updated if we agree for it

*Created by: radrow* Tests need to be updated if we agree for it
zxq9 commented 2020-02-08 16:52:01 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

They don't always return false. Comparison is lexicographic on the underlying FATE representation.

*Created by: UlfNorell* They don't always return false. Comparison is lexicographic on the underlying FATE representation.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
WIP
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#710
No description provided.
Delete Branch "github/fork/radrow/rel-ops"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?