Prepared for REPL usage #709

2020-02-08T06:01:49+09:00

zxq9 commented

2020-02-08 06:01:49 +09:00

(Migrated from gitlab.com)

Created by: radrow

I have created and exposed some utility functions. I need to be able to pin into certain parts of the compiler for the purpose of my REPL.

Beside that I enchanted the way of running the parser – there is now a function run_parser/{2,3} which takes a parser /0, a string and optionally option list. Also, I added a keep_included option for the parser to report which files were included along with their hashes. This is useful when you want to keep track of which files are in context (I am using it in REPL to display warnings about duplicated includes for example)

*Created by: radrow* I have created and exposed some utility functions. I need to be able to pin into certain parts of the compiler for the purpose of my REPL. Beside that I enchanted the way of running the parser – there is now a function `run_parser/{2,3}` which takes a parser `/0`, a string and optionally option list. Also, I added a `keep_included` option for the parser to report which files were included along with their hashes. This is useful when you want to keep track of which files are in context (I am using it in REPL to display warnings about duplicated includes for example)

zxq9 commented

2020-02-11 17:17:28 +09:00

(Migrated from gitlab.com)

Created by: hanssv

Opts have type aeso_compiler:options() and that does not include keep_included!?

*Created by: hanssv* `Opts` have type `aeso_compiler:options()` and that does not include `keep_included`!?

zxq9 commented

2020-02-11 17:20:37 +09:00

(Migrated from gitlab.com)

Created by: hanssv

Review: Commented

Looks good to me!

*Created by: hanssv* **Review:** Commented Looks good to me!

zxq9 commented

2020-02-13 19:00:57 +09:00

(Migrated from gitlab.com)

Created by: radrow

Good catch, will add

*Created by: radrow* Good catch, will add

zxq9 commented

2020-02-13 19:01:53 +09:00

(Migrated from gitlab.com)

Created by: radrow

After I faced problems with pattern definitions I need to rework it a bit. Let's postpone it until I remove WIP label

*Created by: radrow* After I faced problems with pattern definitions I need to rework it a bit. Let's postpone it until I remove WIP label

zxq9 commented

2020-03-17 18:15:22 +09:00

(Migrated from gitlab.com)

Created by: hanssv

		  | keep_included

*Created by: hanssv* ```suggestion:-0+0 | keep_included ```

zxq9 commented

2020-03-23 20:50:26 +09:00

(Migrated from gitlab.com)

Created by: tolbrino

Review: Approved

LGTM, but I don't have in-depth experience with the code-base, so better @hanssv and @UlfNorell take a look too.

*Created by: tolbrino* **Review:** Approved LGTM, but I don't have in-depth experience with the code-base, so better @hanssv and @UlfNorell take a look too.

zxq9 commented

2020-04-02 18:24:22 +09:00

(Migrated from gitlab.com)

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved

zxq9 commented

2020-04-02 19:29:15 +09:00

(Migrated from gitlab.com)

Merged by: radrow at 2020-04-02 10:29:15 UTC

*Merged by: radrow at 2020-04-02 10:29:15 UTC*

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#709