QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Optimize stdlib #706

Merged
zxq9 merged 1 commits from github/fork/radrow/stdlib-optim into master 2020-02-08 03:51:13 +09:00
Conversation 4 Commits 1 Files Changed 2 +91 -84
zxq9 commented 2020-02-07 23:43:20 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Tail recursion is not always as rewarding as in xkcd commics. Changed functions have about 2 times less gas usage

*Created by: radrow* Tail recursion is not always as rewarding as in xkcd commics. Changed functions have about 2 times less gas usage
zxq9 commented 2020-02-08 00:47:06 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: thepiwo

Review: Approved

looks good to me, haven't tested all of the changed functions

*Created by: thepiwo* **Review:** Approved looks good to me, haven't tested all of the changed functions
zxq9 commented 2020-02-08 00:54:24 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

I did run the stdlib test from aeternity and it passes.

*Created by: radrow* I did run the stdlib test from `aeternity` and it passes.
zxq9 commented 2020-02-08 01:05:11 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Review: Approved

*Created by: UlfNorell* **Review:** Approved
zxq9 commented 2020-02-08 03:51:13 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: radrow at 2020-02-07 18:51:13 UTC

*Merged by: radrow at 2020-02-07 18:51:13 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#706
No description provided.
Delete Branch "github/fork/radrow/stdlib-optim"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?