QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

changed type of client ttl to int option #669

Merged
zxq9 merged 1 commits from PT-158904718-aens-update-sophia into master 2019-11-19 02:39:55 +09:00
Conversation 4 Commits 1 Files Changed 4 +5 -5
zxq9 commented 2019-11-19 00:26:29 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: skkw

*Created by: skkw*
zxq9 commented 2019-11-19 00:30:42 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: velzevur

Review: Approved

*Created by: velzevur* **Review:** Approved
zxq9 commented 2019-11-19 01:16:33 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

I see there are no test case changes, maybe we should have a test that covers compiling this new function ;-)

*Created by: hanssv* **Review:** Approved I see there are no test case changes, maybe we should have a test that covers compiling this new function ;-)
zxq9 commented 2019-11-19 02:39:55 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: skkw at 2019-11-18 17:39:55 UTC

*Merged by: skkw at 2019-11-18 17:39:55 UTC*
zxq9 commented 2019-11-19 02:43:46 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: skkw

I see there are no test case changes, maybe we should have a test that covers compiling this new function ;-)

That's correct. I'll make a PR for this.

*Created by: skkw* > I see there are no test case changes, maybe we should have a test that covers compiling this new function ;-) That's correct. I'll make a PR for this.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#669
No description provided.
Delete Branch "PT-158904718-aens-update-sophia"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?