QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Fail on defined functions in contract prototypes #654

Merged
zxq9 merged 2 commits from fail-on-multiple-contracts into master 2019-10-01 21:28:06 +09:00
Conversation 3 Commits 2 Files Changed 4 +69 -22
zxq9 commented 2019-10-01 20:52:12 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Previously the AEVM backend silently accepted defined functions in contract prototypes, but did the wrong thing, and the FATE backend crashed in code generation.

We could in principle allow defined functions in contract prototypes, but disallowing them makes it clear that no code is generated for the prototypes.

Also gives a type error if you try to call a function in another contract as if the contract were a namespace (i.e. RemoteContract.some_fun(...)). Previously this crashed during code generation.

*Created by: UlfNorell* Previously the AEVM backend silently accepted defined functions in contract prototypes, but did the wrong thing, and the FATE backend crashed in code generation. We could in principle allow defined functions in contract prototypes, but disallowing them makes it clear that no code is generated for the prototypes. Also gives a type error if you try to call a function in another contract as if the contract were a namespace (i.e. `RemoteContract.some_fun(...)`). Previously this crashed during code generation.
zxq9 commented 2019-10-01 21:26:50 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

Review: Approved

*Created by: happi* **Review:** Approved
zxq9 commented 2019-10-01 21:28:01 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2019-10-01 21:28:06 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: UlfNorell at 2019-10-01 12:28:06 UTC

*Merged by: UlfNorell at 2019-10-01 12:28:06 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#654
No description provided.
Delete Branch "fail-on-multiple-contracts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?