QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Don't confuse variables and store registers in fate asm generation #649

Merged
zxq9 merged 2 commits from fix-code-generation-bug into master 2019-09-24 21:55:09 +09:00
Conversation 5 Commits 2 Files Changed 1 +19 -11
zxq9 commented 2019-09-23 23:58:43 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

*Created by: UlfNorell*
zxq9 commented 2019-09-24 18:20:14 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2019-09-24 20:54:31 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

Review: Approved

*Created by: happi* **Review:** Approved
zxq9 commented 2019-09-24 20:55:56 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

We could introduce the naming {store, N} in FATE code and just use the negative var encoding in serialization of instructions (To save on arg specifier bits).

*Created by: happi* We could introduce the naming {store, N} in FATE code and just use the negative var encoding in serialization of instructions (To save on arg specifier bits).
zxq9 commented 2019-09-24 21:55:04 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

That's not a bad idea, and wouldn't even be consensus breaking I guess.

*Created by: UlfNorell* That's not a bad idea, and wouldn't even be consensus breaking I guess.
zxq9 commented 2019-09-24 21:55:09 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: UlfNorell at 2019-09-24 12:55:09 UTC

*Merged by: UlfNorell at 2019-09-24 12:55:09 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#649
No description provided.
Delete Branch "fix-code-generation-bug"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?