QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Fix numeric escapes in strings #642

Merged
zxq9 merged 2 commits from fix_numeric_escapes into master 2019-09-13 15:04:07 +09:00
Conversation 4 Commits 2 Files Changed 3 +6 -1
zxq9 commented 2019-09-13 04:18:17 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Allow for example "\x19Ethereum Signed Message:\n" :-)

*Created by: hanssv* Allow for example `"\x19Ethereum Signed Message:\n"` :-)
zxq9 commented 2019-09-13 04:46:36 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Review: Approved

Could consider nicer error message for bad escape codes ("\xxx" will crash with a badarg I believe).

*Created by: UlfNorell* **Review:** Approved Could consider nicer error message for bad escape codes ("\xxx" will crash with a badarg I believe).
zxq9 commented 2019-09-13 05:28:56 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Absolutely - I was short on time...

*Created by: hanssv* Absolutely - I was short on time...
zxq9 commented 2019-09-13 14:52:29 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

Review: Approved

*Created by: happi* **Review:** Approved
zxq9 commented 2019-09-13 15:04:07 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: hanssv at 2019-09-13 06:04:07 UTC

*Merged by: hanssv at 2019-09-13 06:04:07 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#642
No description provided.
Delete Branch "fix_numeric_escapes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?