QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Updated some functions, renamed some stuff, added from_to IN STDLIB #627

Merged
zxq9 merged 5 commits from github/fork/radrow/stdlib-extensions into master 2019-09-02 16:56:57 +09:00
Conversation 10 Commits 5 Files Changed 2 +30 -18
zxq9 commented 2019-08-29 20:41:35 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

*Created by: radrow*
zxq9 commented 2019-08-30 20:12:35 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

What's the motivation for this change? The semantics hasn't changed and the function is slower for legitimate use cases.

*Created by: UlfNorell* What's the motivation for this change? The semantics hasn't changed and the function is slower for legitimate use cases.
zxq9 commented 2019-08-30 20:13:57 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Same here. It doesn't seem worth the extra check just to get a special error for negative indices.

*Created by: UlfNorell* Same here. It doesn't seem worth the extra check just to get a special error for negative indices.
zxq9 commented 2019-08-30 20:14:59 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

  function from_to(a : int, b : int) : list(int) = [a..b]
*Created by: UlfNorell* ```suggestion:-0+0 function from_to(a : int, b : int) : list(int) = [a..b] ```
zxq9 commented 2019-08-30 20:47:32 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Rollbacked

*Created by: radrow* Rollbacked
zxq9 commented 2019-08-30 20:48:05 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Moved if to the abort. It will keep meaningful error message and not affect performance

*Created by: radrow* Moved `if` to the `abort`. It will keep meaningful error message and not affect performance
zxq9 commented 2019-08-30 20:56:05 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

This is no longer used.

*Created by: UlfNorell* This is no longer used.
zxq9 commented 2019-08-30 21:07:08 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Fixd

*Created by: radrow* Fixd
zxq9 commented 2019-08-30 21:28:44 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Review: Approved

*Created by: UlfNorell* **Review:** Approved
zxq9 commented 2019-09-02 16:56:48 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2019-09-02 16:56:57 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: UlfNorell at 2019-09-02 07:56:57 UTC

*Merged by: UlfNorell at 2019-09-02 07:56:57 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#627
No description provided.
Delete Branch "github/fork/radrow/stdlib-extensions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?