QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

PT-162578406 Add payable modifier #616

Merged
zxq9 merged 5 commits from PT-162578406-payable_modifier into master 2019-08-19 23:27:19 +09:00
Conversation 8 Commits 5 Files Changed 16 +94 -45
zxq9 commented 2019-08-16 16:38:27 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Needs https://github.com/aeternity/aebytecode/pull/69

*Created by: hanssv* Needs https://github.com/aeternity/aebytecode/pull/69
uwiger commented 2019-08-18 05:11:03 +09:00 (Migrated from gitlab.com)
Copy Link

Still need the WIP label?

Still need the WIP label?
uwiger commented 2019-08-18 05:24:09 +09:00 (Migrated from gitlab.com)
Copy Link

Name is a boolean?

`Name` is a boolean?
uwiger commented 2019-08-18 05:26:58 +09:00 (Migrated from gitlab.com)
Copy Link

So here, Payable is definitely a boolean, but in aeso_icode:set_payable/2, the first argument is called Name (though typed as a boolean), which at least looking at this context, seems confusing.

So here, `Payable` is definitely a boolean, but in `aeso_icode:set_payable/2`, the first argument is called `Name` (though typed as a boolean), which at least looking at this context, seems confusing.
zxq9 commented 2019-08-19 15:58:19 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Copy pasted, should be Payable of course.

*Created by: hanssv* Copy pasted, should be `Payable` of course.
zxq9 commented 2019-08-19 15:58:37 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Now updated with the correct aebytecode commit

*Created by: hanssv* Now updated with the correct `aebytecode` commit
zxq9 commented 2019-08-19 16:03:13 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Review: Approved

*Created by: UlfNorell* **Review:** Approved
zxq9 commented 2019-08-19 23:07:46 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: ThomasArts

Review: Approved

*Created by: ThomasArts* **Review:** Approved
zxq9 commented 2019-08-19 23:27:19 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: hanssv at 2019-08-19 14:27:19 UTC

*Merged by: hanssv at 2019-08-19 14:27:19 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#616
No description provided.
Delete Branch "PT-162578406-payable_modifier"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?