QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

[PT-167805291] Add opcode for ecrecover #613

Merged
zxq9 merged 6 commits from PT-167805291-opcode-ecrecover into master 2019-08-15 04:02:46 +09:00
Conversation 6 Commits 6 Files Changed 9 +51 -34
zxq9 commented 2019-08-13 23:48:16 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: tolbrino

Ref PT-16780529

Merge order:

  1. PR for aebytecode: https://github.com/aeternity/aebytecode/pull/64
  2. this PR
  3. PR for aeternity: https://github.com/aeternity/aeternity/pull/2638
*Created by: tolbrino* Ref [PT-16780529](https://www.pivotaltracker.com/story/show/167805291) Merge order: 1. PR for aebytecode: https://github.com/aeternity/aebytecode/pull/64 2. this PR 3. PR for aeternity: https://github.com/aeternity/aeternity/pull/2638
zxq9 commented 2019-08-14 15:50:32 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

                     [{"ecrecover_secp256k1", Fun([Hash, Bytes(65)], Hash)},
*Created by: hanssv* ```suggestion:-0+0 [{"ecrecover_secp256k1", Fun([Hash, Bytes(65)], Hash)}, ```
zxq9 commented 2019-08-14 15:50:55 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Changes requested

The commit-id in aebytecode is not in master there so it could easily disappear... This PR should go in after https://github.com/aeternity/aebytecode/pull/64 and the reference should be updated.

*Created by: hanssv* **Review:** Changes requested The commit-id in aebytecode is not in master there so it could easily disappear... This PR should go in after https://github.com/aeternity/aebytecode/pull/64 and the reference should be updated.
zxq9 commented 2019-08-14 18:00:20 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Review: Dismissed

Looks ok

*Created by: radrow* **Review:** Dismissed Looks ok
zxq9 commented 2019-08-15 02:35:49 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: ThomasArts

Review: Approved

*Created by: ThomasArts* **Review:** Approved
zxq9 commented 2019-08-15 02:38:02 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2019-08-15 04:02:46 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: hanssv at 2019-08-14 19:02:46 UTC

*Merged by: hanssv at 2019-08-14 19:02:46 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#613
No description provided.
Delete Branch "PT-167805291-opcode-ecrecover"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?