QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Fixed pretty printing and pattern split #602

Merged
zxq9 merged 2 commits from github/fork/radrow/pp-pat-split into master 2019-07-29 20:27:02 +09:00
Conversation 5 Commits 2 Files Changed 3 +59 -9
zxq9 commented 2019-07-28 06:12:45 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Pretty printing was broken in few places due to type errors – one may check it by executing pp_fexpr on bodies of functions right after processing. There were also some bugs in managing patterns (fpat was sometimes mistaken with fsplit_pat). I have added one test that used to crash previous version.

Beside that I undo #106 because the "fix" I provided there turned out to be treatment of symptoms. This PR should fix that issue in proper way now.

*Created by: radrow* Pretty printing was broken in few places due to type errors – one may check it by executing `pp_fexpr` on bodies of functions right after processing. There were also some bugs in managing patterns (`fpat` was sometimes mistaken with `fsplit_pat`). I have added one test that used to crash previous version. Beside that I undo #106 because the "fix" I provided there turned out to be treatment of symptoms. This PR should fix that issue in proper way now.
zxq9 commented 2019-07-28 17:14:13 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Review: Approved

*Created by: UlfNorell* **Review:** Approved
zxq9 commented 2019-07-29 16:46:18 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: lucafavatella

I see in the second element of {tuple, _} no need for var according to the type. Ok.

*Created by: lucafavatella* I see in the second element of `{tuple, _}` no need for `var` according to the type. Ok.
zxq9 commented 2019-07-29 16:47:20 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: lucafavatella

Review: Approved

*Created by: lucafavatella* **Review:** Approved
zxq9 commented 2019-07-29 17:59:33 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

It was confusing a bit because in fpat this var was mandatory but in fsplit_pat no

*Created by: radrow* It was confusing a bit because in `fpat` this `var` was mandatory but in `fsplit_pat` no
zxq9 commented 2019-07-29 20:27:02 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: dincho at 2019-07-29 11:27:02 UTC

*Merged by: dincho at 2019-07-29 11:27:02 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#602
No description provided.
Delete Branch "github/fork/radrow/pp-pat-split"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?