Revert bytes(N) from icode/vm-types #551

2019-04-24T00:49:46+09:00

zxq9 commented

2019-04-24 00:49:46 +09:00

(Migrated from gitlab.com)

Created by: hanssv

For backwards compatibility (mainly in primops) it isn't a great idea to introduce a new VM-type. Instead, encode bytes(N) as either word or {tuple, [word,...]}.

*Created by: hanssv* For backwards compatibility (mainly in primops) it isn't a great idea to introduce a new VM-type. Instead, encode `bytes(N)` as either `word` or `{tuple, [word,...]}`.

gorillainduction (Migrated from gitlab.com) approved these changes 2019-04-24 00:49:46 +09:00

zxq9 commented

2019-04-24 04:10:52 +09:00

(Migrated from gitlab.com)

Created by: UlfNorell

Can be simplified using bytes_t:

ast_typerep({bytes_t, _, Len}, _) -> bytes_t(Len);

*Created by: UlfNorell* Can be simplified using `bytes_t`: ```erlang ast_typerep({bytes_t, _, Len}, _) -> bytes_t(Len); ```

gorillainduction commented

2019-04-24 15:46:01 +09:00

(Migrated from gitlab.com)

approved this merge request

zxq9 commented

2019-04-24 15:58:34 +09:00

(Migrated from gitlab.com)

Created by: ThomasArts

Review: Approved

*Created by: ThomasArts* **Review:** Approved

zxq9 commented

2019-04-24 15:58:44 +09:00

(Migrated from gitlab.com)

Merged by: hanssv at 2019-04-24 06:58:44 UTC

*Merged by: hanssv at 2019-04-24 06:58:44 UTC*

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#551