QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Add Auth.tx_hash - namespace + primop #544

Merged
zxq9 merged 3 commits from generalized_accounts into master 2019-04-08 21:45:56 +09:00
Conversation 4 Commits 3 Files Changed 6 +41 -10
zxq9 commented 2019-04-08 19:12:53 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Adds a new "builtin" namespace Auth that (at the moment) has one member tx_hash. Auth.tx_hash returns a option(hash) where Some(hash) is returned in Generalized account's authentication context, and none otherwise.

Since we have no good mechanism for "hiding" new features - apart from keeping a feature branch - let's merge this. If nothing else it will stop people from using the soon to be reserved namespace Auth :-)

*Created by: hanssv* Adds a new "builtin" namespace `Auth` that (at the moment) has one member `tx_hash`. `Auth.tx_hash` returns a `option(hash)` where `Some(hash)` is returned in Generalized account's authentication context, and `none` otherwise. Since we have no good mechanism for "hiding" new features - apart from keeping a feature branch - let's merge this. If nothing else it will stop people from using the soon to be reserved namespace `Auth` :-)
gorillainduction (Migrated from gitlab.com) approved these changes 2019-04-08 19:12:53 +09:00
gorillainduction commented 2019-04-08 19:20:23 +09:00 (Migrated from gitlab.com)
Copy Link

approved this merge request

approved this merge request
zxq9 commented 2019-04-08 21:43:48 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: ThomasArts

Review: Approved

*Created by: ThomasArts* **Review:** Approved
zxq9 commented 2019-04-08 21:45:56 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: hanssv at 2019-04-08 12:45:56 UTC

*Merged by: hanssv at 2019-04-08 12:45:56 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
gorillainduction
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#544
No description provided.
Delete Branch "generalized_accounts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?