QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

PT-163022973 Make a new aci generator #543

Merged
rvirding merged 3 commits from new-aci-generator into master 2019-04-05 22:14:18 +09:00
Conversation 5 Commits 3 Files Changed 2 +222 -74
rvirding commented 2019-04-04 06:06:19 +09:00 (Migrated from gitlab.com)
Copy Link

Add the new ACI generator which also converts type to JSON.

PT-163022973

Add the new ACI generator which also converts type to JSON. [PT-163022973](https://www.pivotaltracker.com/story/show/163022973)
zxq9 commented 2019-04-04 16:14:37 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

I think jsx accepts atoms as strings, not just binaries... It makes the code easier to read?!

*Created by: hanssv* I think `jsx` accepts atoms as strings, not just binaries... It makes the code easier to read?!
zxq9 commented 2019-04-04 16:15:49 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

Does namespaces work?

Once this is merged it should be used in: https://github.com/aeternity/aesophia_http/pull/13 ?

*Created by: hanssv* **Review:** Approved Does namespaces work? Once this is merged it should be used in: https://github.com/aeternity/aesophia_http/pull/13 ?
rvirding commented 2019-04-04 16:53:51 +09:00 (Migrated from gitlab.com)
Copy Link

Yes, it will be used by aesophia_http ASAP so they can test it. I would just need to change rebar.config and rebar.lock.

Yes, it will be used by `aesophia_http` ASAP so they can test it. I would just need to change rebar.config and rebar.lock.
zxq9 commented 2019-04-05 21:52:15 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Review: Approved

*Created by: UlfNorell* **Review:** Approved
zxq9 commented 2019-04-05 22:14:18 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: rvirding at 2019-04-05 13:14:18 UTC

*Merged by: rvirding at 2019-04-05 13:14:18 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#543
No description provided.
Delete Branch "new-aci-generator"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?