QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Remove fragile file-based versioning #537

Merged
zxq9 merged 1 commits from vsn into master 2019-03-15 19:12:42 +09:00
Conversation 6 Commits 1 Files Changed 3 +1 -7
zxq9 commented 2019-03-15 18:57:45 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: lucafavatella

*Created by: lucafavatella*
gorillainduction (Migrated from gitlab.com) approved these changes 2019-03-15 18:57:45 +09:00
zxq9 commented 2019-03-15 18:58:03 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: lucafavatella

Why is the VERSION file required in this repo?

*Created by: lucafavatella* Why is the VERSION file required in this repo?
zxq9 commented 2019-03-15 19:02:52 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

The VERSION was needed in two places originally, but that has been fixed since so just removing it makes sense 👍

*Created by: hanssv* The VERSION was needed in two places originally, but that has been fixed since so just removing it makes sense 👍
zxq9 commented 2019-03-15 19:03:36 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

Ha, exactly what I warned about, someone removing both the pre-hook and the file 😛

*Created by: hanssv* **Review:** Approved Ha, exactly what I warned about, someone removing both the pre-hook and the file 😛
gorillainduction commented 2019-03-15 19:08:07 +09:00 (Migrated from gitlab.com)
Copy Link

approved this merge request

approved this merge request
zxq9 commented 2019-03-15 19:12:42 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: lucafavatella at 2019-03-15 10:12:42 UTC

*Merged by: lucafavatella at 2019-03-15 10:12:42 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
gorillainduction
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#537
No description provided.
Delete Branch "vsn"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?