QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Fix handling of init in create_calldata #523

Merged
zxq9 merged 2 commits from fix_create_calldata into master 2019-02-28 18:12:16 +09:00
Conversation 7 Commits 2 Files Changed 2 +53 -9
zxq9 commented 2019-02-28 17:18:05 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

*Created by: hanssv*
zxq9 commented 2019-02-28 17:21:44 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

Review: Approved

*Created by: happi* **Review:** Approved
zxq9 commented 2019-02-28 17:24:45 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Will this not cause strange errors when you have an init function, but some other error?

A nicer approach might be to parse the contract and look for the init function, and only insert a default init if you don't find it.

*Created by: UlfNorell* Will this not cause strange errors when you have an init function, but some other error? A nicer approach might be to parse the contract and look for the init function, and only insert a default init if you don't find it.
zxq9 commented 2019-02-28 17:28:20 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Review: Approved

*Created by: UlfNorell* **Review:** Approved
zxq9 commented 2019-02-28 17:32:52 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Yet another approach would be to return the first error when the second check_call also fail
🤔

*Created by: hanssv* Yet another approach would be to return the first error when the second `check_call` also fail :thinking:
zxq9 commented 2019-02-28 17:58:49 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

Review: Approved

*Created by: happi* **Review:** Approved
zxq9 commented 2019-02-28 18:04:19 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Review: Approved

*Created by: UlfNorell* **Review:** Approved
zxq9 commented 2019-02-28 18:12:16 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: hanssv at 2019-02-28 09:12:16 UTC

*Merged by: hanssv at 2019-02-28 09:12:16 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#523
No description provided.
Delete Branch "fix_create_calldata"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?