QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

New aci generator #522

Merged
rvirding merged 9 commits from new-aci-generator into master 2019-03-01 02:42:00 +09:00
Conversation 5 Commits 9 Files Changed 9 +469 -2
rvirding commented 2019-02-27 21:37:06 +09:00 (Migrated from gitlab.com)
Copy Link

Add an ACI generator to the compiler.

Add an ACI generator to the compiler.
zxq9 commented 2019-02-27 23:30:43 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

The parse errors looks out of date...

*Created by: hanssv* The parse errors looks out of date...
zxq9 commented 2019-03-01 01:45:23 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2019-03-01 02:08:24 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

This won't work if you are using types from other namespaces/contracts. For instance

contract OtherContract =
  datatype some_type = This | That
  function stuff : some_type => int

contract MyContract =
  function do_the_stuff(r : OtherContract, x : OtherContract.some_type) =
    r.stuff(x)

but I guess that's not really in scope for this PR.

*Created by: UlfNorell* This won't work if you are using types from other namespaces/contracts. For instance ``` contract OtherContract = datatype some_type = This | That function stuff : some_type => int contract MyContract = function do_the_stuff(r : OtherContract, x : OtherContract.some_type) = r.stuff(x) ``` but I guess that's not really in scope for this PR.
zxq9 commented 2019-03-01 02:08:32 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Review: Approved

*Created by: UlfNorell* **Review:** Approved
zxq9 commented 2019-03-01 02:42:00 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: rvirding at 2019-02-28 17:42:00 UTC

*Merged by: rvirding at 2019-02-28 17:42:00 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#522
No description provided.
Delete Branch "new-aci-generator"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?