QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Refactor String.concat to not shift 256 bits #506

Merged
zxq9 merged 1 commits from fix_string_concat into master 2019-01-25 18:36:10 +09:00
Conversation 5 Commits 1 Files Changed 1 +38 -35
zxq9 commented 2019-01-25 17:55:05 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Adding SafeMath to VM_AEVM_SOPHIA_2 will break String.concat otherwise.

*Created by: hanssv* Adding SafeMath to VM_AEVM_SOPHIA_2 will break String.concat otherwise.
gorillainduction (Migrated from gitlab.com) approved these changes 2019-01-25 17:55:05 +09:00
zxq9 commented 2019-01-25 18:08:12 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Review: Approved

*Created by: UlfNorell* **Review:** Approved
zxq9 commented 2019-01-25 18:30:52 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

Review: Approved

*Created by: happi* **Review:** Approved
gorillainduction commented 2019-01-25 18:33:35 +09:00 (Migrated from gitlab.com)
Copy Link

approved this merge request

approved this merge request
zxq9 commented 2019-01-25 18:36:10 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: hanssv at 2019-01-25 09:36:10 UTC

*Merged by: hanssv at 2019-01-25 09:36:10 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
gorillainduction
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#506
No description provided.
Delete Branch "fix_string_concat"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?