QPQ-AG/sophia
12
0
Fork 0
Code Issues 43 Pull Requests 7 Actions Packages Projects Releases 16 Wiki Activity

PT-163063316 Interface to sophia #500

Merged
rvirding merged 4 commits from interface-to-sophia into master 2019-01-26 00:20:39 +09:00
Conversation 8 Commits 4 Files Changed 5
+272 -134
rvirding commented 2019-01-15 00:09:29 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Clean up the interface to the sophia compiler.

PT-163063316

Clean up the interface to the sophia compiler. [PT-163063316](https://www.pivotaltracker.com/story/show/163063316)
zxq9 commented 2019-01-15 16:53:31 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Created by: hanssv

Review: Approved

I think it looks fine

*Created by: hanssv* **Review:** Approved I think it looks fine
zxq9 commented 2019-01-15 17:47:10 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Created by: hanssv

Review: Commented

Formatting is a bit off... Aeternity code seems to have a space after a ,

*Created by: hanssv* **Review:** Commented Formatting is a bit off... Aeternity code seems to have a space after a `,`
rvirding commented 2019-01-16 01:32:48 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

I know, but I don't like a space after , inside a data structure, only between arguments and in the body of a function 😉

I know, but I don't like a space after `,` inside a data structure, only between arguments and in the body of a function :wink:
zxq9 commented 2019-01-21 20:22:30 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Created by: UlfNorell

Why not just FileName = Name? The current code replaces any existing extension in the filename by .aes which is not the most intuitive behaviour.

*Created by: UlfNorell* Why not just `FileName = Name`? The current code replaces any existing extension in the filename by `.aes` which is not the most intuitive behaviour.
zxq9 commented 2019-01-21 20:23:23 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Created by: UlfNorell

Review: Approved

*Created by: UlfNorell* **Review:** Approved
rvirding commented 2019-01-26 00:09:02 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

I have just assumed that .aes is the default sophia file extension. An addition of this is done in the epoch tests. And I just feel it is reasonable to have a default extension.

I have just assumed that `.aes` is the default sophia file extension. An addition of this is done in the epoch tests. And I just feel it is reasonable to have a default extension.
zxq9 commented 2019-01-26 00:20:39 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Merged by: rvirding at 2019-01-25 15:20:39 UTC

*Merged by: rvirding at 2019-01-25 15:20:39 UTC*
zxq9 commented 2019-01-26 00:48:28 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Created by: UlfNorell

This isn't just having a default extension though. If I try to compile a file mycontract.sophia it tries to read mycontract.aes.

*Created by: UlfNorell* This isn't just having a default extension though. If I try to compile a file `mycontract.sophia` it tries to read `mycontract.aes`.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 pig lipstick
Muggle-facing enhancements
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Dagadunn Pickmick apex132 dimitar.p.ivanov flambard (Markus Flambard) gchewy hans_sv pharpend spivee (Jarvis Carroll) thescientress (Cecille de Jesus) uwiger (Ulf Wiger) zxq9 (Craig Everett)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#500