QPQ-AG/sophia
12
0
Fork 0
Code Issues 43 Pull Requests 7 Actions Packages Projects Releases 16 Wiki Activity

PT-163146624 Improve builtins #497

Merged
zxq9 merged 5 commits from improve_builtins into master 2019-01-14 18:58:13 +09:00
Conversation 4 Commits 5 Files Changed 1
+206 -233
zxq9 commented 2019-01-11 21:59:43 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Created by: hanssv

https://www.pivotaltracker.com/story/show/163146624

*Created by: hanssv* https://www.pivotaltracker.com/story/show/163146624
zxq9 commented 2019-01-11 22:45:09 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Created by: UlfNorell

Can avoid erlang:apply and having to export the builtin_ functions by moving the call to builtin_function:

bfun(B, {IArgs, IExpr, IRet}) ->
    {{builtin, B}, [private], IArgs, IExpr, IRet}.

builtin_function(BF) ->
    case BF of
        {event, EventT} -> bfun(BF, builtin_event(EventT));
        ...
*Created by: UlfNorell* Can avoid `erlang:apply` and having to export the `builtin_` functions by moving the call to `builtin_function`: ```erlang bfun(B, {IArgs, IExpr, IRet}) -> {{builtin, B}, [private], IArgs, IExpr, IRet}. builtin_function(BF) -> case BF of {event, EventT} -> bfun(BF, builtin_event(EventT)); ... ```
zxq9 commented 2019-01-12 22:31:57 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Created by: UlfNorell

Review: Approved

*Created by: UlfNorell* **Review:** Approved
zxq9 commented 2019-01-14 18:18:07 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Created by: happi

Review: Approved

*Created by: happi* **Review:** Approved
zxq9 commented 2019-01-14 18:58:13 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Merged by: hanssv at 2019-01-14 09:58:13 UTC

*Merged by: hanssv at 2019-01-14 09:58:13 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 pig lipstick
Muggle-facing enhancements
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Dagadunn Pickmick apex132 dimitar.p.ivanov flambard (Markus Flambard) gchewy hans_sv pharpend spivee (Jarvis Carroll) thescientress (Cecille de Jesus) uwiger (Ulf Wiger) zxq9 (Craig Everett)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#497