PT-163146624 Improve builtins #497

2019-01-11T21:59:43+09:00

zxq9 commented

2019-01-11 21:59:43 +09:00

(Migrated from gitlab.com)

Created by: hanssv

https://www.pivotaltracker.com/story/show/163146624

*Created by: hanssv* https://www.pivotaltracker.com/story/show/163146624

zxq9 commented

2019-01-11 22:45:09 +09:00

(Migrated from gitlab.com)

Created by: UlfNorell

Can avoid erlang:apply and having to export the builtin_ functions by moving the call to builtin_function:

bfun(B, {IArgs, IExpr, IRet}) ->
    {{builtin, B}, [private], IArgs, IExpr, IRet}.

builtin_function(BF) ->
    case BF of
        {event, EventT} -> bfun(BF, builtin_event(EventT));
        ...

*Created by: UlfNorell* Can avoid `erlang:apply` and having to export the `builtin_` functions by moving the call to `builtin_function`: ```erlang bfun(B, {IArgs, IExpr, IRet}) -> {{builtin, B}, [private], IArgs, IExpr, IRet}. builtin_function(BF) -> case BF of {event, EventT} -> bfun(BF, builtin_event(EventT)); ... ```

zxq9 commented

2019-01-12 22:31:57 +09:00

(Migrated from gitlab.com)

Created by: UlfNorell

Review: Approved

*Created by: UlfNorell* **Review:** Approved

zxq9 commented

2019-01-14 18:18:07 +09:00

(Migrated from gitlab.com)

Created by: happi

Review: Approved

*Created by: happi* **Review:** Approved

zxq9 commented

2019-01-14 18:58:13 +09:00

(Migrated from gitlab.com)

Merged by: hanssv at 2019-01-14 09:58:13 UTC

*Merged by: hanssv at 2019-01-14 09:58:13 UTC*

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#497