Merge branch 'master' into quickcheck-ci

No script needed if we make sure extra_src_dirs has different name than "eqc"

Obsolete QuickCheck property

.eqc_ci

@@ -0,0 +1,3 @@
+{build, "rebar3 as eqc compile"}.
+{test_root, "."}.
+{test_path, "_build/eqc/lib/aesophia/quickcheck"}.   %% here are the properties

.gitignore

@@ -16,6 +16,8 @@ _build
 .idea
 *.iml
 rebar3.crashdump
+current_counterexample.eqc
+.qcci
 *.erl~
 *.aes~
-aesophia
+

README.md

@@ -9,17 +9,8 @@ It is an OTP application written in Erlang and is by default included in
 also be included in other systems to compile contracts coded in sophia which
 can then be loaded into the æternity system.
 
-## Versioning
-
-`aesophia` has a version that is only loosely connected to the version of the
-Aeternity node - in principle they will share the major version but not
-minor/patch version. The `aesophia` compiler version MUST be bumped whenever
-there is a change in how byte code is generated, but it MAY also be bumped upon
-API changes etc.
-
 ## Interface Modules
 
 The basic modules for interfacing the compiler:
 
 * [aeso_compiler: the Sophia compiler](./docs/aeso_compiler.md)
-* [aeso_aci: the ACI interface](./docs/aeso_aci.md)

VERSION

@@ -1 +0,0 @@
-2.0.0

docs/RELEASE-NOTES-2.0.0.md

@@ -1,16 +0,0 @@
-# About this release
-
-This is the `aesophia` compiler version 2.0.0. The main changes compared to version 1.2.0 are:
-
-* Add `Crypto.ecverify` to the compiler.
-* Add `Crypto.sha3`, `Crypto.blake2`, `Crypto.sha256`, `String.blake2` and
-  `String.sha256` to the compiler.
-* Add the `bits` type for working with bit fields in Sophia.
-* Use native bit shift operations in builtin functions, reducing gas cost.
-* Add Namespaces to Sophia in order to simplify using library contracts, etc.
-* Simplify calldata creation - instead of passing a compiled contract, simply
-  pass a (stubbed) contract string.
-* Add a missig type check on the `init` function - detects programmer errors earlier.
-* Improve type checking of `record` fields - generates more understandable error messages.
-* Improved, more coherent, error messages.
-* Add the ACI (Aeternity Contract Interface) generator.

docs/aeso_aci.md

@@ -1,135 +0,0 @@
-# aeso_aci
-
-### Module
-
-### aeso_aci
-
-The ACI interface encoder and decoder.
-
-### Description
-
-This module provides an interface to generate and convert between
-Sophia contracts and a suitable JSON encoding of contract
-interface. As yet the interface is very basic.
-
-Encoding this contract:
-
-```
-contract Answers =
-  record state = { a : answers }
-  type answers() = map(string, int)
-
-  stateful function init() = { a = {} }
-  private function the_answer() = 42
-  function new_answer(q : string, a : int) : answers() = { [q] = a }
-```
-
-generates the following JSON structure representing the contract interface:
-
-
-``` json
-{
-  "contract": {
-    "name": "Answers",
-    "type_defs": [
-      {
-        "name": "state",
-        "vars": [],
-        "typedef": "{a : map(string,int)}"
-      },
-      {
-        "name": "answers",
-        "vars": [],
-        "typedef": "map(string,int)"
-      }
-    ],
-    "functions": [
-      {
-        "name": "init",
-        "arguments": [],
-        "type": "{a : map(string,int)}",
-        "stateful": true
-      },
-      {
-        "name": "new_answer",
-        "arguments": [
-          {
-            "name": "q",
-            "type": "string"
-          },
-          {
-            "name": "a",
-            "type": "int"
-          }
-        ],
-        "type": "map(string,int)",
-        "stateful": false
-      }
-    ]
-  }
-}
-```
-
-When that encoding is decoded the following include definition is generated:
-
-```
-contract Answers =
-  function new_answer : (string, int) => map(string,int)
-```
-
-### Types
-``` erlang
-contract_string() = string() | binary()
-json_string() = binary()
-```
-
-### Exports
-
-#### encode(ContractString) -> {ok,JSONstring} | {error,ErrorString}
-
-Types
-
-``` erlang
-ConstractString = contract_string()
-JSONstring = json_string()
-```
-
-Generate the JSON encoding of the interface to a contract. The type definitions and non-private functions are included in the JSON string.
-
-#### decode(JSONstring) -> ConstractString.
-
-Types
-
-``` erlang
-ConstractString = contract_string()
-JSONstring = json_string()
-```
-
-Take a JSON encoding of a contract interface and generate and generate a contract definition which can be included in another contract.
-
-### Example run
-
-This is an example of using the ACI generator from an Erlang shell. The file called `aci_test.aes` contains the contract in the description from which we want to generate files `aci_test.json` which is the JSON encoding of the contract interface and `aci_test.include` which is the contract definition to be included inside another contract.
-
-``` erlang
-1> {ok,Contract} = file:read_file("aci_test.aes").
-{ok,<<"contract Answers =\n  record state = { a : answers }\n  type answers() = map(string, int)\n\n  stateful function"...>>}
-2> {ok,Encoding} = aeso_aci:encode(Contract).
-<<"{\"contract\":{\"name\":\"Answers\",\"type_defs\":[{\"name\":\"state\",\"vars\":[],\"typedef\":\"{a : map(string,int)}\"},{\"name\":\"ans"...>>
-3> file:write_file("aci_test.aci", Encoding).
-ok
-4> Decoded = aeso_aci:decode(Encoding).
-<<"contract Answers =\n  function new_answer : (string, int) => map(string,int)\n">>
-5> file:write_file("aci_test.include", Decoded).
-ok
-6> jsx:prettify(Encoding).
-<<"{\n  \"contract\": {\n    \"name\": \"Answers\",\n    \"type_defs\": [\n      {\n        \"name\": \"state\",\n        \"vars\": [],\n   "...>>
-```
-
-The final call to `jsx:prettify(Encoding)` returns the encoding in a
-more easily readable form. This is what is shown in the description
-above.
-
-### Notes
-
-The ACI generator currently cannot properly handle types defined using `datatype`.

docs/aeso_compiler.md

@@ -15,7 +15,7 @@ returns the compiled module in a map which can then be loaded.
 ``` erlang
 contract_string() = string() | binary()
 contract_map() = #{bytecode => binary(),
-                   compiler_version => binary(),
+                   compiler_version => string(),
                    contract_souce => string(),
                    type_info => type_info()}
 type_info()
@@ -75,12 +75,12 @@ Types
 
 Get the type representation of a type declaration.
 
-#### version() -> {ok, Version} | {error, term()}
+#### version() -> Version
 
 Types
 
 ``` erlang
-Version = binary()
+Version = integer()
 ```
 
 Get the current version of the Sophia compiler.

quickcheck/aeso_heap_eqc.erl

@@ -0,0 +1,109 @@
+%%% File        : aeso_heap_eqc.erl
+%%% Author      : Ulf Norell
+%%% Description :
+%%% Created     : 28 May 2018 by Ulf Norell
+-module(aeso_heap_eqc).
+
+-compile([export_all, nowarn_export_all]).
+-include_lib("eqc/include/eqc.hrl").
+
+-define(SANDBOX(Code), sandbox(fun() -> Code end)).
+
+sandbox(Code) ->
+    Parent = self(),
+    Tag    = make_ref(),
+    {Pid, Ref} = spawn_monitor(fun() -> Parent ! {Tag, Code()} end),
+    receive
+        {Tag, Res} -> erlang:demonitor(Ref, [flush]), {ok, Res};
+        {'DOWN', Ref, process, Pid, Reason} -> {error, Reason}
+    after 100 ->
+        exit(Pid, kill),
+        {error, loop}
+    end.
+
+prop_from_binary() ->
+    ?FORALL({T, Bin}, {type(), blob()},
+    begin
+    Tag = fun(X) when is_atom(X) -> X; (X) when is_tuple(X) -> element(1, X) end,
+    case ?SANDBOX(aeso_heap:from_binary(T, Bin)) of
+        {ok, Res} -> collect({Tag(T), element(1, Res)}, true);
+        Err       -> equals(Err, {ok, '_'})
+    end end).
+
+type() -> ?LET(Depth, choose(0, 2), type(Depth, true)).
+type(Depth, TypeRep) ->
+    oneof(
+    [ elements([word, string] ++ [typerep || TypeRep]) ] ++
+    [ ?LETSHRINK([T], [type(Depth - 1, TypeRep)], {list, T})       || Depth > 0 ] ++
+    [ ?LETSHRINK([T], [type(Depth - 1, TypeRep)], {option, T})     || Depth > 0 ] ++
+    [ ?LETSHRINK(Ts,  list(type(Depth - 1, TypeRep)), {tuple, Ts}) || Depth > 0 ] ++
+    [ ?LETSHRINK([K, V], vector(2, type(Depth - 1, TypeRep)), {map, K, V}) || Depth > 0 ] ++
+    []
+    ).
+
+blob() ->
+    ?LET(Blobs, list(oneof([ ?LET(Ws, words(), return(from_words(Ws)))
+                           , binary() ])),
+    return(list_to_binary(Blobs))).
+
+words() -> list(word()).
+word() ->
+    frequency(
+    [ {4, ?LET(N, nat(), 32 * N)}
+    , {1, choose(0, 320)}
+    , {2, -1}
+    , {2, elements(["foo", "zzzzz"])} ]).
+
+from_words(Ws) ->
+    << <<(from_word(W))/binary>> || W <- Ws >>.
+
+from_word(W) when is_integer(W) ->
+    <<W:256>>;
+from_word(S) when is_list(S) ->
+    Len = length(S),
+    Bin = <<(list_to_binary(S))/binary, 0:(32 - Len)/unit:8>>,
+    <<Len:256, Bin/binary>>.
+
+typerep() -> ?LET(Depth, choose(0, 2),
+             ?LET(T, type(Depth, true), return(typerep(T)))).
+
+typerep(word)          -> word;
+typerep(string)        -> string;
+typerep(typerep)       -> typerep;
+typerep({tuple, Ts})   -> {tuple, typerep(Ts)};
+typerep({list, T})     -> {list, typerep(T)};
+typerep({variant, Cs}) -> {variant, typerep(Cs)};
+typerep({option, T})   -> {variant, [[], [typerep(T)]]};
+typerep({map, K, V})   -> {list, typerep({tuple, [K, V]})};
+typerep([])            -> [];
+typerep([T | Ts])      -> [typerep(T) | typerep(Ts)].
+
+value(word) ->
+    <<N:256>> = <<(-1):256>>,
+    choose(0, N);
+value(string) ->
+    ?LET(N, choose(0, 128), binary(N));
+value(typerep) ->
+    typerep();
+value({list, T}) ->
+    list(value(T));
+value({option, T}) ->
+    weighted_default({1, none}, {3, {some, value(T)}});
+value({tuple, Ts}) ->
+    ?LET(Vs, [ value(T) || T <- Ts ], list_to_tuple(Vs));
+value({map, K, V}) ->
+    map(value(K), value(V));
+value({variant, Cs}) ->
+    ?LET(I, choose(0, length(Cs) - 1),
+    {variant, I, [ value(T) || T <- lists:nth(I + 1, Cs) ]}).
+
+typed_val() ->
+    ?LET(T, type(), ?LET(V, value(T), return({T, V}))).
+
+prop_roundtrip() ->
+    ?FORALL(T, type(),
+    ?FORALL(V, value(T),
+    ?FORALL(B, choose(0, 4),
+    equals(aeso_heap:from_binary(T, aeso_heap:to_binary(V, B * 32), B * 32),
+           {ok, V})))).
+

quickcheck/aeso_utils_eqc.erl

@@ -0,0 +1,59 @@
+%%% File        : aeso_utils_eqc.erl
+%%% Author      : Ulf Norell
+%%% Description :
+%%% Created     : 2 Jul 2018 by Ulf Norell
+-module(aeso_utils_eqc).
+
+-compile([export_all, nowarn_export_all]).
+
+-include_lib("eqc/include/eqc.hrl").
+
+%% QuickCheck property
+
+graph() ->
+    ?LET(M, map(choose(0, 10), list(choose(0, 10))),
+    return(complete(M))).
+
+complete(G) ->
+    Is = lists:usort(lists:concat(maps:values(G))),
+    maps:merge(maps:from_list([ {I, []} || I <- Is ]), G).
+
+prop_scc() ->
+    ?FORALL(G, graph(),
+    begin
+        SCCs = aeso_utils:scc(G),
+        BadSCC = fun({acyclic, I}) -> reachable_from(G, I, I);
+                    ({cyclic, Is}) -> [] /= [ {I, J} || I <- Is, J <- Is, not reachable_from(G, I, J) ]
+                 end,
+        ToList = fun({acyclic, I}) -> [I];
+                    ({cyclic, Is}) -> Is end,
+        ?WHENFAIL(eqc:format("SCCs = ~p\n", [SCCs]),
+        conjunction(
+            [ {elems,  equals(lists:sort(lists:flatmap(ToList, SCCs)), lists:sort(maps:keys(G)))}
+            , {sorted, equals([], [ {I, J} || {I, Js} <- maps:to_list(G),
+                                              J <- Js,
+                                              find_component(I, SCCs) < find_component(J, SCCs) ])}
+            , {precise, equals([], [ SCC || SCC <- SCCs, BadSCC(SCC) ])}
+            ]))
+    end).
+
+reachable_from(Graph, I, J) ->
+    reachable_from1(Graph, maps:get(I, Graph, []), J).
+
+reachable_from1(_, [], _) -> false;
+reachable_from1(_, [I | _], I) -> true;
+reachable_from1(Graph, [I | Is], J) ->
+    case maps:get(I, Graph, undefined) of
+        undefined -> reachable_from1(Graph, Is, J);
+        Js        -> reachable_from1(maps:remove(I, Graph), Js ++ Is, J)
+    end.
+
+find_component(X, SCCs) ->
+    ISCCs = lists:zip(SCCs, lists:seq(1, length(SCCs))),
+    HasX  = fun({acyclic, Y}) -> X == Y;
+               ({cyclic, Ys}) -> lists:member(X, Ys) end,
+    case [ I || {SCC, I} <- ISCCs, HasX(SCC) ] of
+        [I | _] -> I;
+        []      -> false
+    end.
+

rebar.config

@@ -1,14 +1,17 @@
-%% -*- mode: erlang; indent-tabs-mode: nil -*-
-
 {erl_opts, [debug_info]}.
 
 {deps, [ {aebytecode, {git, "https://github.com/aeternity/aebytecode.git",
                             {ref,"720510a"}}}
        , {getopt, "1.0.1"}
-       , {jsx, {git, "https://github.com/talentdeficit/jsx.git",
-                     {tag, "2.8.0"}}}
        ]}.
 
+
+{profiles, [ {eqc, [{erl_opts, [{parse_transform, eqc_cover}]},
+                    {deps, [{eqc_ci, "1.0.0"}]},
+                    {extra_src_dirs, ["quickcheck"]}    %% May not be called eqc!
+                   ]}
+           ]}.
+
 {escript_incl_apps, [aesophia, aebytecode, getopt]}.
 {escript_main_app, aesophia}.
 {escript_name, aesophia}.

rebar.lock

@@ -3,11 +3,7 @@
   {git,"https://github.com/aeternity/aebytecode.git",
        {ref,"720510a24de32c9bad6486f34ca7babde124bf1e"}},
   0},
- {<<"getopt">>,{pkg,<<"getopt">>,<<"1.0.1">>},0},
+ {<<"getopt">>,{pkg,<<"getopt">>,<<"1.0.1">>},0}]}.
- {<<"jsx">>,
-  {git,"https://github.com/talentdeficit/jsx.git",
-       {ref,"3074d4865b3385a050badf7828ad31490d860df5"}},
-  0}]}.
 [
 {pkg_hash,[
  {<<"getopt">>, <<"C73A9FA687B217F2FF79F68A3B637711BB1936E712B521D8CE466B29CBF7808A">>}]}

src/aeso_abi.erl

@@ -11,7 +11,7 @@
 -define(HASH_SIZE, 32).
 
 -export([ old_create_calldata/3
-        , create_calldata/4
+        , create_calldata/5
         , check_calldata/2
         , function_type_info/3
         , function_type_hash/3
@@ -39,12 +39,22 @@
 %%%===================================================================
 %%% Handle calldata
 
-create_calldata(FunName, Args, ArgTypes0, RetType) ->
+create_calldata(Contract, FunName, Args, ArgTypes, RetType) ->
-    ArgTypes = {tuple, ArgTypes0},
+    case get_type_info_and_hash(Contract, FunName) of
-    <<TypeHashInt:?HASH_SIZE/unit:8>> =
+        {ok, TypeInfo, TypeHashInt} ->
-        function_type_hash(list_to_binary(FunName), ArgTypes, RetType),
+            Data = aeso_heap:to_binary({TypeHashInt, list_to_tuple(Args)}),
-    Data = aeso_heap:to_binary({TypeHashInt, list_to_tuple(Args)}),
+            case check_calldata(Data, TypeInfo) of
-    {ok, Data, {tuple, [word, ArgTypes]}, RetType}.
+                {ok, CallDataType, OutType} ->
+                    case check_given_type(FunName, ArgTypes, RetType, CallDataType, OutType) of
+                        ok ->
+                            {ok, Data, CallDataType, OutType};
+                        {error, _} = Err ->
+                            Err
+                    end;
+                {error,_What} = Err -> Err
+            end;
+        {error, _} = Err -> Err
+    end.
 
 get_type_info_and_hash(#{type_info := TypeInfo}, FunName) ->
     FunBin = list_to_binary(FunName),
@@ -54,6 +64,26 @@ get_type_info_and_hash(#{type_info := TypeInfo}, FunName) ->
         {error, _} = Err          -> Err
     end.
 
+%% Check that the given type matches the type from the metadata.
+check_given_type(FunName, GivenArgs, GivenRet, CalldataType, ExpectRet) ->
+    {tuple, [word, {tuple, ExpectArgs}]} = CalldataType,
+    ReturnOk = if FunName == "init" -> true;
+                  GivenRet == any   -> true;
+                  true              -> GivenRet == ExpectRet
+               end,
+    ArgsOk   = ExpectArgs == GivenArgs,
+    case ReturnOk andalso ArgsOk of
+        true -> ok;
+        false when FunName == "init" ->
+            {error, {init_args_mismatch,
+                        {given,    GivenArgs},
+                        {expected, ExpectArgs}}};
+        false ->
+            {error, {call_type_mismatch,
+                        {given,    GivenArgs,  '=>', GivenRet},
+                        {expected, ExpectArgs, '=>', ExpectRet}}}
+    end.
+
 -spec check_calldata(binary(), type_info()) ->
                         {'ok', typerep(), typerep()} | {'error', atom()}.
 check_calldata(CallData, TypeInfo) ->
@@ -91,8 +121,8 @@ get_function_hash_from_calldata(CallData) ->
 
 -spec function_type_info(function_name(), [typerep()], typerep()) ->
                             function_type_info().
-function_type_info(Name, ArgTypes, OutType) ->
+function_type_info(Name, Args, OutType) ->
-    ArgType = {tuple, ArgTypes},
+    ArgType = {tuple, [T || {_, T} <- Args]},
     { function_type_hash(Name, ArgType, OutType)
     , Name
     , aeso_heap:to_binary(ArgType)

src/aeso_aci.erl

@@ -1,276 +0,0 @@
-%%%-------------------------------------------------------------------
-%%% @author Robert Virding
-%%% @copyright (C) 2017, Aeternity Anstalt
-%%% @doc
-%%%     ACI interface
-%%% @end
-%%% Created : 12 Dec 2017
-%%%-------------------------------------------------------------------
-
--module(aeso_aci).
-
--export([encode/1,encode/2,decode/1]).
-
-%% Define records for the various typed syntactic forms. These make
-%% the code easier but don't seem to exist elsewhere.
-
--record(contract, {ann,con,decls}).
--record(namespace, {ann,con,decls}).
--record(letfun, {ann,id,args,type,body}).
--record(type_def, {ann,id,vars,typedef}).
-
--record(app_t, {ann,id,fields}).
--record(tuple_t, {ann,args}).
--record(record_t, {fields}).
--record(field_t, {ann,id,type}).
--record(alias_t, {type}).
--record(variant_t, {cons}).
--record(constr_t, {ann,con,args}).
--record(fun_t, {ann,named,args,type}).
-
--record(arg, {ann,id,type}).
--record(id, {ann,name}).
--record(con, {ann,name}).
--record(qid, {ann,names}).
--record(qcon, {ann,names}).
--record(tvar, {ann,name}).
-
-%% encode(ContractString) -> {ok,JSON} | {error,String}.
-%% encode(ContractString, Options) -> {ok,JSON} | {error,String}.
-%%  Build a JSON structure with lists and tuples, not maps, as this
-%%  allows us to order the fields in the contructed JSON string.
-
-encode(ContractString) -> encode(ContractString, []).
-
-encode(ContractString, Options) when is_binary(ContractString) ->
-    encode(binary_to_list(ContractString), Options);
-encode(ContractString, Options) ->
-    try
-        Ast = parse(ContractString, Options),
-        %%io:format("~p\n", [Ast]),
-        %% aeso_ast:pp(Ast),
-        TypedAst = aeso_ast_infer_types:infer(Ast, Options),
-        %% io:format("~p\n", [TypedAst]),
-        %% aeso_ast:pp_typed(TypedAst),
-        %% We find and look at the last contract.
-        Contract = lists:last(TypedAst),
-        Cname = contract_name(Contract),
-        Tdefs = [ encode_typedef(T) ||
-                    T <- sort_decls(contract_types(Contract)) ],
-        Fdefs = [ encode_func(F) || F <- sort_decls(contract_funcs(Contract)),
-                                    not is_private_func(F) ],
-        Jmap = [{<<"contract">>, [{<<"name">>, list_to_binary(Cname)},
-                                  {<<"type_defs">>, Tdefs},
-                                  {<<"functions">>, Fdefs}]}],
-        %% io:format("~p\n", [Jmap]),
-        {ok,jsx:encode(Jmap)}
-    catch
-        %% The compiler errors.
-        error:{parse_errors, Errors} ->
-            {error, join_errors("Parse errors", Errors, fun(E) -> E end)};
-        error:{type_errors, Errors} ->
-            {error, join_errors("Type errors", Errors, fun(E) -> E end)};
-        error:{code_errors, Errors} ->
-            {error, join_errors("Code errors", Errors,
-                                fun (E) -> io_lib:format("~p", [E]) end)}
-        %% General programming errors in the compiler just signal error.
-    end.
-
-join_errors(Prefix, Errors, Pfun) ->
-    Ess = [ Pfun(E) || E <- Errors ],
-    list_to_binary(string:join([Prefix|Ess], "\n")).
-
-encode_func(Fdef) ->
-    Name = function_name(Fdef),
-    Args = function_args(Fdef),
-    Type = function_type(Fdef),
-    [{<<"name">>, list_to_binary(Name)},
-     {<<"arguments">>, encode_args(Args)},
-     {<<"type">>, list_to_binary(encode_type(Type))},
-     {<<"stateful">>, is_stateful_func(Fdef)}].
-
-encode_args(Args) ->
-    [ encode_arg(A) || A <- Args ].
-
-encode_arg(#arg{id=Id,type=T}) ->
-    [{<<"name">>,list_to_binary(encode_type(Id))},
-     {<<"type">>,list_to_binary(encode_type(T))}].
-
-encode_types(Types) ->
-    [ encode_type(T) || T <- Types ].
-
-encode_type(#tvar{name=N}) -> N;
-encode_type(#id{name=N}) -> N;
-encode_type(#con{name=N}) -> N;
-encode_type(#qid{names=Ns}) ->
-    lists:join(".", Ns);
-encode_type(#qcon{names=Ns}) ->
-    lists:join(".", Ns);                        %?
-encode_type(#tuple_t{args=As}) ->
-    Eas = encode_types(As),
-    [$(,lists:join(",", Eas),$)];
-encode_type(#record_t{fields=Fs}) ->
-    Efs = encode_types(Fs),
-    [${,lists:join(",", Efs),$}];
-encode_type(#app_t{id=Id,fields=Fs}) ->
-    Name = encode_type(Id),
-    Efs = encode_types(Fs),
-    [Name,"(",lists:join(",", Efs),")"];
-encode_type(#field_t{id=Id,type=T}) ->
-    [encode_type(Id)," : ",encode_type(T)];
-encode_type(#variant_t{cons=Cs}) ->
-    Ecs = encode_types(Cs),
-    lists:join(" | ", Ecs);
-encode_type(#constr_t{con=C,args=As}) ->
-    Ec = encode_type(C),
-    Eas = encode_types(As),
-    [Ec,$(,lists:join(", ", Eas),$)];
-encode_type(#fun_t{args=As,type=T}) ->
-    Eas = encode_types(As),
-    Et = encode_type(T),
-    [$(,lists:join(", ", Eas),") => ",Et].
-
-encode_typedef(Type) ->
-    Name = typedef_name(Type),
-    Vars = typedef_vars(Type),
-    Def = typedef_def(Type),
-    [{<<"name">>, list_to_binary(Name)},
-     {<<"vars">>, encode_tvars(Vars)},
-     {<<"typedef">>, list_to_binary(encode_alias(Def))}].
-
-encode_tvars(Vars) ->
-    [ encode_tvar(V) || V <- Vars ].
-
-encode_tvar(#tvar{name=N}) ->
-    [{<<"name">>, list_to_binary(N)}].
-
-encode_alias(#alias_t{type=T}) ->
-    encode_type(T);
-encode_alias(A) -> encode_type(A).
-
-%% decode(JSON) -> ContractString.
-%%  Decode a JSON string and generate a suitable contract string which
-%%  can be included in a contract definition. We decode into a map
-%%  here as this is easier to work with and order is not important.
-
-decode(Json) ->
-    Map = jsx:decode(Json, [return_maps]),
-    %% io:format("~p\n", [Map]),
-    #{<<"contract">> := C} = Map,
-    list_to_binary(decode_contract(C)).
-
-decode_contract(#{<<"name">> := Name,
-                  <<"type_defs">> := _Ts,
-                  <<"functions">> := Fs}) ->
-    ["contract"," ",io_lib:format("~s", [Name])," =\n",
-     [],                                        %Don't include types yet.
-     %% decode_tdefs(Ts),
-     decode_funcs(Fs)].
-
-decode_funcs(Fs) -> [ decode_func(F) || F <- Fs ].
-
-decode_func(#{<<"name">> := <<"init">>}) -> [];
-decode_func(#{<<"name">> := Name,<<"arguments">> := As,<<"type">> := T}) ->
-    ["  function"," ",io_lib:format("~s", [Name])," : ",
-     decode_args(As)," => ",decode_type(T),$\n].
-
-decode_type(T) -> io_lib:format("~s", [T]).
-
-decode_args(As) ->
-    Das = [ decode_arg(A) || A <- As ],
-    [$(,lists:join(", ", Das),$)].
-
-decode_arg(#{<<"type">> := T}) -> decode_type(T).
-
-%% To keep dialyzer happy and quiet.
-%% decode_tdefs(Ts) -> [ decode_tdef(T) || T <- Ts ].
-%%
-%% decode_tdef(#{<<"name">> := Name,<<"vars">> := Vs,<<"typedef">> := T}) ->
-%%     ["  type"," ",io_lib:format("~s", [Name]),decode_tvars(Vs),
-%%      " = ",decode_type(T),$\n].
-%%
-%% decode_tvars([]) -> [];                         %No tvars, no parentheses
-%% decode_tvars(Vs) ->
-%%     Dvs = [ decode_tvar(V) || V <- Vs ],
-%%     [$(,lists:join(", ", Dvs),$)].
-%%
-%% decode_tvar(#{<<"name">> := N}) -> io_lib:format("~s", [N]).
-%%
-%% #contract{Ann, Con, [Declarations]}.
-
-contract_name(#contract{con=#con{name=N}}) -> N.
-
-contract_funcs(#contract{decls=Decls}) ->
-    [ D || D <- Decls, is_record(D, letfun) ].
-
-contract_types(#contract{decls=Decls}) ->
-    [ D || D <- Decls, is_record(D, type_def) ].
-
-%% To keep dialyzer happy and quiet.
-%% namespace_name(#namespace{con=#con{name=N}}) -> N.
-%%
-%% namespace_funcs(#namespace{decls=Decls}) ->
-%%     [ D || D <- Decls, is_record(D, letfun) ].
-%%
-%% namespace_types(#namespace{decls=Decls}) ->
-%%     [ D || D <- Decls, is_record(D, type_def) ].
-
-sort_decls(Ds) ->
-    Sort = fun (D1, D2) ->
-                   aeso_syntax:get_ann(line, D1, 0) =<
-                       aeso_syntax:get_ann(line, D2, 0)
-           end,
-    lists:sort(Sort, Ds).
-
-%% #letfun{Ann, Id, [Arg], Type, Typedef}.
-
-function_name(#letfun{id=#id{name=N}}) -> N.
-
-function_args(#letfun{args=Args}) -> Args.
-
-function_type(#letfun{type=Type}) -> Type.
-
-is_private_func(#letfun{ann=A}) -> aeso_syntax:get_ann(private, A, false).
-
-is_stateful_func(#letfun{ann=A}) -> aeso_syntax:get_ann(stateful, A, false).
-
-%% #type_def{Ann, Id, [Var], Typedef}.
-
-typedef_name(#type_def{id=#id{name=N}}) -> N.
-
-typedef_vars(#type_def{vars=Vars}) -> Vars.
-
-typedef_def(#type_def{typedef=Def}) -> Def.
-
-parse(Text, Options) ->
-    %% Try and return something sensible here!
-    case aeso_parser:string(Text, Options) of
-        %% Yay, it worked!
-        {ok, Contract} -> Contract;
-        %% Scan errors.
-        {error, {Pos, scan_error}} ->
-            parse_error(Pos, "scan error");
-        {error, {Pos, scan_error_no_state}} ->
-            parse_error(Pos, "scan error");
-        %% Parse errors.
-        {error, {Pos, parse_error, Error}} ->
-            parse_error(Pos, Error);
-        {error, {Pos, ambiguous_parse, As}} ->
-            ErrorString = io_lib:format("Ambiguous ~p", [As]),
-            parse_error(Pos, ErrorString);
-        %% Include error
-        {error, {Pos, include_error, File}} ->
-            parse_error(Pos, io_lib:format("could not find include file '~s'", [File]))
-    end.
-
-parse_error(Pos, ErrorString) ->
-    io:format("Error ~p ~p\n", [Pos,ErrorString]),
-    Error = io_lib:format("~s: ~s", [pos_error(Pos), ErrorString]),
-    error({parse_errors, [Error]}).
-
-pos_error({Line, Pos}) ->
-    io_lib:format("line ~p, column ~p", [Line, Pos]);
-pos_error({no_file, Line, Pos}) ->
-    pos_error({Line, Pos});
-pos_error({File, Line, Pos}) ->
-    io_lib:format("file ~s, line ~p, column ~p", [File, Line, Pos]).

src/aeso_ast.erl

@@ -17,6 +17,7 @@ line({symbol, Line, _}) -> Line.
 symbol_name({symbol, _, Name}) -> Name.
 
 pp(Ast) ->
+    %% io:format("Tree:\n~p\n",[Ast]),
     String = prettypr:format(aeso_pretty:decls(Ast, [])),
     io:format("Ast:\n~s\n", [String]).
 

src/aeso_ast_to_icode.erl

@@ -17,19 +17,11 @@
 
 -spec convert_typed(aeso_syntax:ast(), list()) -> aeso_icode:icode().
 convert_typed(TypedTree, Options) ->
-    Name = case lists:last(TypedTree) of
+    code(TypedTree, aeso_icode:new(Options)).
-               {contract, _, {con, _, Con}, _} -> Con;
-               _ -> gen_error(last_declaration_must_be_contract)
-           end,
-    Icode = code(TypedTree, aeso_icode:set_name(Name, aeso_icode:new(Options))),
-    deadcode_elimination(Icode).
 
-code([{contract, _Attribs, Con, Code}|Rest], Icode) ->
+code([{contract, _Attribs, {con, _, Name}, Code}|Rest], Icode) ->
-    NewIcode = contract_to_icode(Code, aeso_icode:set_namespace(Con, Icode)),
+    NewIcode = contract_to_icode(Code,
-    code(Rest, NewIcode);
+                                 aeso_icode:set_name(Name, Icode)),
-code([{namespace, _Ann, Name, Code}|Rest], Icode) ->
-                                            %% TODO: nested namespaces
-    NewIcode = contract_to_icode(Code, aeso_icode:set_namespace(Name, Icode)),
     code(Rest, NewIcode);
 code([], Icode) ->
     add_default_init_function(add_builtins(Icode)).
@@ -41,38 +33,30 @@ gen_error(Error) ->
 
 %% Create default init function (only if state is unit).
 add_default_init_function(Icode = #{functions := Funs, state_type := State}) ->
-    {_, _, QInit} = aeso_icode:qualify({id, [], "init"}, Icode),
+    case lists:keymember("init", 1, Funs) of
-    case lists:keymember(QInit, 1, Funs) of
         true -> Icode;
-        false when State /= {tuple, []} ->
+        false when State /= {tuple, []} -> gen_error(missing_init_function);
-            gen_error(missing_init_function);
         false ->
             Type  = {tuple, [typerep, {tuple, []}]},
             Value = #tuple{ cpts = [type_value({tuple, []}), {tuple, []}] },
-            DefaultInit = {QInit, [], [], Value, Type},
+            DefaultInit = {"init", [], [], Value, Type},
             Icode#{ functions => [DefaultInit | Funs] }
     end.
 
 -spec contract_to_icode(aeso_syntax:ast(), aeso_icode:icode()) ->
                                aeso_icode:icode().
-contract_to_icode([{namespace, _, Name, Defs} | Rest], Icode) ->
+contract_to_icode([{type_def, _Attrib, {id, _, Name}, Args, Def} | Rest],
-    NS = aeso_icode:get_namespace(Icode),
-    Icode1 = contract_to_icode(Defs, aeso_icode:enter_namespace(Name, Icode)),
-    contract_to_icode(Rest, aeso_icode:set_namespace(NS, Icode1));
-contract_to_icode([{type_def, _Attrib, Id = {id, _, Name}, Args, Def} | Rest],
                   Icode = #{ types := Types, constructors := Constructors }) ->
     TypeDef = make_type_def(Args, Def, Icode),
     NewConstructors =
         case Def of
             {variant_t, Cons} ->
                 Tags = lists:seq(0, length(Cons) - 1),
-                GetName = fun({constr_t, _, C, _}) -> C end,
+                GetName = fun({constr_t, _, {con, _, C}, _}) -> C end,
-                QName = fun(Con) -> {_, _, Xs} = aeso_icode:qualify(GetName(Con), Icode), Xs end,
+                maps:from_list([ {GetName(Con), Tag} || {Tag, Con} <- lists:zip(Tags, Cons) ]);
-                maps:from_list([ {QName(Con), Tag} || {Tag, Con} <- lists:zip(Tags, Cons) ]);
             _ -> #{}
         end,
-    {_, _, TName} = aeso_icode:qualify(Id, Icode),
+    Icode1 = Icode#{ types := Types#{ Name => TypeDef },
-    Icode1 = Icode#{ types := Types#{ TName => TypeDef },
                      constructors := maps:merge(Constructors, NewConstructors) },
     Icode2 = case Name of
                 "state" when Args == [] -> Icode1#{ state_type => ast_typerep(Def, Icode) };
@@ -84,7 +68,8 @@ contract_to_icode([{type_def, _Attrib, Id = {id, _, Name}, Args, Def} | Rest],
     contract_to_icode(Rest, Icode2);
 contract_to_icode([{letfun, Attrib, Name, Args, _What, Body={typed,_,_,T}}|Rest], Icode) ->
     FunAttrs = [ stateful || proplists:get_value(stateful, Attrib, false) ] ++
-               [ private  || is_private(Attrib, Icode) ],
+               [ private  || proplists:get_value(private, Attrib, false) orelse
+                             proplists:get_value(internal, Attrib, false) ],
     %% TODO: Handle types
     FunName = ast_id(Name),
     %% TODO: push funname to env
@@ -99,8 +84,7 @@ contract_to_icode([{letfun, Attrib, Name, Args, _What, Body={typed,_,_,T}}|Rest]
                  {tuple, [typerep, ast_typerep(T, Icode)]}};
             _ -> {ast_body(Body, Icode), ast_typerep(T, Icode)}
         end,
-    QName    = aeso_icode:qualify(Name, Icode),
+    NewIcode = ast_fun_to_icode(FunName, FunAttrs, FunArgs, FunBody, TypeRep, Icode),
-    NewIcode = ast_fun_to_icode(ast_id(QName), FunAttrs, FunArgs, FunBody, TypeRep, Icode),
     contract_to_icode(Rest, NewIcode);
 contract_to_icode([{letrec,_,Defs}|Rest], Icode) ->
     %% OBS! This code ignores the letrec structure of the source,
@@ -110,14 +94,11 @@ contract_to_icode([{letrec,_,Defs}|Rest], Icode) ->
     %% just to parse a list of (mutually recursive) definitions.
     contract_to_icode(Defs++Rest, Icode);
 contract_to_icode([], Icode) -> Icode;
-contract_to_icode([{fun_decl, _, _, _} | Code], Icode) ->
+contract_to_icode(_Code, Icode) ->
-    contract_to_icode(Code, Icode);
+    %% TODO debug output for debug("Unhandled code ~p~n",[Code]),
-contract_to_icode([Decl | Code], Icode) ->
+    Icode.
-    io:format("Unhandled declaration: ~p\n", [Decl]),
-    contract_to_icode(Code, Icode).
 
-ast_id({id, _, Id}) -> Id;
+ast_id({id, _, Id}) -> Id.
-ast_id({qid, _, Id}) -> Id.
 
 ast_args([{arg, _, Name, Type}|Rest], Acc, Icode) ->
     ast_args(Rest, [{ast_id(Name), ast_type(Type, Icode)}| Acc], Icode);
@@ -140,7 +121,7 @@ ast_type(T, Icode) ->
 ast_body(?qid_app(["Chain","spend"], [To, Amount], _, _), Icode) ->
     prim_call(?PRIM_CALL_SPEND, ast_body(Amount, Icode), [ast_body(To, Icode)], [word], {tuple, []});
 
-ast_body(?qid_app([Con, "Chain", "event"], [Event], _, _), Icode = #{ contract_name := Con }) ->
+ast_body(?qid_app(["Chain","event"], [Event], _, _), Icode) ->
     aeso_builtins:check_event_type(Icode),
     builtin_call({event, maps:get(event_type, Icode)}, [ast_body(Event, Icode)]);
 
@@ -171,10 +152,10 @@ ast_body({qid, _, ["Chain", "spend"]}, _Icode) ->
     gen_error({underapplied_primitive, 'Chain.spend'});
 
 %% State
-ast_body({qid, _, [Con, "state"]}, #{ contract_name := Con }) -> prim_state;
+ast_body({id, _, "state"}, _Icode) -> prim_state;
-ast_body(?qid_app([Con, "put"], [NewState], _, _), Icode = #{ contract_name := Con }) ->
+ast_body(?id_app("put", [NewState], _, _), Icode) ->
     #prim_put{ state = ast_body(NewState, Icode) };
-ast_body({qid, _, [Con, "put"]}, #{ contract_name := Con }) ->
+ast_body({id, _, "put"}, _Icode) ->
     gen_error({underapplied_primitive, put});   %% TODO: eta
 
 %% Abort
@@ -403,8 +384,7 @@ ast_body(?qid_app(["Address", "to_str"], [Addr], _, _), Icode) ->
 
 %% Other terms
 ast_body({id, _, Name}, _Icode) ->
-    #var_ref{name = Name};
+    %% TODO Look up id in env
-ast_body({qid, _, Name}, _Icode) ->
     #var_ref{name = Name};
 ast_body({bool, _, Bool}, _Icode) ->        %BOOL as ints
     Value = if Bool -> 1 ; true -> 0 end,
@@ -461,15 +441,9 @@ ast_body({proj, _, {typed, _, _, {con, _, Contract}}, {id, _, FunName}}, _Icode)
                string:join([Contract, FunName], ".")});
 
 ast_body({con, _, Name}, Icode) ->
-    Tag = aeso_icode:get_constructor_tag([Name], Icode),
-    #tuple{cpts = [#integer{value = Tag}]};
-ast_body({qcon, _, Name}, Icode) ->
     Tag = aeso_icode:get_constructor_tag(Name, Icode),
     #tuple{cpts = [#integer{value = Tag}]};
 ast_body({app, _, {typed, _, {con, _, Name}, _}, Args}, Icode) ->
-    Tag = aeso_icode:get_constructor_tag([Name], Icode),
-    #tuple{cpts = [#integer{value = Tag} | [ ast_body(Arg, Icode) || Arg <- Args ]]};
-ast_body({app, _, {typed, _, {qcon, _, Name}, _}, Args}, Icode) ->
     Tag = aeso_icode:get_constructor_tag(Name, Icode),
     #tuple{cpts = [#integer{value = Tag} | [ ast_body(Arg, Icode) || Arg <- Args ]]};
 ast_body({app,As,Fun,Args}, Icode) ->
@@ -771,15 +745,6 @@ has_maps({list, T})     -> has_maps(T);
 has_maps({tuple, Ts})   -> lists:any(fun has_maps/1, Ts);
 has_maps({variant, Cs}) -> lists:any(fun has_maps/1, lists:append(Cs)).
 
-%% A function is private if marked 'private' or 'internal', or if it's not
-%% defined in the main contract name space. (NOTE: changes when we introduce
-%% inheritance).
-is_private(Ann, #{ contract_name := MainContract } = Icode) ->
-    {_, _, CurrentNamespace} = aeso_icode:get_namespace(Icode),
-    proplists:get_value(private,  Ann, false) orelse
-    proplists:get_value(internal, Ann, false) orelse
-    MainContract /= CurrentNamespace.
-
 %% -------------------------------------------------------------------
 %% Builtins
 %% -------------------------------------------------------------------
@@ -791,39 +756,3 @@ builtin_call(Builtin, Args) ->
 add_builtins(Icode = #{functions := Funs}) ->
     Builtins = aeso_builtins:used_builtins(Funs),
     Icode#{functions := [ aeso_builtins:builtin_function(B) || B <- Builtins ] ++ Funs}.
-
-
-%% -------------------------------------------------------------------
-%% Deadcode elimination
-%% -------------------------------------------------------------------
-
-deadcode_elimination(Icode = #{ functions := Funs }) ->
-    PublicNames = [ Name || {Name, Ann, _, _, _} <- Funs, not lists:member(private, Ann) ],
-    ArgsToPat   = fun(Args) -> [ #var_ref{ name = X } || {X, _} <- Args ] end,
-    Defs        = maps:from_list([ {Name, {binder, ArgsToPat(Args), Body}} || {Name, _, Args, Body, _} <- Funs ]),
-    UsedNames   = chase_names(Defs, PublicNames, #{}),
-    UsedFuns    = [ Def || Def = {Name, _, _, _, _} <- Funs, maps:is_key(Name, UsedNames) ],
-    Icode#{ functions := UsedFuns }.
-
-chase_names(_Defs, [], Used) -> Used;
-chase_names(Defs, [X | Xs], Used) ->
-                              %% can happen when compiling __call contracts
-    case maps:is_key(X, Used) orelse not maps:is_key(X, Defs) of
-        true  -> chase_names(Defs, Xs, Used); %% already chased
-        false ->
-            Def  = maps:get(X, Defs),
-            Vars = maps:keys(free_vars(Def)),
-            chase_names(Defs, Vars ++ Xs, Used#{ X => true })
-    end.
-
-free_vars(#var_ref{ name = X }) -> #{ X => true };
-free_vars(#arg{ name = X }) -> #{ X => true };
-free_vars({binder, Pat, Body}) ->
-    maps:without(maps:keys(free_vars(Pat)), free_vars(Body));
-free_vars(#switch{ expr = E, cases = Cases }) ->
-    free_vars([E | [{binder, P, B} || {P, B} <- Cases]]);
-free_vars(#lambda{ args = Xs, body = E }) ->
-    free_vars({binder, Xs, E});
-free_vars(T) when is_tuple(T) -> free_vars(tuple_to_list(T));
-free_vars([H | T]) -> maps:merge(free_vars(H), free_vars(T));
-free_vars(_) -> #{}.

src/aeso_builtins.erl

@@ -106,22 +106,21 @@ check_event_type(Icode) ->
     end.
 
 check_event_type(Evts, Icode) ->
-    [ check_event_type(Name, Ix, T, Icode)
+    [ check_event_type(Name, T, Icode)
-      || {constr_t, Ann, {con, _, Name}, Types} <- Evts,
+      || {constr_t, _, {con, _, Name}, Types} <- Evts, T <- Types ].
-         {Ix, T} <- lists:zip(aeso_syntax:get_ann(indices, Ann), Types) ].
 
-check_event_type(EvtName, Ix, Type, Icode) ->
+check_event_type(EvtName, Type, Icode) ->
     VMType =
         try
            aeso_ast_to_icode:ast_typerep(Type, Icode)
         catch _:_ ->
             error({EvtName, could_not_resolve_type, Type})
         end,
-    case {Ix, VMType} of
+    case aeso_syntax:get_ann(indexed, Type, false) of
-        {indexed, word}      -> ok;
+        true when VMType == word    -> ok;
-        {notindexed, string} -> ok;
+        false when VMType == string -> ok;
-        {indexed, _}         -> error({EvtName, indexed_field_should_be_word, is, VMType});
+        true  -> error({EvtName, indexed_field_should_be_word, is, VMType});
-        {notindexed, _}      -> error({EvtName, payload_should_be_string, is, VMType})
+        false -> error({EvtName, payload_should_be_string, is, VMType})
     end.
 
 bfun(B, {IArgs, IExpr, IRet}) ->
@@ -170,15 +169,16 @@ builtin_event(EventT) ->
     A         = fun(X) -> aeb_opcodes:mnemonic(X) end,
     VIx       = fun(Ix) -> v(lists:concat(["v", Ix])) end,
     ArgPats   = fun(Ts) -> [ VIx(Ix) || Ix <- lists:seq(0, length(Ts) - 1) ] end,
+    IsIndexed = fun(T) -> aeso_syntax:get_ann(indexed, T, false) end,
     Payload = %% Should put data ptr, length on stack.
         fun([]) ->  {inline_asm, [A(?PUSH1), 0, A(?PUSH1), 0]};
            ([V]) -> {seq, [V, {inline_asm, [A(?DUP1), A(?MLOAD),                  %% length, ptr
                                             A(?SWAP1), A(?PUSH1), 32, A(?ADD)]}]} %% ptr+32, length
         end,
     Clause =
-        fun(_Tag, {con, _, Con}, IxTypes) ->
+        fun(_Tag, {con, _, Con}, Types) ->
-            Types     = [ T || {_Ix, T} <- IxTypes ],
+            Indexed   = [ Var || {Var, Type} <- lists:zip(ArgPats(Types), Types),
-            Indexed   = [ Var || {Var, {indexed, _Type}} <- lists:zip(ArgPats(Types), IxTypes) ],
+                                 IsIndexed(Type) ],
             EvtIndex  = {unop, 'sha3', str_to_icode(Con)},
             {event, lists:reverse(Indexed) ++ [EvtIndex], Payload(ArgPats(Types) -- Indexed)}
         end,
@@ -189,8 +189,8 @@ builtin_event(EventT) ->
 
     {[{"e", event}],
      {switch, v(e),
-         [{Pat(Tag, Types), Clause(Tag, Con, lists:zip(aeso_syntax:get_ann(indices, Ann), Types))}
+         [{Pat(Tag, Types), Clause(Tag, Con, Types)}
-          || {Tag, {constr_t, Ann, Con, Types}} <- lists:zip(Tags, Cons) ]},
+          || {Tag, {constr_t, _, Con, Types}} <- lists:zip(Tags, Cons) ]},
      {tuple, []}}.
 
 %% Abort primitive.

src/aeso_compiler.erl

@@ -11,63 +11,41 @@
 -export([ file/1
         , file/2
         , from_string/2
-        , check_call/4
+        , check_call/2
         , create_calldata/3
         , version/0
         , sophia_type_to_typerep/1
-        , to_sophia_value/4
-        , to_sophia_value/5
         ]).
 
 -include_lib("aebytecode/include/aeb_opcodes.hrl").
 -include("aeso_icode.hrl").
 
 
--type option() :: pp_sophia_code
+-type option() :: pp_sophia_code | pp_ast | pp_types | pp_typed_ast |
-                | pp_ast
+                  pp_icode| pp_assembler | pp_bytecode.
-                | pp_types
-                | pp_typed_ast
-                | pp_icode
-                | pp_assembler
-                | pp_bytecode
-                | {include, {file_system, [string()]} |
-                            {explicit_files, #{string() => binary()}}}
-                | {src_file, string()}.
 -type options() :: [option()].
 
 -export_type([ option/0
              , options/0
              ]).
 
--spec version() -> {ok, binary()} | {error, term()}.
+-define(COMPILER_VERSION_1, 1).
+-define(COMPILER_VERSION_2, 2).
+
+-define(COMPILER_VERSION, ?COMPILER_VERSION_2).
+
+-spec version() -> pos_integer().
 version() ->
-    case lists:keyfind(aesophia, 1, application:loaded_applications()) of
+    ?COMPILER_VERSION.
-        false ->
-            case application:load(aesophia) of
-                ok ->
-                    case application:get_key(aesophia, vsn) of
-                        {ok, VsnString} ->
-                            {ok, list_to_binary(VsnString)};
-                        undefined ->
-                            {error, failed_to_load_aesophia}
-                    end;
-                Err = {error, _} ->
-                    Err
-            end;
-        {_App, _Des, VsnString} ->
-            {ok, list_to_binary(VsnString)}
-    end.
 
 -spec file(string()) -> {ok, map()} | {error, binary()}.
 file(Filename) ->
-    Dir = filename:dirname(Filename),
+    file(Filename, []).
-    {ok, Cwd} = file:get_cwd(),
-    file(Filename, [{include, {file_system, [Cwd, Dir]}}]).
 
 -spec file(string(), options()) -> {ok, map()} | {error, binary()}.
 file(File, Options) ->
     case read_contract(File) of
-        {ok, Bin} -> from_string(Bin, [{src_file, File} | Options]);
+        {ok, Bin} -> from_string(Bin, Options);
         {error, Error} ->
 	    ErrorString = [File,": ",file:format_error(Error)],
 	    {error, join_errors("File errors", [ErrorString], fun(E) -> E end)}
@@ -78,16 +56,22 @@ from_string(ContractBin, Options) when is_binary(ContractBin) ->
     from_string(binary_to_list(ContractBin), Options);
 from_string(ContractString, Options) ->
     try
-        #{icode := Icode} = string_to_icode(ContractString, Options),
+        Ast = parse(ContractString, Options),
-        TypeInfo  = extract_type_info(Icode),
+        ok = pp_sophia_code(Ast, Options),
-        Assembler = assemble(Icode, Options),
+        ok = pp_ast(Ast, Options),
-        pp_assembler(Assembler, Options),
+        TypedAst = aeso_ast_infer_types:infer(Ast, Options),
+        %% pp_types is handled inside aeso_ast_infer_types.
+        ok = pp_typed_ast(TypedAst, Options),
+        ICode = to_icode(TypedAst, Options),
+        TypeInfo = extract_type_info(ICode),
+        ok = pp_icode(ICode, Options),
+        Assembler =  assemble(ICode, Options),
+        ok = pp_assembler(Assembler, Options),
         ByteCodeList = to_bytecode(Assembler, Options),
         ByteCode = << << B:8 >> || B <- ByteCodeList >>,
-        pp_bytecode(ByteCode, Options),
+        ok = pp_bytecode(ByteCode, Options),
-        {ok, Version} = version(),
         {ok, #{byte_code => ByteCode,
-               compiler_version => Version,
+               compiler_version => version(),
                contract_source => ContractString,
                type_info => TypeInfo
               }}
@@ -103,69 +87,38 @@ from_string(ContractString, Options) ->
         %% General programming errors in the compiler just signal error.
     end.
 
--spec string_to_icode(string(), [option() | permissive_address_literals]) -> map().
-string_to_icode(ContractString, Options0) ->
-    {InferOptions, Options} = lists:partition(fun(Opt) -> Opt == permissive_address_literals end, Options0),
-    Ast = parse(ContractString, Options),
-    pp_sophia_code(Ast, Options),
-    pp_ast(Ast, Options),
-    {TypeEnv, TypedAst} = aeso_ast_infer_types:infer(Ast, [return_env | InferOptions]),
-    pp_typed_ast(TypedAst, Options),
-    Icode = ast_to_icode(TypedAst, Options),
-    pp_icode(Icode, Options),
-    #{ typed_ast => TypedAst,
-       type_env  => TypeEnv,
-       icode     => Icode }.
-
 join_errors(Prefix, Errors, Pfun) ->
     Ess = [ Pfun(E) || E <- Errors ],
     list_to_binary(string:join([Prefix|Ess], "\n")).
 
--define(CALL_NAME,   "__call").
+-define(CALL_NAME, "__call").
--define(DECODE_NAME, "__decode").
 
 %% Takes a string containing a contract with a declaration/prototype of a
-%% function (foo, say) and adds function __call() = foo(args) calling this
+%% function (foo, say) and a function __call() = foo(args) calling this
 %% function. Returns the name of the called functions, typereps and Erlang
 %% terms for the arguments.
-%% NOTE: Special treatment for "init" since it might be implicit and has
+-spec check_call(string(), options()) -> {ok, string(), {[Type], Type | any}, [term()]} | {error, term()}
-%%       a special return type (typerep, T)
--spec check_call(string(), string(), [string()], options()) -> {ok, string(), {[Type], Type}, [term()]} | {error, term()}
     when Type :: term().
-check_call(Source, "init" = FunName, Args, Options) ->
+check_call(ContractString, Options) ->
-    PatchFun = fun(T) -> {tuple, [typerep, T]} end,
-    case check_call(Source, FunName, Args, Options, PatchFun) of
-        Err = {error, _} when Args == [] ->
-            %% Try with default init-function
-            case check_call(insert_init_function(Source, Options), FunName, Args, Options, PatchFun) of
-                {error, _} -> Err; %% The first error is most likely better...
-                Res        -> Res
-            end;
-        Res ->
-            Res
-    end;
-check_call(Source, FunName, Args, Options) ->
-    PatchFun = fun(T) -> T end,
-    check_call(Source, FunName, Args, Options, PatchFun).
-
-check_call(ContractString0, FunName, Args, Options, PatchFun) ->
     try
-        %% First check the contract without the __call function and no permissive literals
+        Ast = parse(ContractString, Options),
-        #{} = string_to_icode(ContractString0, Options),
+        ok = pp_sophia_code(Ast, Options),
-        ContractString = insert_call_function(ContractString0, FunName, Args, Options),
+        ok = pp_ast(Ast, Options),
-        #{typed_ast := TypedAst,
+        TypedAst = aeso_ast_infer_types:infer(Ast, [permissive_address_literals]),
-          icode     := Icode} = string_to_icode(ContractString, [permissive_address_literals | Options]),
         {ok, {FunName, {fun_t, _, _, ArgTypes, RetType}}} = get_call_type(TypedAst),
+        ok = pp_typed_ast(TypedAst, Options),
+        Icode = to_icode(TypedAst, Options),
         ArgVMTypes = [ aeso_ast_to_icode:ast_typerep(T, Icode) || T <- ArgTypes ],
         RetVMType  = case RetType of
                          {id, _, "_"} -> any;
                          _            -> aeso_ast_to_icode:ast_typerep(RetType, Icode)
                      end,
+        ok = pp_icode(Icode, Options),
         #{ functions := Funs } = Icode,
         ArgIcode = get_arg_icode(Funs),
         ArgTerms = [ icode_to_term(T, Arg) ||
                        {T, Arg} <- lists:zip(ArgVMTypes, ArgIcode) ],
-        {ok, FunName, {ArgVMTypes, PatchFun(RetVMType)}, ArgTerms}
+        {ok, FunName, {ArgVMTypes, RetVMType}, ArgTerms}
     catch
         error:{parse_errors, Errors} ->
             {error, join_errors("Parse errors", Errors, fun (E) -> E end)};
@@ -179,159 +132,44 @@ check_call(ContractString0, FunName, Args, Options, PatchFun) ->
                                 fun (E) -> io_lib:format("~p", [E]) end)}
     end.
 
-%% Add the __call function to a contract.
+-spec create_calldata(map(), string(), string()) ->
--spec insert_call_function(string(), string(), [string()], options()) -> string().
-insert_call_function(Code, FunName, Args, Options) ->
-    Ast = parse(Code, Options),
-    Ind = last_contract_indent(Ast),
-    lists:flatten(
-        [ Code,
-          "\n\n",
-          lists:duplicate(Ind, " "),
-          "function __call() = ", FunName, "(", string:join(Args, ","), ")\n"
-        ]).
-
--spec insert_init_function(string(), options()) -> string().
-insert_init_function(Code, Options) ->
-    Ast = parse(Code, Options),
-    Ind = last_contract_indent(Ast),
-    lists:flatten(
-        [ Code,
-          "\n\n",
-          lists:duplicate(Ind, " "), "function init() = ()\n"
-        ]).
-
-last_contract_indent(Decls) ->
-    case lists:last(Decls) of
-        {_, _, _, [Decl | _]} -> aeso_syntax:get_ann(col, Decl, 1) - 1;
-        _                     -> 0
-    end.
-
--spec to_sophia_value(string(), string(), ok | error | revert, aeso_sophia:data()) ->
-        {ok, aeso_syntax:expr()} | {error, term()}.
-to_sophia_value(ContractString, Fun, ResType, Data) ->
-    to_sophia_value(ContractString, Fun, ResType, Data, []).
-
--spec to_sophia_value(string(), string(), ok | error | revert, binary(), options()) ->
-        {ok, aeso_syntax:expr()} | {error, term()}.
-to_sophia_value(_, _, error, Err, _Options) ->
-    {ok, {app, [], {id, [], "error"}, [{string, [], Err}]}};
-to_sophia_value(_, _, revert, Data, _Options) ->
-    case aeso_heap:from_binary(string, Data) of
-        {ok, Err} -> {ok, {app, [], {id, [], "abort"}, [{string, [], Err}]}};
-        {error, _} = Err -> Err
-    end;
-to_sophia_value(ContractString, FunName, ok, Data, Options) ->
-    try
-        #{ typed_ast := TypedAst,
-           type_env  := TypeEnv,
-           icode     := Icode } = string_to_icode(ContractString, Options),
-        {ok, Type0} = get_decode_type(FunName, TypedAst),
-        Type   = aeso_ast_infer_types:unfold_types_in_type(TypeEnv, Type0, [unfold_record_types, unfold_variant_types]),
-        VmType = aeso_ast_to_icode:ast_typerep(Type, Icode),
-        case aeso_heap:from_binary(VmType, Data) of
-            {ok, VmValue} ->
-                try
-                    {ok, translate_vm_value(VmType, Type, VmValue)}
-                catch throw:cannot_translate_to_sophia ->
-                    Type0Str = prettypr:format(aeso_pretty:type(Type0)),
-                    {error, join_errors("Translation error", [lists:flatten(io_lib:format("Cannot translate VM value ~p\n  of type ~p\n  to Sophia type ~s\n",
-                                                                            [Data, VmType, Type0Str]))],
-                                        fun (E) -> E end)}
-                end;
-            {error, _Err} ->
-                {error, join_errors("Decode errors", [lists:flatten(io_lib:format("Failed to decode binary at type ~p", [VmType]))],
-                                    fun(E) -> E end)}
-        end
-    catch
-        error:{parse_errors, Errors} ->
-            {error, join_errors("Parse errors", Errors, fun (E) -> E end)};
-        error:{type_errors, Errors} ->
-            {error, join_errors("Type errors", Errors, fun (E) -> E end)};
-        error:{badmatch, {error, missing_function}} ->
-            {error, join_errors("Type errors", ["no function: '" ++ FunName ++ "'"],
-                                fun (E) -> E end)};
-        throw:Error ->                          %Don't ask
-            {error, join_errors("Code errors", [Error],
-                                fun (E) -> io_lib:format("~p", [E]) end)}
-    end.
-
-address_literal(N) -> {hash, [], <<N:256>>}.  % TODO
-
-%% TODO: somewhere else
-translate_vm_value(word,   {id, _, "address"},                     N) -> address_literal(N);
-translate_vm_value(word,   {app_t, _, {id, _, "oracle"}, _},       N) -> address_literal(N);
-translate_vm_value(word,   {app_t, _, {id, _, "oracle_query"}, _}, N) -> address_literal(N);
-translate_vm_value(word,   {id, _, "hash"},    N) -> {hash, [], <<N:256>>};
-translate_vm_value(word,   {id, _, "int"},     N) -> {int, [], N};
-translate_vm_value(word,   {id, _, "bits"},    N) -> error({todo, bits, N});
-translate_vm_value(word,   {id, _, "bool"},    N) -> {bool, [], N /= 0};
-translate_vm_value({tuple, [word, word]}, {id, _, "signature"}, {tuple, [Hi, Lo]}) ->
-    {hash, [], <<Hi:256, Lo:256>>};
-translate_vm_value(string, {id, _, "string"}, S) -> {string, [], S};
-translate_vm_value({list, VmType}, {app_t, _, {id, _, "list"}, [Type]}, List) ->
-    {list, [], [translate_vm_value(VmType, Type, X) || X <- List]};
-translate_vm_value({option, VmType}, {app_t, _, {id, _, "option"}, [Type]}, Val) ->
-    case Val of
-        none              -> {con, [], "None"};
-        {some, X}         -> {app, [], {con, [], "Some"}, [translate_vm_value(VmType, Type, X)]}
-    end;
-translate_vm_value({variant, [[], [VmType]]}, {app_t, _, {id, _, "option"}, [Type]}, Val) ->
-    case Val of
-        {variant, 0, []}  -> {con, [], "None"};
-        {variant, 1, [X]} -> {app, [], {con, [], "Some"}, [translate_vm_value(VmType, Type, X)]}
-    end;
-translate_vm_value({tuple, VmTypes}, {tuple_t, _, Types}, Val)
-        when length(VmTypes) == length(Types),
-             length(VmTypes) == tuple_size(Val) ->
-    {tuple, [], [translate_vm_value(VmType, Type, X)
-                 || {VmType, Type, X} <- lists:zip3(VmTypes, Types, tuple_to_list(Val))]};
-translate_vm_value({tuple, VmTypes}, {record_t, Fields}, Val)
-        when length(VmTypes) == length(Fields),
-             length(VmTypes) == tuple_size(Val) ->
-    {record, [], [ {field, [], [{proj, [], FName}], translate_vm_value(VmType, FType, X)}
-                   || {VmType, {field_t, _, FName, FType}, X} <- lists:zip3(VmTypes, Fields, tuple_to_list(Val)) ]};
-translate_vm_value({map, VmKeyType, VmValType}, {app_t, _, {id, _, "map"}, [KeyType, ValType]}, Map)
-        when is_map(Map) ->
-    {map, [], [ {translate_vm_value(VmKeyType, KeyType, Key),
-                 translate_vm_value(VmValType, ValType, Val)}
-                || {Key, Val} <- maps:to_list(Map) ]};
-translate_vm_value({variant, VmCons}, {variant_t, Cons}, {variant, Tag, Args})
-        when length(VmCons) == length(Cons),
-             length(VmCons) > Tag ->
-    VmTypes = lists:nth(Tag + 1, VmCons),
-    ConType = lists:nth(Tag + 1, Cons),
-    translate_vm_value(VmTypes, ConType, Args);
-translate_vm_value(VmTypes, {constr_t, _, Con, Types}, Args)
-        when length(VmTypes) == length(Types),
-             length(VmTypes) == length(Args) ->
-    {app, [], Con, [ translate_vm_value(VmType, Type, Arg)
-                     || {VmType, Type, Arg} <- lists:zip3(VmTypes, Types, Args) ]};
-translate_vm_value(_VmType, _Type, _Data) ->
-    throw(cannot_translate_to_sophia).
-
--spec create_calldata(string(), string(), [string()]) ->
                              {ok, binary(), aeso_sophia:type(), aeso_sophia:type()}
-                             | {error, term()}.
+                                 | {error, argument_syntax_error}.
-create_calldata(Code, Fun, Args) ->
+create_calldata(Contract, "", CallCode) when is_map(Contract) ->
-    case check_call(Code, Fun, Args, []) of
+    case check_call(CallCode, []) of
-        {ok, FunName, {ArgTypes, RetType}, VMArgs} ->
+        {ok, FunName, {ArgTypes, RetType}, Args} ->
-            aeso_abi:create_calldata(FunName, VMArgs, ArgTypes, RetType);
+            aeso_abi:create_calldata(Contract, FunName, Args, ArgTypes, RetType);
         {error, _} = Err -> Err
+    end;
+create_calldata(Contract, Function, Argument) when is_map(Contract) ->
+    %% Slightly hacky shortcut to let you get away without writing the full
+    %% call contract code.
+    %% Function should be "foo : type", and
+    %% Argument should be "Arg1, Arg2, .., ArgN" (no parens)
+    case string:lexemes(Function, ": ") of
+        %% If function is a single word fallback to old calldata generation
+        [FunName] -> aeso_abi:old_create_calldata(Contract, FunName, Argument);
+        [FunName | _] ->
+            Args    = lists:map(fun($\n) -> 32; (X) -> X end, Argument),    %% newline to space
+            CallContract = lists:flatten(
+                [ "contract Call =\n"
+                , "  function ", Function, "\n"
+                , "  function __call() = ", FunName, "(", Args, ")"
+                ]),
+            create_calldata(Contract, "", CallContract)
     end.
 
+
 get_arg_icode(Funs) ->
-    case [ Args || {[_, ?CALL_NAME], _, _, {funcall, _, Args}, _} <- Funs ] of
+    [Args] = [ Args || {?CALL_NAME, _, _, {funcall, _, Args}, _} <- Funs ],
-        [Args] -> Args;
+    Args.
-        []     -> error({missing_call_function, Funs})
-    end.
 
 get_call_type([{contract, _, _, Defs}]) ->
-    case [ {lists:last(QFunName), FunType}
+    case [ {FunName, FunType}
           || {letfun, _, {id, _, ?CALL_NAME}, [], _Ret,
                 {typed, _,
                     {app, _,
-                        {typed, _, {qid, _, QFunName}, FunType}, _}, _}} <- Defs ] of
+                        {typed, _, {id, _, FunName}, FunType}, _}, _}} <- Defs ] of
         [Call] -> {ok, Call};
         []     -> {error, missing_call_function}
     end;
@@ -339,18 +177,6 @@ get_call_type([_ | Contracts]) ->
     %% The __call should be in the final contract
     get_call_type(Contracts).
 
-get_decode_type(FunName, [{contract, _, _, Defs}]) ->
-    GetType = fun({letfun, _, {id, _, Name}, _, Ret, _})               when Name == FunName -> [Ret];
-                 ({fun_decl, _, {id, _, Name}, {fun_t, _, _, _, Ret}}) when Name == FunName -> [Ret];
-                 (_) -> [] end,
-    case lists:flatmap(GetType, Defs) of
-        [Type] -> {ok, Type};
-        []     -> {error, missing_function}
-    end;
-get_decode_type(FunName, [_ | Contracts]) ->
-    %% The __decode should be in the final contract
-    get_decode_type(FunName, Contracts).
-
 %% Translate an icode value (error if not value) to an Erlang term that can be
 %% consumed by aeso_heap:to_binary().
 icode_to_term(word, {integer, N}) -> N;
@@ -385,7 +211,10 @@ icode_to_term(T, V) ->
 icodes_to_terms(Ts, Vs) ->
     [ icode_to_term(T, V) || {T, V} <- lists:zip(Ts, Vs) ].
 
-ast_to_icode(TypedAst, Options) ->
+parse(C,_Options) ->
+    parse_string(C).
+
+to_icode(TypedAst, Options) ->
     aeso_ast_to_icode:convert_typed(TypedAst, Options).
 
 assemble(Icode, Options) ->
@@ -399,9 +228,7 @@ to_bytecode([Op|Rest], Options) ->
 to_bytecode([], _) -> [].
 
 extract_type_info(#{functions := Functions} =_Icode) ->
-    ArgTypesOnly = fun(As) -> [ T || {_, T} <- As ] end,
+    TypeInfo = [aeso_abi:function_type_info(list_to_binary(Name), Args, TypeRep)
-    TypeInfo = [aeso_abi:function_type_info(list_to_binary(lists:last(Name)),
-                                            ArgTypesOnly(Args), TypeRep)
                 || {Name, Attrs, Args,_Body, TypeRep} <- Functions,
                    not is_tuple(Name),
                    not lists:member(private, Attrs)
@@ -436,9 +263,9 @@ sophia_type_to_typerep(String) ->
     catch _:_ -> {error, bad_type}
     end.
 
-parse(Text, Options) ->
+parse_string(Text) ->
     %% Try and return something sensible here!
-    case aeso_parser:string(Text, Options) of
+    case aeso_parser:string(Text) of
         %% Yay, it worked!
         {ok, Contract} -> Contract;
         %% Scan errors.
@@ -451,23 +278,12 @@ parse(Text, Options) ->
             parse_error(Pos, Error);
         {error, {Pos, ambiguous_parse, As}} ->
             ErrorString = io_lib:format("Ambiguous ~p", [As]),
-            parse_error(Pos, ErrorString);
+            parse_error(Pos, ErrorString)
-        %% Include error
-        {error, {Pos, include_error, File}} ->
-            parse_error(Pos, io_lib:format("could not find include file '~s'", [File]))
     end.
 
-parse_error(Pos, ErrorString) ->
+parse_error({Line, Pos}, ErrorString) ->
-    Error = io_lib:format("~s: ~s", [pos_error(Pos), ErrorString]),
+    Error = io_lib:format("line ~p, column ~p: ~s", [Line, Pos, ErrorString]),
     error({parse_errors, [Error]}).
 
 read_contract(Name) ->
     file:read_file(Name).
-
-pos_error({Line, Pos}) ->
-    io_lib:format("line ~p, column ~p", [Line, Pos]);
-pos_error({no_file, Line, Pos}) ->
-    pos_error({Line, Pos});
-pos_error({File, Line, Pos}) ->
-    io_lib:format("file ~s, line ~p, column ~p", [File, Line, Pos]).
-

src/aeso_icode.erl

@@ -9,18 +9,7 @@
 %%%-------------------------------------------------------------------
 -module(aeso_icode).
 
--export([new/1,
+-export([new/1, pp/1, set_name/2, set_functions/2, map_typerep/2, option_typerep/1, get_constructor_tag/2]).
-         pp/1,
-         set_name/2,
-         set_namespace/2,
-         enter_namespace/2,
-         get_namespace/1,
-         qualify/2,
-         set_functions/2,
-         map_typerep/2,
-         option_typerep/1,
-         get_constructor_tag/2]).
-
 -export_type([icode/0]).
 
 -include("aeso_icode.hrl").
@@ -40,13 +29,12 @@
 
 -type icode() :: #{ contract_name => string()
                   , functions => [fun_dec()]
-                  , namespace => aeso_syntax:con() | aeso_syntax:qcon()
                   , env => [bindings()]
                   , state_type => aeso_sophia:type()
                   , event_type => aeso_sophia:type()
                   , types => #{ type_name() => type_def() }
                   , type_vars => #{ string() => aeso_sophia:type() }
-                  , constructors => #{ [string()] => integer() }  %% name to tag
+                  , constructors => #{ string() => integer() }  %% name to tag
                   , options => [any()]
                   }.
 
@@ -85,10 +73,10 @@ builtin_types() ->
      }.
 
 builtin_constructors() ->
-    #{ ["RelativeTTL"] => 0
+    #{ "RelativeTTL" => 0
-     , ["FixedTTL"]    => 1
+     , "FixedTTL"    => 1
-     , ["None"]        => 0
+     , "None"        => 0
-     , ["Some"]        => 1 }.
+     , "Some"        => 1 }.
 
 map_typerep(K, V) ->
     {map, K, V}.
@@ -103,30 +91,11 @@ new_env() ->
 set_name(Name, Icode) ->
     maps:put(contract_name, Name, Icode).
 
--spec set_namespace(aeso_syntax:con() | aeso_syntax:qcon(), icode()) -> icode().
-set_namespace(NS, Icode) -> Icode#{ namespace => NS }.
-
--spec enter_namespace(aeso_syntax:con(), icode()) -> icode().
-enter_namespace(NS, Icode = #{ namespace := NS1 }) ->
-    Icode#{ namespace => aeso_syntax:qualify(NS1, NS) };
-enter_namespace(NS, Icode) ->
-    Icode#{ namespace => NS }.
-
--spec get_namespace(icode()) -> false | aeso_syntax:con() | aeso_syntax:qcon().
-get_namespace(Icode) -> maps:get(namespace, Icode, false).
-
--spec qualify(aeso_syntax:id() | aeso_syntax:con(), icode()) -> aeso_syntax:id() | aeso_syntax:qid() | aeso_syntax:con() | aeso_syntax:qcon().
-qualify(X, Icode) ->
-    case get_namespace(Icode) of
-        false -> X;
-        NS    -> aeso_syntax:qualify(NS, X)
-    end.
-
 -spec set_functions([fun_dec()], icode()) -> icode().
 set_functions(NewFuns, Icode) ->
     maps:put(functions, NewFuns, Icode).
 
--spec get_constructor_tag([string()], icode()) -> integer().
+-spec get_constructor_tag(string(), icode()) -> integer().
 get_constructor_tag(Name, #{constructors := Constructors}) ->
     case maps:get(Name, Constructors, undefined) of
         undefined -> error({undefined_constructor, Name});

src/aeso_icode.hrl

@@ -20,7 +20,7 @@
                  , args :: arg_list()
                  , body :: expr()}).
 
--record(var_ref, { name :: string() | list(string()) | {builtin, atom() | tuple()}}).
+-record(var_ref, { name :: string() | {builtin, atom() | tuple()}}).
 
 -record(prim_call_contract,
     { gas      :: expr()

src/aeso_icode_to_asm.erl

@@ -17,7 +17,7 @@
 i(Code) -> aeb_opcodes:mnemonic(Code).
 
 %% We don't track purity or statefulness in the type checker yet.
-is_stateful({FName, _, _, _, _}) -> lists:last(FName) /= "init".
+is_stateful({FName, _, _, _, _}) -> FName /= "init".
 
 is_public({_Name, Attrs, _Args, _Body, _Type}) -> not lists:member(private, Attrs).
 
@@ -105,7 +105,7 @@ make_args(Args) ->
 
 fun_hash({FName, _, Args, _, TypeRep}) ->
     ArgType = {tuple, [T || {_, T} <- Args]},
-    <<Hash:256>> = aeso_abi:function_type_hash(list_to_binary(lists:last(FName)), ArgType, TypeRep),
+    <<Hash:256>> = aeso_abi:function_type_hash(list_to_binary(FName), ArgType, TypeRep),
     {integer, Hash}.
 
 %% Expects two return addresses below N elements on the stack. Picks the top

src/aeso_parse_lib.erl

@@ -19,7 +19,7 @@
 
 -export_type([parser/1, parser_expr/1, pos/0, token/0, tokens/0]).
 
--type pos()    :: {string() | no_file, integer(), integer()} | {integer(), integer()}.
+-type pos()    :: {integer(), integer()}.
 -type token()  :: {atom(), pos(), term()} | {atom(), pos()}.
 -type tokens() :: [token()].
 -type error()  :: {pos(), string() | no_error}.

src/aeso_parser.erl

@@ -5,37 +5,28 @@
 -module(aeso_parser).
 
 -export([string/1,
-         string/2,
          type/1]).
 
 -include("aeso_parse_lib.hrl").
 
--type parse_result() :: {ok, aeso_syntax:ast()}
+-spec string(string()) ->
-                      | {error, {aeso_parse_lib:pos(), atom(), term()}}
+                    {ok, aeso_syntax:ast()}
-                      | {error, {aeso_parse_lib:pos(), atom()}}.
+                        | {error, {aeso_parse_lib:pos(),
-
+                                   atom(),
--spec string(string()) -> parse_result().
+                                   term()}}
+                        | {error, {aeso_parse_lib:pos(),
+                                   atom()}}.
 string(String) ->
-    string(String, []).
+  parse_and_scan(file(), String).
-
--spec string(string(), aeso_compiler:options()) -> parse_result().
-string(String, Opts) ->
-    case parse_and_scan(file(), String, Opts) of
-        {ok, AST} ->
-            expand_includes(AST, Opts);
-        Err = {error, _} ->
-            Err
-    end.
 
 type(String) ->
-    parse_and_scan(type(), String, []).
+  parse_and_scan(type(), String).
 
-parse_and_scan(P, S, Opts) ->
+parse_and_scan(P, S) ->
-    set_current_file(proplists:get_value(src_file, Opts, no_file)),
+  case aeso_scan:scan(S) of
-    case aeso_scan:scan(S) of
+    {ok, Tokens} -> aeso_parse_lib:parse(P, Tokens);
-        {ok, Tokens} -> aeso_parse_lib:parse(P, Tokens);
+    Error        -> Error
-        Error        -> Error
+  end.
-    end.
 
 %% -- Parsing rules ----------------------------------------------------------
 
@@ -45,9 +36,7 @@ decl() ->
     ?LAZY_P(
     choice(
       %% Contract declaration
-    [ ?RULE(keyword(contract),  con(), tok('='), maybe_block(decl()), {contract, _1, _2, _4})
+    [ ?RULE(keyword(contract), con(), tok('='), maybe_block(decl()), {contract, _1, _2, _4})
-    , ?RULE(keyword(namespace), con(), tok('='), maybe_block(decl()), {namespace, _1, _2, _4})
-    , ?RULE(keyword(include),   str(), {include, _2})
 
       %% Type declarations  TODO: format annotation for "type bla" vs "type bla()"
     , ?RULE(keyword(type),     id(),                                          {type_decl, _1, _2, []})
@@ -68,14 +57,9 @@ decl() ->
 modifiers() ->
     many(choice([token(stateful), token(public), token(private), token(internal)])).
 
-add_modifiers([], Node) -> Node;
+add_modifiers(Mods, Node) ->
-add_modifiers(Mods = [Tok | _], Node) ->
+    lists:foldl(fun({Mod, _}, X) -> set_ann(Mod, true, X) end,
-    %% Set the position to the position of the first modifier. This is
+                Node, Mods).
-    %% important for code transformation tools (like what we do in
-    %% create_calldata) to be able to get the indentation of the declaration.
-    set_pos(get_pos(Tok),
-        lists:foldl(fun({Mod, _}, X) -> set_ann(Mod, true, X) end,
-                    Node, Mods)).
 
 %% -- Type declarations ------------------------------------------------------
 
@@ -317,7 +301,6 @@ binop(Ops) ->
 con()      -> token(con).
 id()       -> token(id).
 tvar()     -> token(tvar).
-str()      -> token(string).
 
 token(Tag) ->
     ?RULE(tok(Tag),
@@ -353,17 +336,10 @@ bracket_list(P) -> brackets(comma_sep(P)).
 -type ann_col()  :: aeso_syntax:ann_col().
 
 -spec pos_ann(ann_line(), ann_col()) -> ann().
-pos_ann(Line, Col) -> [{file, current_file()}, {line, Line}, {col, Col}].
+pos_ann(Line, Col) -> [{line, Line}, {col, Col}].
-
-current_file() ->
-    get('$current_file').
-
-set_current_file(File) ->
-    put('$current_file', File).
 
 ann_pos(Ann) ->
-    {proplists:get_value(file, Ann),
+    {proplists:get_value(line, Ann),
-     proplists:get_value(line, Ann),
      proplists:get_value(col, Ann)}.
 
 get_ann(Ann) when is_list(Ann) -> Ann;
@@ -381,10 +357,10 @@ set_ann(Key, Val, Node) ->
     setelement(2, Node, lists:keystore(Key, 1, Ann, {Key, Val})).
 
 get_pos(Node) ->
-    {current_file(), get_ann(line, Node), get_ann(col, Node)}.
+    {get_ann(line, Node), get_ann(col, Node)}.
 
-set_pos({F, L, C}, Node) ->
+set_pos({L, C}, Node) ->
-    set_ann(file, F, set_ann(line, L, set_ann(col, C, Node))).
+    set_ann(line, L, set_ann(col, C, Node)).
 
 infix(L, Op, R) -> set_ann(format, infix,  {app, get_ann(L), Op, [L, R]}).
 
@@ -466,10 +442,8 @@ parse_pattern(E) -> bad_expr_err("Not a valid pattern", E).
 parse_field_pattern({field, Ann, F, E}) ->
     {field, Ann, F, parse_pattern(E)}.
 
-return_error({no_file, L, C}, Err) ->
+return_error({L, C}, Err) ->
-    fail(io_lib:format("~p:~p:\n~s", [L, C, Err]));
+    fail(io_lib:format("~p:~p:\n~s", [L, C, Err])).
-return_error({F, L, C}, Err) ->
-    fail(io_lib:format("In ~s at ~p:~p:\n~s", [F, L, C, Err])).
 
 -spec ret_doc_err(ann(), prettypr:document()) -> no_return().
 ret_doc_err(Ann, Doc) ->
@@ -481,38 +455,3 @@ bad_expr_err(Reason, E) ->
               prettypr:sep([prettypr:text(Reason ++ ":"),
                             prettypr:nest(2, aeso_pretty:expr(E))])).
 
-%% -- Helper functions -------------------------------------------------------
-expand_includes(AST, Opts) ->
-    expand_includes(AST, [], Opts).
-
-expand_includes([], Acc, _Opts) ->
-    {ok, lists:reverse(Acc)};
-expand_includes([{include, S = {string, _, File}} | AST], Acc, Opts) ->
-    case read_file(File, Opts) of
-        {ok, Bin} ->
-            Opts1 = lists:keystore(src_file, 1, Opts, {src_file, File}),
-            case string(binary_to_list(Bin), Opts1) of
-                {ok, AST1} ->
-                    expand_includes(AST1 ++ AST, Acc, Opts);
-                Err = {error, _} ->
-                    Err
-            end;
-        {error, _} ->
-            {error, {get_pos(S), include_error, File}}
-    end;
-expand_includes([E | AST], Acc, Opts) ->
-    expand_includes(AST, [E | Acc], Opts).
-
-read_file(File, Opts) ->
-    case proplists:get_value(include, Opts, {explicit_files, #{}}) of
-        {file_system, Paths} ->
-            CandidateNames = [ filename:join(Dir, File) || Dir <- Paths ],
-            lists:foldr(fun(F, {error, _}) -> file:read_file(F);
-                           (_F, OK) -> OK end, {error, not_found}, CandidateNames);
-        {explicit_files, Files} ->
-            case maps:get(binary_to_list(File), Files, not_found) of
-                not_found -> {error, not_found};
-                Src       -> {ok, Src}
-            end
-    end.
-

src/aeso_pretty.erl

@@ -147,8 +147,6 @@ decl(D, Options) ->
 -spec decl(aeso_syntax:decl()) -> doc().
 decl({contract, _, C, Ds}) ->
     block(follow(text("contract"), hsep(name(C), text("="))), decls(Ds));
-decl({namespace, _, C, Ds}) ->
-    block(follow(text("namespace"), hsep(name(C), text("="))), decls(Ds));
 decl({type_decl, _, T, Vars}) -> typedecl(alias_t, T, Vars);
 decl({type_def, _, T, Vars, Def}) ->
     Kind = element(1, Def),
@@ -236,10 +234,8 @@ type({app_t, _, Type, Args}) ->
     beside(type(Type), tuple_type(Args));
 type({tuple_t, _, Args}) ->
     tuple_type(Args);
-type({named_arg_t, _, Name, Type, _Default}) ->
+type({named_arg_t, _, Name, Type, Default}) ->
-    %% Drop the default value
+    follow(hsep(typed(name(Name), Type), text("=")), expr(Default));
-    %% follow(hsep(typed(name(Name), Type), text("=")), expr(Default));
-    typed(name(Name), Type);
 
 type(R = {record_t, _}) -> typedef(R);
 type(T = {id, _, _})   -> name(T);
@@ -307,8 +303,6 @@ expr_p(P, E = {app, _, F = {Op, _}, Args}) when is_atom(Op) ->
         {prefix, [A]}   -> prefix(P, Op, A);
         _               -> app(P, F, Args)
     end;
-expr_p(_, {app, _, C={Tag, _, _}, []}) when Tag == con; Tag == qcon ->
-    expr_p(0, C);
 expr_p(P, {app, _, F, Args}) ->
     app(P, F, Args);
 %% -- Constants
@@ -320,7 +314,6 @@ expr_p(_, E = {int, _, N}) ->
     text(S);
 expr_p(_, {bool, _, B}) -> text(atom_to_list(B));
 expr_p(_, {hash, _, <<N:256>>}) -> text("#" ++ integer_to_list(N, 16));
-expr_p(_, {hash, _, <<N:512>>}) -> text("#" ++ integer_to_list(N, 16));
 expr_p(_, {unit, _}) -> text("()");
 expr_p(_, {string, _, S}) -> term(binary_to_list(S));
 expr_p(_, {char, _, C}) ->

src/aeso_scan.erl

@@ -36,8 +36,8 @@ lexer() ->
         , {"\\*/",        pop(skip())}
         , {"[^/*]+|[/*]", skip()} ],
 
-    Keywords = ["contract", "include", "let", "rec", "switch", "type", "record", "datatype", "if", "elif", "else", "function",
+    Keywords = ["contract", "import", "let", "rec", "switch", "type", "record", "datatype", "if", "elif", "else", "function",
-                "stateful", "true", "false", "and", "mod", "public", "private", "indexed", "internal", "namespace"],
+                "stateful", "true", "false", "and", "mod", "public", "private", "indexed", "internal"],
     KW = string:join(Keywords, "|"),
 
     Rules =

src/aeso_syntax.erl

@@ -8,14 +8,14 @@
 
 -module(aeso_syntax).
 
--export([get_ann/1, get_ann/2, get_ann/3, set_ann/2, qualify/2]).
+-export([get_ann/1, get_ann/2, get_ann/3, set_ann/2]).
 
 -export_type([ann_line/0, ann_col/0, ann_origin/0, ann_format/0, ann/0]).
 -export_type([name/0, id/0, con/0, qid/0, qcon/0, tvar/0, op/0]).
 -export_type([bin_op/0, un_op/0]).
 -export_type([decl/0, letbind/0, typedef/0]).
--export_type([arg/0, field_t/0, constructor_t/0, named_arg_t/0]).
+-export_type([arg/0, field_t/0, constructor_t/0]).
--export_type([type/0, constant/0, expr/0, arg_expr/0, field/1, stmt/0, alt/0, lvalue/0, elim/0, pat/0]).
+-export_type([type/0, constant/0, expr/0, arg_expr/0, field/1, stmt/0, alt/0, lvalue/0, pat/0]).
 -export_type([ast/0]).
 
 -type ast() :: [decl()].
@@ -35,7 +35,6 @@
 -type tvar() :: {tvar, ann(), name()}.
 
 -type decl() :: {contract, ann(), con(), [decl()]}
-              | {namespace, ann(), con(), [decl()]}
               | {type_decl, ann(), id(), [tvar()]}
               | {type_def, ann(), id(), [tvar()], typedef()}
               | {fun_decl, ann(), id(), type()}
@@ -141,8 +140,3 @@ get_ann(Key, Node) ->
 
 get_ann(Key, Node, Default) ->
     proplists:get_value(Key, get_ann(Node), Default).
-
-qualify({con, Ann, N}, X)             -> qualify({qcon, Ann, [N]}, X);
-qualify({qcon, _, NS}, {con, Ann, C}) -> {qcon, Ann, NS ++ [C]};
-qualify({qcon, _, NS}, {id, Ann, X})  -> {qid, Ann, NS ++ [X]}.
-

src/aeso_syntax_utils.erl

@@ -6,142 +6,89 @@
 %%%-------------------------------------------------------------------
 -module(aeso_syntax_utils).
 
--export([used_ids/1, used_types/1, used/1]).
+-export([used_ids/1, used_types/1]).
 
--record(alg, {zero, plus, scoped}).
+%% Var set combinators
+none()           -> [].
+one(X)           -> [X].
+union_map(F, Xs) -> lists:umerge(lists:map(F, Xs)).
+minus(Xs, Ys)    -> Xs -- Ys.
 
--type alg(A) :: #alg{ zero   :: A
+%% Compute names used by a definition or expression.
-                    , plus   :: fun((A, A) -> A)
+used_ids(Es) when is_list(Es) ->
-                    , scoped :: fun((A, A) -> A) }.
+    union_map(fun used_ids/1, Es);
+used_ids({bind, A, B}) ->
+    minus(used_ids(B), used_ids(A));
+%% Declarations
+used_ids({contract, _, _, Decls})    -> used_ids(Decls);
+used_ids({type_decl, _, _, _})       -> none();
+used_ids({type_def, _, _, _, _})     -> none();
+used_ids({fun_decl, _, _, _})        -> none();
+used_ids({letval, _, _, _, E})       -> used_ids(E);
+used_ids({letfun, _, _, Args, _, E}) -> used_ids({bind, Args, E});
+used_ids({letrec, _, Decls})         -> used_ids(Decls);
+%% Args
+used_ids({arg, _, X, _}) -> used_ids(X);
+used_ids({named_arg, _, _, E}) -> used_ids(E);
+%% Constants
+used_ids({int, _, _})    -> none();
+used_ids({bool, _, _})   -> none();
+used_ids({hash, _, _})   -> none();
+used_ids({unit, _})      -> none();
+used_ids({string, _, _}) -> none();
+used_ids({char, _, _})   -> none();
+%% Expressions
+used_ids({lam, _, Args, E})  -> used_ids({bind, Args, E});
+used_ids({'if', _, A, B, C}) -> used_ids([A, B, C]);
+used_ids({switch, _, E, Bs}) -> used_ids([E, Bs]);
+used_ids({app, _, E, Es})    -> used_ids([E | Es]);
+used_ids({proj, _, E, _})    -> used_ids(E);
+used_ids({tuple, _, Es})     -> used_ids(Es);
+used_ids({list, _, Es})      -> used_ids(Es);
+used_ids({typed, _, E, _})   -> used_ids(E);
+used_ids({record, _, Fs})    -> used_ids(Fs);
+used_ids({record, _, E, Fs}) -> used_ids([E, Fs]);
+used_ids({map, _, E, Fs})    -> used_ids([E, Fs]);
+used_ids({map, _, KVs})      -> used_ids([ [K, V] || {K, V} <- KVs ]);
+used_ids({map_get, _, M, K}) -> used_ids([M, K]);
+used_ids({map_get, _, M, K, V}) -> used_ids([M, K, V]);
+used_ids({block, _, Ss})     -> used_ids_s(Ss);
+used_ids({Op, _}) when is_atom(Op) -> none();
+used_ids({id, _, X})   -> [X];
+used_ids({qid, _, _})  -> none();
+used_ids({con, _, _})  -> none();
+used_ids({qcon, _, _}) -> none();
+%% Switch branches
+used_ids({'case', _, P, E}) -> used_ids({bind, P, E});
+%% Fields
+used_ids({field, _, LV, E})    -> used_ids([LV, E]);
+used_ids({field, _, LV, X, E}) -> used_ids([LV, {bind, X, E}]);
+used_ids({proj, _, _})         -> none();
+used_ids({map_get, _, E})      -> used_ids(E).
 
--type kind() :: decl | type | bind_type | expr | bind_expr.
+%% Statements
+used_ids_s([])       -> none();
+used_ids_s([S | Ss]) ->
+    used_ids([S, {bind, bound_ids(S), {block, [], Ss}}]).
 
--spec fold(alg(A), fun((kind(), _) -> A), kind(), E | [E]) -> A
+bound_ids({letval, _, X, _, _})    -> one(X);
-    when E :: aeso_syntax:decl()
+bound_ids({letfun, _, X, _, _, _}) -> one(X);
-            | aeso_syntax:typedef()
+bound_ids({letrec, _, Decls})      -> union_map(fun bound_ids/1, Decls);
-            | aeso_syntax:field_t()
+bound_ids(_)                       -> none().
-            | aeso_syntax:constructor_t()
-            | aeso_syntax:type()
-            | aeso_syntax:expr()
-            | aeso_syntax:pat()
-            | aeso_syntax:arg()
-            | aeso_syntax:alt()
-            | aeso_syntax:elim()
-            | aeso_syntax:arg_expr()
-            | aeso_syntax:field(aeso_syntax:expr())
-            | aeso_syntax:stmt().
-fold(Alg = #alg{zero = Zero, plus = Plus, scoped = Scoped}, Fun, K, X) ->
-    Sum  = fun(Xs) -> lists:foldl(Plus, Zero, Xs) end,
-    Same = fun(A) -> fold(Alg, Fun, K, A) end,
-    Decl = fun(D) -> fold(Alg, Fun, decl, D) end,
-    Type = fun(T) -> fold(Alg, Fun, type, T) end,
-    Expr = fun(E) -> fold(Alg, Fun, expr, E) end,
-    BindExpr = fun(P) -> fold(Alg, Fun, bind_expr, P) end,
-    BindType = fun(T) -> fold(Alg, Fun, bind_type, T) end,
-    Top = Fun(K, X),
-    Bound = fun LB ({letval, _, Y, _, _})    -> BindExpr(Y);
-                LB ({letfun, _, F, _, _, _}) -> BindExpr(F);
-                LB ({letrec, _, Ds})         -> Sum(lists:map(LB, Ds));
-                LB (_)                       -> Zero
-            end,
-    Rec = case X of
-            %% lists (bound things in head scope over tail)
-            [A | As]                 -> Scoped(Same(A), Same(As));
-            %% decl()
-            {contract, _, _, Ds}     -> Decl(Ds);
-            {namespace, _, _, Ds}    -> Decl(Ds);
-            {type_decl, _, I, _}     -> BindType(I);
-            {type_def, _, I, _, D}   -> Plus(BindType(I), Decl(D));
-            {fun_decl, _, _, T}      -> Type(T);
-            {letval, _, F, T, E}     -> Sum([BindExpr(F), Type(T), Expr(E)]);
-            {letfun, _, F, Xs, T, E} -> Sum([BindExpr(F), Type(T), Scoped(BindExpr(Xs), Expr(E))]);
-            {letrec, _, Ds}          -> Plus(Bound(Ds), Decl(Ds));
-            %% typedef()
-            {alias_t, T}    -> Type(T);
-            {record_t, Fs}  -> Type(Fs);
-            {variant_t, Cs} -> Type(Cs);
-            %% field_t() and constructor_t()
-            {field_t, _, _, T}   -> Type(T);
-            {constr_t, _, _, Ts} -> Type(Ts);
-            %% type()
-            {fun_t, _, Named, Args, Ret} -> Type([Named, Args, Ret]);
-            {app_t, _, T, Ts}            -> Type([T | Ts]);
-            {tuple_t, _, Ts}             -> Type(Ts);
-            %% named_arg_t()
-            {named_arg_t, _, _, T, E} -> Plus(Type(T), Expr(E));
-            %% expr()
-            {lam, _, Args, E}      -> Scoped(BindExpr(Args), Expr(E));
-            {'if', _, A, B, C}     -> Expr([A, B, C]);
-            {switch, _, E, Alts}   -> Expr([E, Alts]);
-            {app, _, A, As}        -> Expr([A | As]);
-            {proj, _, E, _}        -> Expr(E);
-            {tuple, _, As}         -> Expr(As);
-            {list, _, As}          -> Expr(As);
-            {typed, _, E, T}       -> Plus(Expr(E), Type(T));
-            {record, _, Fs}        -> Expr(Fs);
-            {record, _, E, Fs}     -> Expr([E | Fs]);
-            {map, _, E, Fs}        -> Expr([E | Fs]);
-            {map, _, KVs}          -> Sum([Expr([Key, Val]) || {Key, Val} <- KVs]);
-            {map_get, _, A, B}     -> Expr([A, B]);
-            {map_get, _, A, B, C}  -> Expr([A, B, C]);
-            {block, _, Ss}         -> Expr(Ss);
-            %% field()
-            {field, _, LV, E}    -> Expr([LV, E]);
-            {field, _, LV, _, E} -> Expr([LV, E]);
-            %% arg()
-            {arg, _, X, T} -> Plus(Expr(X), Type(T));
-            %% alt()
-            {'case', _, P, E} -> Scoped(BindExpr(P), Expr(E));
-            %% elim()
-            {proj, _, _}    -> Zero;
-            {map_get, _, E} -> Expr(E);
-            %% arg_expr()
-            {named_arg, _, _, E} -> Expr(E);
-            _ -> Alg#alg.zero
-          end,
-    (Alg#alg.plus)(Top, Rec).
-
-%% Name dependencies
-
-used_ids(E) ->
-    [ X || {term, [X]} <- used(E) ].
-
-used_types(T) ->
-    [ X || {type, [X]} <- used(T) ].
-
--type entity() :: {term, [string()]}
-                | {type, [string()]}
-                | {namespace, [string()]}.
-
--spec entity_alg() -> alg([entity()]).
-entity_alg() ->
-    IsBound = fun({K, _}) -> lists:member(K, [bound_term, bound_type]) end,
-    Unbind  = fun(bound_term) -> term; (bound_type) -> type end,
-    Scoped = fun(Xs, Ys) ->
-                {Bound, Others} = lists:partition(IsBound, Ys),
-                Bound1 = [ {Unbind(Tag), X} || {Tag, X} <- Bound ],
-                lists:umerge(Xs -- Bound1, Others)
-            end,
-    #alg{ zero   = []
-        , plus   = fun lists:umerge/2
-        , scoped = Scoped }.
-
--spec used(_) -> [entity()].
-used(D) ->
-    Kind = fun(expr)      -> term;
-              (bind_expr) -> bound_term;
-              (type)      -> type;
-              (bind_type) -> bound_type
-           end,
-    NS = fun(Xs) -> {namespace, lists:droplast(Xs)} end,
-    NotBound = fun({Tag, _}) -> not lists:member(Tag, [bound_term, bound_type]) end,
-    Xs =
-        fold(entity_alg(),
-            fun(K, {id,   _, X})  -> [{Kind(K), [X]}];
-               (K, {qid,  _, Xs}) -> [{Kind(K), Xs}, NS(Xs)];
-               (K, {con,  _, X})  -> [{Kind(K), [X]}];
-               (K, {qcon, _, Xs}) -> [{Kind(K), Xs}, NS(Xs)];
-               (_, _)             -> []
-            end, decl, D),
-    lists:filter(NotBound, Xs).
 
+used_types(Ts) when is_list(Ts)    -> union_map(fun used_types/1, Ts);
+used_types({type_def, _, _, _, T}) -> used_types(T);
+used_types({alias_t, T})           -> used_types(T);
+used_types({record_t, Fs})         -> used_types(Fs);
+used_types({variant_t, Cs})        -> used_types(Cs);
+used_types({field_t, _, _, T})     -> used_types(T);
+used_types({constr_t, _, _, Ts})   -> used_types(Ts);
+used_types({fun_t, _, Named, Args, T}) -> used_types([T | Named ++ Args]);
+used_types({named_arg_t, _, _, T, _}) -> used_types(T);
+used_types({app_t, _, T, Ts})      -> used_types([T | Ts]);
+used_types({tuple_t, _, Ts})       -> used_types(Ts);
+used_types({id, _, X})             -> one(X);
+used_types({qid, _, _})            -> none();
+used_types({con, _, _})            -> none();
+used_types({qcon, _, _})           -> none();
+used_types({tvar, _, _})           -> none().

src/aesophia.app.src

@@ -1,11 +1,10 @@
 {application, aesophia,
  [{description, "Contract Language for Aethernity"},
-  {vsn, {cmd, "cat VERSION | tr -d '[:space:]'"}},
+  {vsn, "1.2.0"},
   {registered, []},
   {applications,
    [kernel,
     stdlib,
-    jsx,
     syntax_tools,
     getopt,
     aebytecode

src/aesophia.erl

@@ -4,7 +4,6 @@
 
 -define(OPT_SPEC,
     [ {src_file, undefined, undefined, string, "Sophia source code file"}
-    , {version, $V, "version", undefined, "Print compiler version"}
     , {verbose, $v, "verbose", undefined, "Verbose output"}
     , {help, $h, "help", undefined, "Show this message"}
     , {outfile, $o, "out", string, "Output file (experimental)"} ]).
@@ -15,13 +14,11 @@ usage() ->
 main(Args) ->
     case getopt:parse(?OPT_SPEC, Args) of
         {ok, {Opts, []}} ->
-            case Opts of
+            case proplists:get_value(help, Opts, false) of
-                [version] ->
+                false ->
-                    print_vsn();
+                    compile(Opts);
-                [help] ->
+                true ->
-                    usage();
+                    usage()
-                _ ->
-                    compile(Opts)
             end;
 
         {ok, {_, NonOpts}} ->
@@ -72,7 +69,3 @@ write_outfile(Out, ResMap)  ->
     %% Lazy approach
     file:write_file(Out, term_to_binary(ResMap)),
     io:format("Output written to: ~s\n", [Out]).
-
-print_vsn() ->
-    {ok, Vsn} = aeso_compiler:version(),
-    io:format("Compiler version: ~s\n", [Vsn]).

test/aeso_abi_tests.erl

@@ -54,115 +54,27 @@ encode_decode_test() ->
     ok.
 
 encode_decode_sophia_test() ->
-    Check = fun(Type, Str) -> case {encode_decode_sophia_string(Type, Str), Str} of
+    {42} = encode_decode_sophia_string("int", "42"),
-                                {X, X} -> ok;
+    {1} = encode_decode_sophia_string("bool", "true"),
-                                Other -> Other
+    {0} = encode_decode_sophia_string("bool", "false"),
-                              end end,
+    {<<"Hello">>} = encode_decode_sophia_string("string", "\"Hello\""),
-    ok = Check("int", "42"),
+    {<<"Hello">>, [1,2,3], {variant, 1, [1]}} =
-    ok = Check("bool", "true"),
+        encode_decode_sophia_string(
-    ok = Check("bool", "false"),
+          "(string, list(int), option(bool))",
-    ok = Check("string", "\"Hello\""),
+          "\"Hello\", [1,2,3], Some(true)"),
-    ok = Check("(string, list(int), option(bool))",
-               "(\"Hello\", [1, 2, 3], Some(true))"),
-    ok = Check("variant", "Blue({[\"x\"] = 1})"),
-    ok = Check("r", "{x = (\"foo\", 0), y = Red}"),
     ok.
 
 encode_decode_sophia_string(SophiaType, String) ->
     io:format("String ~p~n", [String]),
-    Code = [ "contract MakeCall =\n"
+    Code = [ "contract Call =\n"
-           , "  type arg_type = ", SophiaType, "\n"
+           , "  function foo : ", SophiaType, " => _\n"
-           , "  type an_alias('a) = (string, 'a)\n"
+           , "  function __call() = foo(", String, ")\n" ],
-           , "  record r = {x : an_alias(int), y : variant}\n"
+    {ok, _, {Types, _}, Args} = aeso_compiler:check_call(lists:flatten(Code), []),
-           , "  datatype variant = Red | Blue(map(string, int))\n"
+    Arg  = list_to_tuple(Args),
-           , "  function foo : arg_type => arg_type\n" ],
+    Type = {tuple, Types},
-    case aeso_compiler:check_call(lists:flatten(Code), "foo", [String], []) of
+    io:format("Type ~p~n", [Type]),
-        {ok, _, {[Type], _}, [Arg]} ->
+    Data = encode(Arg),
-            io:format("Type ~p~n", [Type]),
+    decode(Type, Data).
-            Data = encode(Arg),
-            case aeso_compiler:to_sophia_value(Code, "foo", ok, Data) of
-                {ok, Sophia} ->
-                    lists:flatten(io_lib:format("~s", [prettypr:format(aeso_pretty:expr(Sophia))]));
-                {error, Err} ->
-                    io:format("~s\n", [Err]),
-                    {error, Err}
-            end;
-        {error, Err} ->
-            io:format("~s\n", [Err]),
-            {error, Err}
-    end.
-
-calldata_test() ->
-    [42, <<"foobar">>] = encode_decode_calldata("foo", ["int", "string"], ["42", "\"foobar\""]),
-    Map = #{ <<"a">> => 4 },
-    [{variant, 1, [Map]}, {{<<"b">>, 5}, {variant, 0, []}}] =
-        encode_decode_calldata("foo", ["variant", "r"], ["Blue({[\"a\"] = 4})", "{x = (\"b\", 5), y = Red}"]),
-    [16#123, 16#456] = encode_decode_calldata("foo", ["hash", "address"], ["#123", "#456"]),
-    ok.
-
-calldata_init_test() ->
-    encode_decode_calldata("init", ["int"], ["42"], {tuple, [typerep, word]}),
-
-    Code = parameterized_contract("foo", ["int"]),
-    encode_decode_calldata_(Code, "init", [], {tuple, [typerep, {tuple, []}]}).
-
-calldata_indent_test() ->
-    Test = fun(Extra) ->
-            encode_decode_calldata_(
-                parameterized_contract(Extra, "foo", ["int"]),
-                "foo", ["42"], word)
-           end,
-    Test("  stateful function bla() = ()"),
-    Test("  type x = int"),
-    Test("  private function bla : int => int"),
-    Test("  public stateful function bla(x : int) =\n"
-         "    x + 1"),
-    Test("  stateful private function bla(x : int) : int =\n"
-         "    x + 1"),
-    ok.
-
-parameterized_contract(FunName, Types) ->
-    parameterized_contract([], FunName, Types).
-
-parameterized_contract(ExtraCode, FunName, Types) ->
-    lists:flatten(
-        ["contract Dummy =\n",
-         ExtraCode, "\n",
-         "  type an_alias('a) = (string, 'a)\n"
-         "  record r = {x : an_alias(int), y : variant}\n"
-         "  datatype variant = Red | Blue(map(string, int))\n"
-         "  function ", FunName, " : (", string:join(Types, ", "), ") => int\n" ]).
-
-oracle_test() ->
-    Contract =
-        "contract OracleTest =\n"
-        "  function question(o, q : oracle_query(list(string), option(int))) =\n"
-        "    Oracle.get_question(o, q)\n",
-    {ok, _, {[word, word], {list, string}}, [16#123, 16#456]} =
-        aeso_compiler:check_call(Contract, "question", ["#123", "#456"], []),
-    ok.
-
-permissive_literals_fail_test() ->
-    Contract =
-        "contract OracleTest =\n"
-        "  function haxx(o : oracle(list(string), option(int))) =\n"
-        "    Chain.spend(o, 1000000)\n",
-        {error, <<"Type errors\nCannot unify", _/binary>>} =
-            aeso_compiler:check_call(Contract, "haxx", ["#123"], []),
-    ok.
-
-encode_decode_calldata(FunName, Types, Args) ->
-    encode_decode_calldata(FunName, Types, Args, word).
-
-encode_decode_calldata(FunName, Types, Args, RetType) ->
-    Code = parameterized_contract(FunName, Types),
-    encode_decode_calldata_(Code, FunName, Args, RetType).
-
-encode_decode_calldata_(Code, FunName, Args, RetVMType) ->
-    {ok, Calldata, CalldataType, RetVMType1} = aeso_compiler:create_calldata(Code, FunName, Args),
-    ?assertEqual(RetVMType1, RetVMType),
-    {ok, {_Hash, ArgTuple}} = aeso_heap:from_binary(CalldataType, Calldata),
-    tuple_to_list(ArgTuple).
 
 encode_decode(T, D) ->
     ?assertEqual(D, decode(T, encode(D))),

test/aeso_aci_tests.erl

@@ -1,45 +0,0 @@
--module(aeso_aci_tests).
-
--include_lib("eunit/include/eunit.hrl").
-
-
-do_test() ->
-    test_contract(1),
-    test_contract(2).
-
-test_contract(N) ->
-    {Contract,DecACI} = test_cases(N),
-    {ok,Enc} = aeso_aci:encode(Contract),
-    ?assertEqual(DecACI, jsx:decode(Enc)).
-
-test_cases(1) ->
-    Contract = <<"contract C =\n"
-		 "  function a(i : int) = i+1\n">>,
-    DecodedACI = [{<<"contract">>,
-		   [{<<"name">>,<<"C">>},
-		    {<<"type_defs">>,[]},
-		    {<<"functions">>,
-		     [[{<<"name">>,<<"a">>},
-		       {<<"arguments">>,
-			[[{<<"name">>,<<"i">>},{<<"type">>,<<"int">>}]]},
-		       {<<"type">>,<<"int">>},
-		       {<<"stateful">>,false}]]}]}],
-    {Contract,DecodedACI};
-
-test_cases(2) ->
-    Contract = <<"contract C =\n"
-		 "  type allan = int\n"
-		 "  function a(i : allan) = i+1\n">>,
-    DecodedACI = [{<<"contract">>,
-		   [{<<"name">>,<<"C">>},
-		    {<<"type_defs">>,
-		     [[{<<"name">>,<<"allan">>},
-		       {<<"vars">>,[]},
-		       {<<"typedef">>,<<"int">>}]]},
-		    {<<"functions">>,
-		     [[{<<"name">>,<<"a">>},
-		       {<<"arguments">>,
-			[[{<<"name">>,<<"i">>},{<<"type">>,<<"int">>}]]},
-		       {<<"type">>,<<"int">>},
-		       {<<"stateful">>,false}]]}]}],
-    {Contract,DecodedACI}.

test/aeso_compiler_tests.erl

@@ -10,10 +10,15 @@
 
 -include_lib("eunit/include/eunit.hrl").
 
+%% simple_compile_test_() -> ok.
 %%  Very simply test compile the given contracts. Only basic checks
 %%  are made on the output, just that it is a binary which indicates
 %%  that the compilation worked.
+
 simple_compile_test_() ->
+    {setup,
+     fun () -> ok end,                          %Setup
+     fun (_) -> ok end,                         %Cleanup
      [ {"Testing the " ++ ContractName ++ " contract",
         fun() ->
             #{byte_code := ByteCode,
@@ -23,34 +28,11 @@ simple_compile_test_() ->
         end} || ContractName <- compilable_contracts() ] ++
      [ {"Testing error messages of " ++ ContractName,
         fun() ->
-            case compile(ContractName) of
+            <<"Type errors\n",ErrorString/binary>> = compile(ContractName),
-                <<"Type errors\n", ErrorString/binary>> ->
+            check_errors(lists:sort(ExpectedErrors), ErrorString)
-                    check_errors(lists:sort(ExpectedErrors), ErrorString);
-                <<"Parse errors\n", ErrorString/binary>> ->
-                    check_errors(lists:sort(ExpectedErrors), ErrorString)
-            end
         end} ||
-            {ContractName, ExpectedErrors} <- failing_contracts() ] ++
+            {ContractName, ExpectedErrors} <- failing_contracts() ]
-     [ {"Testing include with explicit files",
+    }.
-        fun() ->
-            FileSystem = maps:from_list(
-                [ begin
-                    {ok, Bin} = file:read_file(filename:join([aeso_test_utils:contract_path(), File])),
-                    {File, Bin}
-                  end || File <- ["included.aes", "../contracts/included2.aes"] ]),
-            #{byte_code := Code1} = compile("include", [{include, {explicit_files, FileSystem}}]),
-            #{byte_code := Code2} = compile("include"),
-            ?assertMatch(true, Code1 == Code2)
-        end} ] ++
-     [ {"Testing deadcode elimination",
-        fun() ->
-            #{ byte_code := NoDeadCode } = compile("nodeadcode"),
-            #{ byte_code := DeadCode   } = compile("deadcode"),
-            SizeNoDeadCode = byte_size(NoDeadCode),
-            SizeDeadCode   = byte_size(DeadCode),
-            ?assertMatch({_, _, true}, {SizeDeadCode, SizeNoDeadCode, SizeDeadCode + 40 < SizeNoDeadCode}),
-            ok
-        end} ].
 
 check_errors(Expect, ErrorString) ->
     %% This removes the final single \n as well.
@@ -62,13 +44,10 @@ check_errors(Expect, ErrorString) ->
     end.
 
 compile(Name) ->
-    compile(Name, [{include, {file_system, [aeso_test_utils:contract_path()]}}]).
-
-compile(Name, Options) ->
     String = aeso_test_utils:read_contract(Name),
-    case aeso_compiler:from_string(String, [{src_file, Name} | Options]) of
+    case aeso_compiler:from_string(String, []) of
-        {ok, Map}            -> Map;
+        {ok,Map} -> Map;
-        {error, ErrorString} -> ErrorString
+        {error,ErrorString} -> ErrorString
     end.
 
 %% compilable_contracts() -> [ContractName].
@@ -91,13 +70,7 @@ compilable_contracts() ->
      "stack",
      "test",
      "builtin_bug",
-     "builtin_map_get_bug",
+     "builtin_map_get_bug"
-     "nodeadcode",
-     "deadcode",
-     "variant_types",
-     "state_handling",
-     "events",
-     "include"
     ].
 
 %% Contracts that should produce type errors
@@ -177,11 +150,11 @@ failing_contracts() ->
         <<"Ambiguous record type with field y (at line 13, column 25) could be one of\n"
           "  - r (at line 4, column 10)\n"
           "  - r' (at line 5, column 10)">>,
+        <<"Record type r2 does not have field y (at line 15, column 22)">>,
+        <<"The field z is missing when constructing an element of type r2 (at line 15, column 24)">>,
         <<"Repeated name x in pattern\n"
           "  x :: x (at line 26, column 7)">>,
-        <<"No record type with fields y, z (at line 14, column 22)">>,
+        <<"No record type with fields y, z (at line 14, column 22)">>]}
-        <<"The field z is missing when constructing an element of type r2 (at line 15, column 24)">>,
-        <<"Record type r2 does not have field y (at line 15, column 22)">>]}
     , {"init_type_error",
        [<<"Cannot unify string\n"
           "         and map(int, int)\n"
@@ -194,27 +167,4 @@ failing_contracts() ->
        [<<"The field x is missing when constructing an element of type r('a) (at line 7, column 40)">>,
         <<"The field y is missing when constructing an element of type r(int) (at line 8, column 40)">>,
         <<"The fields y, z are missing when constructing an element of type r('1) (at line 6, column 40)">>]}
-    , {"namespace_clash",
-       [<<"The contract Call (at line 4, column 10) has the same name as a namespace at (builtin location)">>]}
-    , {"bad_events",
-        [<<"The payload type int (at line 10, column 30) should be string">>,
-         <<"The payload type alias_address (at line 12, column 30) equals address but it should be string">>,
-         <<"The indexed type string (at line 9, column 25) is not a word type">>,
-         <<"The indexed type alias_string (at line 11, column 25) equals string which is not a word type">>]}
-    , {"bad_events2",
-        [<<"The event constructor BadEvent1 (at line 9, column 7) has too many non-indexed values (max 1)">>,
-         <<"The event constructor BadEvent2 (at line 10, column 7) has too many indexed values (max 3)">>,
-         <<"The event constructor BadEvent3 (at line 11, column 7) has too many non-indexed values (max 1)">>,
-         <<"The payload type address (at line 11, column 17) should be string">>,
-         <<"The payload type int (at line 11, column 26) should be string">>]}
-    , {"type_clash",
-        [<<"Cannot unify int\n"
-           "         and string\n"
-           "when checking the record projection at line 12, column 40\n"
-           "  r.foo : (gas : int, value : int) => Remote.themap\n"
-           "against the expected type\n"
-           "  (gas : int, value : int) => map(string, int)">>]}
-    , {"bad_include_and_ns",
-        [<<"Include of 'included.aes' at line 2, column 11\nnot allowed, include only allowed at top level.">>,
-         <<"Nested namespace not allowed\nNamespace 'Foo' at line 3, column 13 not defined at top level.">>]}
     ].

test/aeso_eunit_SUITE.erl

@@ -12,11 +12,9 @@ groups() ->
                  , aeso_parser_tests
                  , aeso_compiler_tests
                  , aeso_abi_tests
-		 , aeso_aci_tests
                  ]}].
 
 aeso_scan_tests(_Config)   -> ok = eunit:test(aeso_scan_tests).
 aeso_parser_tests(_Config) -> ok = eunit:test(aeso_parser_tests).
 aeso_compiler_tests(_Config) -> ok = eunit:test(aeso_compiler_tests).
 aeso_abi_tests(_Config) -> ok = eunit:test(aeso_abi_tests).
-aeso_aci_tests(_Config) -> ok = eunit:test(aeso_aci_tests).

test/contract_tests.erl

@@ -0,0 +1,28 @@
+-module(contract_tests).
+
+-include_lib("eunit/include/eunit.hrl").
+
+make_cmd() -> "make -C " ++ aeso_test_utils:contract_path().
+
+contracts_test_() ->
+    {setup,
+     fun()  -> os:cmd(make_cmd()) end,
+     fun(_) -> os:cmd(make_cmd() ++ " clean") end,
+     [ {"Testing the " ++ Contract ++ " contract",
+        fun() ->
+          ?assertCmdOutput(Expected, filename:join(aeso_test_utils:contract_path(), Contract ++ "_test"))
+        end} || {Contract, Expected} <- contracts() ]}.
+
+contracts() ->
+    [].
+  %% [{"voting",
+  %%   "Delegate before vote\n"
+  %%   "Cake: 1\n"
+  %%   "Beer: 2\n"
+  %%   "Winner: Beer\n"
+  %%   "Delegate after vote\n"
+  %%   "Cake: 1\n"
+  %%   "Beer: 2\n"
+  %%   "Winner: Beer\n"
+  %% }].
+

test/contracts/bad_events.aes

@@ -1,25 +0,0 @@
-contract Events =
-  type alias_int = int
-  type alias_address = address
-  type alias_string = string
-
-  datatype event =
-      Event1(indexed alias_int, indexed int, string)
-    | Event2(alias_string, indexed alias_address)
-    | BadEvent1(indexed string, string)
-    | BadEvent2(indexed int, int)
-    | BadEvent3(indexed alias_string, string)
-    | BadEvent4(indexed int, alias_address)
-
-  function f1(x : int, y : string) =
-    Chain.event(Event1(x, x+1, y))
-
-  function f2(s : string) =
-    Chain.event(Event2(s, Call.caller))
-
-  function f3(x : int) =
-    Chain.event(Event1(x, x + 2, Int.to_str(x + 7)))
-
-  function i2s(i : int) = Int.to_str(i)
-  function a2s(a : address) = Address.to_str(a)
-

test/contracts/bad_events2.aes

@@ -1,24 +0,0 @@
-contract Events =
-  type alias_int = int
-  type alias_address = address
-  type alias_string = string
-
-  datatype event =
-      Event1(indexed alias_int, indexed int, string)
-    | Event2(alias_string, indexed alias_address)
-    | BadEvent1(string, string)
-    | BadEvent2(indexed int, indexed int, indexed int, indexed address)
-    | BadEvent3(address, int)
-
-  function f1(x : int, y : string) =
-    Chain.event(Event1(x, x+1, y))
-
-  function f2(s : string) =
-    Chain.event(Event2(s, Call.caller))
-
-  function f3(x : int) =
-    Chain.event(Event1(x, x + 2, Int.to_str(x + 7)))
-
-  function i2s(i : int) = Int.to_str(i)
-  function a2s(a : address) = Address.to_str(a)
-

test/contracts/bad_include_and_ns.aes

@@ -1,6 +0,0 @@
-contract Bad =
-  include "included.aes"
-  namespace Foo =
-    function foo() = 42
-
-  function foo() = 43

test/contracts/chain.aes

@@ -1,6 +1,6 @@
 // Test more advanced chain interactions
 
-contract ChainTest =
+contract Chain =
 
   record state = { last_bf : address }
 
@@ -10,4 +10,4 @@ contract ChainTest =
   function miner() = Chain.coinbase
 
   function save_coinbase() =
-    put(state{last_bf = Chain.coinbase})
+    put(state{last_bf = Chain.coinbase})

test/contracts/deadcode.aes

@@ -1,21 +0,0 @@
-
-namespace List =
-
-  function map1(f : 'a => 'b, xs : list('a)) =
-    switch(xs)
-      [] => []
-      x :: xs => f(x) :: map1(f, xs)
-
-  function map2(f : 'a => 'b, xs : list('a)) =
-    switch(xs)
-      [] => []
-      x :: xs => f(x) :: map2(f, xs)
-
-contract Deadcode =
-
-  function inc1(xs : list(int)) : list(int) =
-    List.map1((x) => x + 1, xs)
-
-  function inc2(xs : list(int)) : list(int) =
-    List.map1((x) => x + 1, xs)
-

test/contracts/include.aes

@@ -1,9 +0,0 @@
-include "included.aes"
-include "../contracts/included2.aes"
-
-contract Include =
-  function foo() =
-    Included.foo() < Included2a.bar()
-
-  function bar() =
-    Included2b.foo() > Included.foo()

test/contracts/included.aes

@@ -1,2 +0,0 @@
-namespace Included =
-  function foo() = 42

test/contracts/included2.aes

@@ -1,5 +0,0 @@
-namespace Included2a =
-  function bar() = 43
-
-namespace Included2b =
-  function foo() = 44

test/contracts/namespace_clash.aes

@@ -1,5 +0,0 @@
-
-// You can't shadow existing contracts or namespaces.
-
-contract Call =
-  function whatever() = ()

test/contracts/namespaces.aes

@@ -1,21 +0,0 @@
-
-namespace Lib =
-
-  private function rev(xs, ys) =
-    switch(xs)
-      []      => ys
-      x :: xs => rev(xs, x :: ys)
-
-  function reverse(xs : list('a)) : list('a) = rev(xs, [])
-
-  function eqlist(xs : list(int), ys : list(int)) =
-    switch((xs, ys))
-      ([], [])           => true
-      (x :: xs, y :: ys) => x == y && eqlist(xs, ys)
-      _                  => false
-
-contract TestNamespaces =
-
-  function palindrome(xs : list(int)) : bool =
-    Lib.eqlist(xs, Lib.reverse(xs))
-

test/contracts/nodeadcode.aes

@@ -1,21 +0,0 @@
-
-namespace List =
-
-  function map1(f : 'a => 'b, xs : list('a)) =
-    switch(xs)
-      [] => []
-      x :: xs => f(x) :: map1(f, xs)
-
-  function map2(f : 'a => 'b, xs : list('a)) =
-    switch(xs)
-      [] => []
-      x :: xs => f(x) :: map2(f, xs)
-
-contract Deadcode =
-
-  function inc1(xs : list(int)) : list(int) =
-    List.map1((x) => x + 1, xs)
-
-  function inc2(xs : list(int)) : list(int) =
-    List.map2((x) => x + 1, xs)
-

test/contracts/simple_storage.aes

@@ -18,6 +18,7 @@
 
 contract SimpleStorage =
 
+  type event = int
   record state = { data : int }
 
   function init(value : int) : state = { data = value }

test/contracts/state_handling.aes

@@ -1,22 +1,19 @@
 contract Remote =
-  record rstate = { i : int, s : string, m : map(int, int) }
+  function look_at : (state) => ()
-
-  function look_at : (rstate) => ()
   function return_s : (bool) => string
   function return_m : (bool) => map(int, int)
-  function get : (rstate) => rstate
+  function get : (state) => state
-  function get_i : (rstate) => int
+  function get_i : (state) => int
-  function get_s : (rstate) => string
+  function get_s : (state) => string
-  function get_m : (rstate) => map(int, int)
+  function get_m : (state) => map(int, int)
 
-  function fun_update_i  : (rstate, int)           => rstate
+  function fun_update_i  : (state, int)           => state
-  function fun_update_s  : (rstate, string)        => rstate
+  function fun_update_s  : (state, string)        => state
-  function fun_update_m  : (rstate, map(int, int)) => rstate
+  function fun_update_m  : (state, map(int, int)) => state
-  function fun_update_mk : (rstate, int, int)      => rstate
+  function fun_update_mk : (state, int, int)      => state
 
 contract StateHandling =
-
+  record state = { i : int, s : string, m : map(int, int) }
-  type state = Remote.rstate
 
   function init(r : Remote, i : int) =
     let state0 = { i = 0, s = "undefined", m = {} }

test/contracts/type_clash.aes

@@ -1,13 +0,0 @@
-
-contract Remote =
-
-  type themap = map(int, string)
-  function foo : () => themap
-
-contract Main =
-
-  type themap = map(string, int)
-
-  // Should fail
-  function foo(r : Remote) : themap = r.foo()
-