QPQ-AG/hakuzaru
11
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

General polish #28

Merged
dimitar.p.ivanov merged 4 commits from improve_specs into master 2026-05-22 16:54:18 +09:00
Conversation 1 Commits 4 Files Changed 1
+10 -3
dimitar.p.ivanov commented 2026-05-20 23:03:15 +09:00
Owner
Copy Link
Copy Source
No description provided.
dimitar.p.ivanov added 2 commits 2026-05-20 23:03:16 +09:00
Improve specs f0f86ed36d
Fix a contract create bug 88aeb39d4a
dimitar.p.ivanov requested review from zxq9 2026-05-20 23:03:16 +09:00
zxq9 reviewed 2026-05-21 16:17:14 +09:00
src/hz.erl Outdated
@@ -814,3 +818,3 @@
Error ->
io:format("Dis chit happen: ~tp~n", [Error]),
{ok, TarBaby}
{ok, unicode:characters_to_list(TarBaby)}
zxq9 commented 2026-05-21 16:17:14 +09:00
Owner
Copy Link
Copy Source

There is no guarantee that anything committed in the source element is valid unicode, so we have to leave the casting from binary to list up to the caller. That's why the original didn't even care to match on "ba_" as a prefix -- if we can't decode then we're talking to an alien node interface to begin with, and just return the return.

There is no guarantee that anything committed in the source element is valid unicode, so we have to leave the casting from binary to list up to the caller. That's why the original didn't even care to match on "ba_" as a prefix -- if we can't decode then we're talking to an alien node interface to begin with, and just return the return.
zxq9 commented 2026-05-21 16:27:13 +09:00
Owner
Copy Link
Copy Source

@dimitar.p.ivanov mentions in a call that this satisfies Dialyzer -- so I'll look into that and see why.

@dimitar.p.ivanov mentions in a call that this satisfies Dialyzer -- so I'll look into that and see why.
❤️ 1
dimitar.p.ivanov added 2 commits 2026-05-22 15:57:14 +09:00
Fix typespec 2a7079129f 
Source needs to be defined as a binary.
Merge pull request 'Fix typespec' (#29) from respec into improve_specs 4530fd2e93 
Reviewed-on: #29
dimitar.p.ivanov merged commit 9a7a2a98c4 into master 2026-05-22 16:54:18 +09:00
Sign in to join this conversation.
Reviewers
No Reviewers
zxq9
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 pig lipstick
Muggle-facing enhancements
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dagadunn Pickmick dimitar.p.ivanov flambard (Markus Flambard) gchewy hans_sv pharpend spivee (Jarvis Carroll) thescientress (Cecille de Jesus) uwiger (Ulf Wiger) zxq9 (Craig Everett)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/hakuzaru#28
Delete Branch "improve_specs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?