QPQ-AG/gmminer
9
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

WIP: AE_DISABLE_CUCKOO env var support #36

Draft
uwiger wants to merge 3 commits from GH-2959-running-on-termux into master
pull from: GH-2959-running-on-termux
merge into: QPQ-AG:master
Conversation 2 Commits 3 Files Changed 3 +63
uwiger commented 2019-10-31 20:59:35 +09:00 (Migrated from gitlab.com)
Copy Link

This is work in progress, experimenting with getting an ae node to build and run on termux (Android).

The idea is to introduce an os env variable, AE_DISABLE_CUCKOO=true (since cuckoo is hard to compile on termux). This would remove cuckoo-related deps, also remove the corresponding app deps from the aeminer.app file, and set an OTP environment variable, {use_cuckoo, false}.

Similar things need to be done in the aeternity repos regarding aestratum, which also depends on cuckoo

This is work in progress, experimenting with getting an `ae` node to build and run on `termux` (Android). The idea is to introduce an os env variable, `AE_DISABLE_CUCKOO=true` (since `cuckoo` is hard to compile on `termux`). This would remove `cuckoo`-related deps, also remove the corresponding app deps from the `aeminer.app` file, and set an OTP environment variable, `{use_cuckoo, false}`. Similar things need to be done in the `aeternity` repos regarding `aestratum`, which also depends on `cuckoo`
zxq9 commented 2019-10-31 21:59:15 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: tolbrino

Wouldn't it make more sense to create a separate rebar profile which removes aeminer and aestratum from the build entirely. E.g. slim profile?

*Created by: tolbrino* Wouldn't it make more sense to create a separate rebar profile which removes `aeminer` and `aestratum` from the build entirely. E.g. `slim` profile?
zxq9 commented 2019-11-27 18:30:12 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: nikita-fuchs

An approach that removes anything that is too picky about system architecture and not necessary to run a "basic passive client" would be really great indeed, the linuxZ mainframe is still waiting for you @tolbrino ;) !

*Created by: nikita-fuchs* An approach that removes anything that is too picky about system architecture and not necessary to run a "basic passive client" would be really great indeed, the linuxZ mainframe is still waiting for you @tolbrino ;) !
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin GH-2959-running-on-termux:GH-2959-running-on-termux
git checkout GH-2959-running-on-termux
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
WIP
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/gmminer#36
No description provided.
Delete Branch "GH-2959-running-on-termux"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?