QPQ-AG/gmminer
9
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Update rebar aecuckooprebuilt plugin #19

Merged
zxq9 merged 2 commits from update-rebar-aecuckooprebuilt-plugin into master 2019-02-14 21:33:32 +09:00
Conversation 8 Commits 2 Files Changed 2 +1 -1
zxq9 commented 2019-02-13 21:44:03 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: jur0

This needs to be merged before https://github.com/aeternity/aeternity/pull/2138

*Created by: jur0* This needs to be merged before https://github.com/aeternity/aeternity/pull/2138
zxq9 commented 2019-02-14 17:49:16 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: ThomasArts

Sorry for my ignorance, but why do we need a rebar3 binary in this repository?

*Created by: ThomasArts* Sorry for my ignorance, but why do we need a rebar3 binary in this repository?
zxq9 commented 2019-02-14 17:54:29 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: jur0

Because I want to build the aeminer without having to use it as a dependency of the ae node. There are also some tests, dialyzer, etc. Also I want to use a specific version of rebar in this repo.

*Created by: jur0* Because I want to build the aeminer without having to use it as a dependency of the ae node. There are also some tests, dialyzer, etc. Also I want to use a specific version of rebar in this repo.
zxq9 commented 2019-02-14 19:17:58 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: tolbrino

In that case you should use the rebar3 version from aeternity itself, because this project will need win32 build support as well.

*Created by: tolbrino* In that case you should use the rebar3 version from aeternity itself, because this project will need win32 build support as well.
zxq9 commented 2019-02-14 19:22:05 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: jur0

The rebar's version I'm trying to update to in this PR is: rebar 3.9.0 on Erlang/OTP 20 Erts 9.3.3.3

*Created by: jur0* The rebar's version I'm trying to update to in this PR is: `rebar 3.9.0 on Erlang/OTP 20 Erts 9.3.3.3`
zxq9 commented 2019-02-14 20:44:50 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: tolbrino

The rebar's version I'm trying to update to in this PR is: rebar 3.9.0 on Erlang/OTP 20 Erts 9.3.3.3

As I said, that version has limited Windows support which might be needed though. So please use the version from aeternity.

*Created by: tolbrino* > The rebar's version I'm trying to update to in this PR is: `rebar 3.9.0 on Erlang/OTP 20 Erts 9.3.3.3` As I said, that version has limited Windows support which might be needed though. So please use the version from aeternity.
zxq9 commented 2019-02-14 21:31:16 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2019-02-14 21:31:30 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: tolbrino

Review: Approved

*Created by: tolbrino* **Review:** Approved
zxq9 commented 2019-02-14 21:33:32 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: jur0 at 2019-02-14 12:33:32 UTC

*Merged by: jur0 at 2019-02-14 12:33:32 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/gmminer#19
No description provided.
Delete Branch "update-rebar-aecuckooprebuilt-plugin"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?