uw-handle-empty-nonces #8

uwiger · 2025-06-17T05:32:18+09:00

uwiger commented

2025-06-17 05:32:18 +09:00

Although mainly a theoretical possibility, the server may send a candidate with nonces := []. If so, we need to request new nonces before populating the workers.

Although mainly a theoretical possibility, the server may send a candidate with `nonces := []`. If so, we need to request new nonces before populating the workers.

uwiger added 2 commits 2025-06-17 05:32:18 +09:00

reset worker on report error 672f2f75c9

Handle empty nonces (zx vsn 0.4.5) c61ce6df1a

uwiger requested review from spivee 2025-06-17 05:32:18 +09:00

uwiger requested review from zxq9 2025-06-17 05:32:19 +09:00

spivee approved these changes 2025-06-17 13:30:14 +09:00

spivee left a comment

I see uw-reset-worker is being merged in here too - but both changes look reasonable.

src/gmhc_server.erl

						
				@ -117,0 +114,4 @@

				        %% Nonces may be [], in which case we need to request new nonces first.

				        #st{candidate = Cand1} = S1 = maybe_request_nonces(S#st{candidate = Cand}),

				        {Workers2, Cand2} = assign_nonces(Workers, Cand1),

				        #st{candidate = Cand3} = S2 = maybe_request_nonces(S1#st{candidate = Cand2}),

spivee commented

2025-06-17 13:05:38 +09:00

If assign_nonces took a single nonce from the list, will this second request immediately fire? I guess that is fine?

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin uw-handle-empty-nonces:uw-handle-empty-nonces

git checkout uw-handle-empty-nonces

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: QPQ-AG/gmhive_client#8