QPQ-AG/gmhive_client
11
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

Report no_solution for all relevant nonces with repeats #14

Merged
uwiger merged 1 commits from uw-repeats-reporting into master 2025-09-27 23:27:57 +09:00
Conversation 0 Commits 1 Files Changed 15
+69 -39
uwiger commented 2025-09-26 06:36:28 +09:00
Owner
Copy Link
Copy Source

If repeats was > 1 (for a GPU miner), the client would only send one no_solution message for the whole batch of nonces, and no no_solution message if even one cycle was found.
This change sends an individual no_solution message for each relevant nonce. Sending one combined message would be more economical, but would require a protocol upgrade.

For better performance, an async_call() method is used. This ignores the reply from the server, and is only used for the no_solution message, which doesn't really return useful data anyway.

Tested (and running) on my 1080ti miner.

If `repeats` was `> 1` (for a GPU miner), the client would only send one `no_solution` message for the whole batch of nonces, and no `no_solution` message if even one cycle was found. This change sends an individual `no_solution` message for each relevant nonce. Sending one combined message would be more economical, but would require a protocol upgrade. For better performance, an `async_call()` method is used. This ignores the reply from the server, and is only used for the `no_solution` message, which doesn't really return useful data anyway. Tested (and running) on my 1080ti miner.
uwiger added 1 commit 2025-09-26 06:36:29 +09:00
Report no_solution for all relevant nonces with repeats 2a33d06bd6
uwiger requested review from spivee 2025-09-26 06:36:30 +09:00
uwiger requested review from zxq9 2025-09-26 06:36:30 +09:00
uwiger merged commit 408bd9fc18 into master 2025-09-27 23:27:57 +09:00
Sign in to join this conversation.
Reviewers
No Reviewers
zxq9
spivee
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 pig lipstick
Muggle-facing enhancements
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Dagadunn Pickmick apex132 dimitar.p.ivanov flambard (Markus Flambard) gchewy hans_sv pharpend spivee (Jarvis Carroll) thescientress (Cecille de Jesus) uwiger (Ulf Wiger) zxq9 (Craig Everett)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/gmhive_client#14