QPQ-AG/gmhive_client
10
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

uw-handle-empty-nonces #8

Merged
uwiger merged 2 commits from uw-handle-empty-nonces into master 2025-08-21 03:42:38 +09:00
Conversation 2 Commits 2 Files Changed 3 +17 -13
uwiger commented 2025-06-17 05:32:18 +09:00
Owner
Copy Link

Although mainly a theoretical possibility, the server may send a candidate with nonces := []. If so, we need to request new nonces before populating the workers.

Although mainly a theoretical possibility, the server may send a candidate with `nonces := []`. If so, we need to request new nonces before populating the workers.
uwiger added 2 commits 2025-06-17 05:32:18 +09:00
uwiger requested review from spivee 2025-06-17 05:32:18 +09:00
uwiger requested review from zxq9 2025-06-17 05:32:19 +09:00
spivee approved these changes 2025-06-17 13:30:14 +09:00
spivee left a comment
Member
Copy Link

I see uw-reset-worker is being merged in here too - but both changes look reasonable.

I see uw-reset-worker is being merged in here too - but both changes look reasonable.
src/gmhc_server.erl
@ -117,0 +114,4 @@
%% Nonces may be [], in which case we need to request new nonces first.
#st{candidate = Cand1} = S1 = maybe_request_nonces(S#st{candidate = Cand}),
{Workers2, Cand2} = assign_nonces(Workers, Cand1),
#st{candidate = Cand3} = S2 = maybe_request_nonces(S1#st{candidate = Cand2}),
spivee commented 2025-06-17 13:05:38 +09:00
Member
Copy Link

If assign_nonces took a single nonce from the list, will this second request immediately fire? I guess that is fine?

If assign_nonces took a single nonce from the list, will this second request immediately fire? I guess that is fine?
zxq9 commented 2025-08-08 10:28:14 +09:00
Owner
Copy Link

Would it be reasonable for the client to proceed, but on his own randomly picked nonce? The search space is quite enormous.

Then again, that might require some logic on the leader to track random nonce(s) that some client submitted.

Would it be reasonable for the client to proceed, but on his own randomly picked nonce? The search space is quite enormous. Then again, that might require some logic on the leader to track random nonce(s) that some client submitted.
uwiger merged commit 5bc0fc5ff8 into master 2025-08-21 03:42:38 +09:00
Sign in to join this conversation.
Reviewers
No Reviewers
zxq9
spivee
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/gmhive_client#8
No description provided.
Delete Branch "uw-handle-empty-nonces"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?