QPQ-AG/gmbytecode
10
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 9 Wiki Activity

Introduce debugging instructions #230

Merged
ghallak merged 21 commits from ghallak/dbgloc-op into master 2023-05-26 00:09:42 +09:00
Conversation 9 Commits 21 Files Changed 3 +8 -3
ghallak commented 2023-01-30 19:54:23 +09:00 (Migrated from gitlab.com)
Copy Link
No description provided.
ghallak commented 2023-02-05 20:50:51 +09:00 (Migrated from gitlab.com)
Copy Link

Change the doc for all debug opcodes. Describe purpose and args.

Change the doc for all debug opcodes. Describe purpose and args.
zxq9 commented 2023-02-05 21:03:16 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

I think it would be better to have dbg instructions indicating function calls:

DBG_CALL (contract_pk, fun_name, is_tail_call)
DBG_RETURN

This way we have better control over function names and we can selectively handle tail recursion

*Created by: radrow* I think it would be better to have dbg instructions indicating function calls: ``` DBG_CALL (contract_pk, fun_name, is_tail_call) DBG_RETURN ``` This way we have better control over function names and we can selectively handle tail recursion
zxq9 commented 2023-04-28 21:33:02 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

This is AEVM, right?

*Created by: hanssv* This is AEVM, right?
zxq9 commented 2023-04-28 21:36:45 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

No, fate

*Created by: radrow* No, fate
zxq9 commented 2023-05-23 16:35:02 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Are you sure? I think aeb_opcodes.hrl is only used for AEVM byte code as far as I can see. So I don't think we need to add debug instructions there?

*Created by: hanssv* Are you sure? I think `aeb_opcodes.hrl` is only used for AEVM byte code as far as I can see. So I don't think we need to add debug instructions there?
ghallak commented 2023-05-23 18:08:36 +09:00 (Migrated from gitlab.com)
Copy Link

@hanssv I've reverted the changed to aeb_opcodes.hrl and aeb_opcodes.erl here 5eaae614ce.

@hanssv I've reverted the changed to `aeb_opcodes.hrl` and `aeb_opcodes.erl` here 5eaae614ce496b2c9e3a6da4124fd1dd62da4af3.
zxq9 commented 2023-05-23 18:14:55 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2023-05-25 22:53:51 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Review: Approved

*Created by: radrow* **Review:** Approved
zxq9 commented 2023-05-26 00:09:42 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: ghallak at 2023-05-25 15:09:42 UTC

*Merged by: ghallak at 2023-05-25 15:09:42 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/gmbytecode#230
No description provided.
Delete Branch "ghallak/dbgloc-op"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?