QPQ-AG/gmbytecode
10
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 9 Wiki Activity

Restore old binary and string comparison #216

Merged
zxq9 merged 1 commits from revert-string-compare into master 2021-04-14 20:25:35 +09:00
Conversation 5 Commits 1 Files Changed 1 +13 -4
zxq9 commented 2021-04-14 20:08:09 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: cytadela8

Binary and string comparison is under consensus

This partially reverts commit d16f9a9579.

*Created by: cytadela8* Binary and string comparison is under consensus This partially reverts commit d16f9a9579d0b901d8deb17dec87f6aa36d09744.
zxq9 commented 2021-04-14 20:10:20 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: cytadela8

stability of aeb_fate_encoding serialization of maps relies on sorting of keys using aeb_fata_date:elt thus we can't unfortunately change string ordering

*Created by: cytadela8* stability of aeb_fate_encoding serialization of maps relies on sorting of keys using `aeb_fata_date:elt` thus we can't unfortunately change string ordering
zxq9 commented 2021-04-14 20:13:01 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Ouch, so we were using that function somewhere....

*Created by: hanssv* Ouch, so we were using that function somewhere....
zxq9 commented 2021-04-14 20:13:25 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2021-04-14 20:25:18 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: velzevur

Review: Approved

*Created by: velzevur* **Review:** Approved
zxq9 commented 2021-04-14 20:25:35 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: cytadela8 at 2021-04-14 11:25:35 UTC

*Merged by: cytadela8 at 2021-04-14 11:25:35 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/gmbytecode#216
No description provided.
Delete Branch "revert-string-compare"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?