QPQ-AG/gmbytecode
10
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 9 Wiki Activity

Avoid unnecessery calls to eblake2 #212

Merged
zxq9 merged 1 commits from precalculate-init-id into master 2021-03-23 17:57:12 +09:00
Conversation 7 Commits 1 Files Changed 2 +5 -3
zxq9 commented 2021-03-22 23:18:24 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: cytadela8

We frequently need identifier of init function. Store it precalculated in headers.

*Created by: cytadela8* We frequently need identifier of init function. Store it precalculated in headers.
gorbak25 (Migrated from gitlab.com) approved these changes 2021-03-22 23:18:24 +09:00
zxq9 commented 2021-03-22 23:19:35 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: cytadela8

Dialyzer fails with:

===> Error in dialyzing apps: Analysis failed with error:
Could not scan the following file(s):
  Could not get Core Erlang code for: /home/builder/aebytecode/_build/local/lib/aebytecode/ebin/aeb_fate_generate_ops.beam

investigating...

*Created by: cytadela8* Dialyzer fails with: ``` ===> Error in dialyzing apps: Analysis failed with error: Could not scan the following file(s): Could not get Core Erlang code for: /home/builder/aebytecode/_build/local/lib/aebytecode/ebin/aeb_fate_generate_ops.beam ``` investigating...
zxq9 commented 2021-03-23 01:23:50 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: cytadela8

Bumping CI cache version doesn't help

*Created by: cytadela8* Bumping CI cache version doesn't help
zxq9 commented 2021-03-23 01:34:34 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Maybe consider a memorized special case in aeb_fate_asm:mk_hash/1 so this thing will propagate through all of the places?

*Created by: radrow* Maybe consider a memorized special case in `aeb_fate_asm:mk_hash/1` so this thing will propagate through all of the places?
gorbak25 commented 2021-03-23 17:49:15 +09:00 (Migrated from gitlab.com)
Copy Link

approved this merge request

approved this merge request
zxq9 commented 2021-03-23 17:51:21 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Review: Approved

*Created by: radrow* **Review:** Approved
zxq9 commented 2021-03-23 17:57:12 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: cytadela8 at 2021-03-23 08:57:12 UTC

*Merged by: cytadela8 at 2021-03-23 08:57:12 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
gorbak25
Labels
Clear labels
WIP
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/gmbytecode#212
No description provided.
Delete Branch "precalculate-init-id"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?