QPQ-AG/gmbytecode
10
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 9 Wiki Activity

PT-167221635 remote type check #184

Merged
zxq9 merged 4 commits from PT-167221635-remote-type-check into master 2019-08-16 16:10:48 +09:00
Conversation 4 Commits 4 Files Changed 5 +24 -17
zxq9 commented 2019-08-14 16:14:52 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Changes the arity argument to remote calls to typereps for arguments and result. We need these to do proper runtime type checking of remote calls.

*Created by: UlfNorell* - [PT-167221671](https://www.pivotaltracker.com/story/show/167221671) - [PT-167221635](https://www.pivotaltracker.com/story/show/167221635) - aeternity/aesophia#123 - aeternity/aeternity#2650 Changes the arity argument to remote calls to typereps for arguments and result. We need these to do proper runtime type checking of remote calls.
zxq9 commented 2019-08-14 16:16:50 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

    , { 'CALL_R',              16#03,   true,   false,   true,  8, [a,is,a,a,a],      call_r, {contract, string, typerep, typerep, integer},     any, "Remote call to contract Arg0 and function Arg1 of type Arg2 => Arg3 with value Arg4. The types of the arguments has to match the argument types of the function."}
*Created by: hanssv* ```suggestion:-0+0 , { 'CALL_R', 16#03, true, false, true, 8, [a,is,a,a,a], call_r, {contract, string, typerep, typerep, integer}, any, "Remote call to contract Arg0 and function Arg1 of type Arg2 => Arg3 with value Arg4. The types of the arguments has to match the argument types of the function."} ```
zxq9 commented 2019-08-14 20:05:59 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2019-08-15 22:15:18 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: ThomasArts

Review: Approved

*Created by: ThomasArts* **Review:** Approved
zxq9 commented 2019-08-16 16:10:48 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: UlfNorell at 2019-08-16 07:10:48 UTC

*Merged by: UlfNorell at 2019-08-16 07:10:48 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/gmbytecode#184
No description provided.
Delete Branch "PT-167221635-remote-type-check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?