QPQ-AG/gmbytecode
10
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 9 Wiki Activity

Pt 166927306 names as strings #178

Merged
gorillainduction merged 2 commits from PT-166927306-names-as-strings into master 2019-06-28 20:48:43 +09:00
Conversation 14 Commits 2 Files Changed 2 +42 -29
gorillainduction commented 2019-06-28 17:43:14 +09:00 (Migrated from gitlab.com)
Copy Link

https://www.pivotaltracker.com/story/show/166927306

https://www.pivotaltracker.com/story/show/166927306
gorillainduction commented 2019-06-28 17:51:14 +09:00 (Migrated from gitlab.com)
Copy Link

Holdning this merge until the release of 3.2 of the compiler is done.

Holdning this merge until the release of 3.2 of the compiler is done.
zxq9 commented 2019-06-28 18:00:06 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

The reason to not renumber these is that the numbers are also used in lt below.

*Created by: UlfNorell* The reason to not renumber these is that the numbers are also used in `lt` below.
zxq9 commented 2019-06-28 18:06:31 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

If the FATE_LIST_VALUE match is replaced by IS_FATE_LIST then the number could be removed from lt.

*Created by: happi* If the FATE_LIST_VALUE match is replaced by IS_FATE_LIST then the number could be removed from lt.
zxq9 commented 2019-06-28 18:07:57 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

And the FATE_STRING.

*Created by: happi* And the FATE_STRING.
zxq9 commented 2019-06-28 18:15:27 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

This is only tested in the quick check tests. Perhaps leave the renumbering and I can do it in a separate PR also adding tests. https://www.pivotaltracker.com/story/show/166975637

*Created by: happi* This is only tested in the quick check tests. Perhaps leave the renumbering and I can do it in a separate PR also adding tests. https://www.pivotaltracker.com/story/show/166975637
gorillainduction commented 2019-06-28 18:24:31 +09:00 (Migrated from gitlab.com)
Copy Link

What about this for the ordinals?

What about this for the ordinals?
zxq9 commented 2019-06-28 18:29:17 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Review: Approved

*Created by: UlfNorell* **Review:** Approved
zxq9 commented 2019-06-28 18:35:22 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

Better.
I noticed that bytes and strings now compare differently internally. Hashes and signatures had fixed sizes but bytes have a size. For strings we first compare the size and then the binary (in Erlang <<1, 1>> < <<2>> but in fate "AA" > "B"). Bytes should work the same way.

*Created by: happi* Better. I noticed that bytes and strings now compare differently internally. Hashes and signatures had fixed sizes but bytes have a size. For strings we first compare the size and then the binary (in Erlang <<1, 1>> < <<2>> but in fate "AA" > "B"). Bytes should work the same way.
zxq9 commented 2019-06-28 18:37:52 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

Review: Approved

*Created by: happi* **Review:** Approved
zxq9 commented 2019-06-28 18:39:39 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

For strings we first compare the size and then the binary

Why do we do this though? The Erlang comparison is simpler.

*Created by: UlfNorell* > For strings we first compare the size and then the binary Why do we do this though? The Erlang comparison is simpler.
zxq9 commented 2019-06-28 18:45:26 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

@ThomasAerts had some rationale.

*Created by: happi* @ThomasAerts had some rationale.
zxq9 commented 2019-06-28 19:22:01 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

I'm sure it was it was a valid reason and not based on troll logic.

*Created by: UlfNorell* I'm sure it was it was a valid reason and not based on troll logic.
zxq9 commented 2019-06-28 20:27:36 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Anyway, in type correct code you never compare byte arrays of different sizes, so comparing the sizes is extra redundant.

*Created by: UlfNorell* Anyway, in type correct code you never compare byte arrays of different sizes, so comparing the sizes is extra redundant.
zxq9 commented 2019-06-28 20:48:43 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: gorillainduction at 2019-06-28 11:48:43 UTC

*Merged by: gorillainduction at 2019-06-28 11:48:43 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
WIP
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/gmbytecode#178
No description provided.
Delete Branch "PT-166927306-names-as-strings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?