QPQ-AG/gmbytecode
10
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 9 Wiki Activity

Fate crypto ops + contract_to_address #166

Merged
zxq9 merged 2 commits from fate-crypto-ops into master 2019-06-11 18:57:58 +09:00
Conversation 5 Commits 2 Files Changed 1 +12 -8
zxq9 commented 2019-06-11 18:42:04 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

*Created by: hanssv*
zxq9 commented 2019-06-11 18:42:50 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

https://www.pivotaltracker.com/story/show/162578842 and https://www.pivotaltracker.com/story/show/162578820

*Created by: hanssv* https://www.pivotaltracker.com/story/show/162578842 and https://www.pivotaltracker.com/story/show/162578820
zxq9 commented 2019-06-11 18:50:40 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Review: Approved

*Created by: UlfNorell* **Review:** Approved
zxq9 commented 2019-06-11 18:55:18 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Note: we decided to generalise the string hash instructions rather than adding two sets of instructions. The implementation (in a future aeternity PR) hashes strings as plain binaries, thus preserving the behaviour of the string hashing instructions. This means that we introduce some extra collisions: between a term t (of type other than string) and a string that contains the encoding of t. We deemed this to not be a problem.

*Created by: UlfNorell* Note: we decided to generalise the string hash instructions rather than adding two sets of instructions. The implementation (in a future aeternity PR) hashes strings as plain binaries, thus preserving the behaviour of the string hashing instructions. This means that we introduce some extra collisions: between a term `t` (of type other than string) and a string that contains the encoding of `t`. We deemed this to not be a problem.
zxq9 commented 2019-06-11 18:57:05 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: ThomasArts

Review: Approved

*Created by: ThomasArts* **Review:** Approved
zxq9 commented 2019-06-11 18:57:58 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: hanssv at 2019-06-11 09:57:58 UTC

*Merged by: hanssv at 2019-06-11 09:57:58 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/gmbytecode#166
No description provided.
Delete Branch "fate-crypto-ops"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?